GitLab

Summary:
this was previously wrong in two ways:

1. errors from the password check would previously be ignored but
   still end in early termination of the mount command despite that command
   not having finished (successfully)
2. since the password check is always run we may not actually require
   auth data in which case it is perfectly reasonable for the user to
   cancel the auth request (the user experience sucks, but there's not
   much we can do within the special command I think)

to solve both issues special now exists in error when there was an error
forwarded out of checkpassword (e.g. kiod is broken) BUT NOT when that
error is that the user canceled the auth query.

no auth info being provided is already supported later on in the actual
mount code.

testing code for posterity
```
#define KIO_ARGS QByteArray packedArgs; QDataStream stream( &packedArgs, QIODevice::WriteOnly ); stream

    KIO_ARGS << int(1)
             << QString("\\\\HOST/PATH/") // remotepath
             << QString("/LOCAL/MNT") // mountpoint
                ;
    auto job = KIO::special(QUrl("smb://HOST/PATH/"), packedArgs);
```

Test Plan:
# broken kiod

- run job
- get error about broken kiod

# cancel with working kiod

- run job
- get error about smbmount not being installed (bc it hasn't been a thing since the 2000's ;))

Reviewers: dfaure

Reviewed By: dfaure

Subscribers: kde-frameworks-devel, kfm-devel

Tags: #dolphin, #frameworks

Differential Revision: https://phabricator.kde.org/D24487

Summary:
previously we'd not forward the errors coming out of the password dialog
helper and instead eventually end up on generic access denied errors.
seeing as the access denied is likely because we couldn't query auth info
that is fairly misleading.

checkPassword is now returning an error code instead of a bool. when we
actually consider checkPassword an error we'll now raise this error
instead of the generic access denied errors. when the user canceled
the query we'll continue to raise the more topical error from smb (e.g.
"access denied")

primarily these errors appear when kiod/kpasswdserver is defunct
or not installed meaning query functionality will not work at all.

Test Plan:
# broken kiod

- remove dbus service file
- kill
- dolphin smb://host
- no auth query
- error about broken dialog

# cancel

- repair kiod
- dolphin smb://host
- auth query
- cancel
- auth query
- cancel
- error about access denied (because refused to authenticate)

Reviewers: #frameworks, dfaure

Reviewed By: dfaure

Subscribers: ngraham, kde-frameworks-devel, kfm-devel

Tags: #dolphin, #frameworks

Differential Revision: https://phabricator.kde.org/D24387

Summary:
This patch does the following:

1. Fixing instances of finished() being called after error() in smb slave.

2. Changing behaviour of the sftp/smb slave to conform to  what is stated in D23194. In particular, the sftp slave should not call finished() in the open()/read()/write()/seek() methods.

Test Plan: It compiles...

Reviewers: chinmoyr, fvogt, sitter, dfaure

Reviewed By: dfaure

Subscribers: bcooksley, kde-frameworks-devel, kfm-devel

Tags: #dolphin, #frameworks

Differential Revision: https://phabricator.kde.org/D23207

In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"

Alexander Saoutkin authored Aug 26, 2019 and Fabian Vogt committed Aug 26, 2019

Summary:
This patch fixes two cases where invalid KTMPFile objects would be treated as
valid. In particular, this would manifest in KIO::stat() and KIO::mimetype()
returning without error when they, in fact, should do. One would note that in
the rest of the code, KMTPFile objects that are received via
KMTPStorageInterface::getFileMetaData() always have a isValid() check applied
before use. The two previously mentioned functions, incorrectly, do not have
this check applied. This patch simply adds these necessary checks.

Test Plan:
KIOFuse uses KIO::stat() to complete a lookup. Before this patch lookup would
always succeed and this was determined to be because stat would always succeed.
This bug could be easily found as tab completion would never work correctly.
Trying to tab complete would seem to add what was already typed in to the
directory. With this patch applied, lookup no longer always succeeds and tab
completion now works.

Reviewers: chinmoyr, akrutzler, elvisangelaccio, dfaure

Reviewed By: dfaure

Subscribers: kde-frameworks-devel, kfm-devel, fvogt

Tags: #dolphin, #frameworks

Differential Revision: https://phabricator.kde.org/D23454

Summary:
The text thumbnailer currently excludes .directory files from receiving text file
thumbnails, but does not do the same for .directory and .flatpakref files which are
the same things (actually text files that don't look, feel, or behave like text files).

This patch extends the same logic to those types of files as well, making them not
receive text previews and instead show their base mimetype or icon (if defined in the
file).

BUG: 410561
BUG: 400201
FIXED-IN: 19.08.0

Test Plan: {F7161776, size=full}

Reviewers: #vdg, #frameworks, broulik

Reviewed By: broulik

Subscribers: kde-frameworks-devel, kfm-devel

Tags: #dolphin, #frameworks

Differential Revision: https://phabricator.kde.org/D22936

In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"

In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"

In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"

In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"

Jonathan Marten authored Nov 28, 2017 and Luigi Toscano committed Jul 18, 2019

Summary:
That page, and many others, links to another page with just a plain name:

  .so PAM.8

This is read by man2html and passed to MANProtocol::readManPage() with a filename of "../PAM.8".  This is then resolved against the containing directory "/usr/share/man/man8", becoming "/usr/share/man/PAM.8".  No such file exists and the mandir.entryList().first() asserts because the list is empty.

The relative filename is correct in the case of other pages. e.g. telinit(8) which uses:

  .so man8/init.8

So it is not enough to simply ignore the "..".  The change to man2html here attempts to correct the reference by detecting whether it is of the form "../page.sect" and is not "../manN/page.sect", and removing the ".." component only in the first case.

While investigating this I found it useful to have a better diagnostic if the .so page could not be found.  The change here to kio_man.cpp detects that case and displays an error page instead of asserting.  This should only happen if there is a bug in the man page, but it is useful to have a pointer so that the upstream man page can be fixed.

Test Plan:
Built kio_extras with this change.  Verified correct display of the man pages:

  man:/pam(8) - simple page name
  man:/service(8)
  man:/telinit(8) - relative page name with section
  man:/vigr(8)
  man:/mq_open(2) - relative page name to another section

Reviewers: #plasma, kfm-devel, mkoller

Reviewed By: mkoller

Subscribers: ltoscano, kde-frameworks-devel, apol, plasma-devel

Tags: #plasma, #documentation, #dolphin, #frameworks

Differential Revision: https://phabricator.kde.org/D9033

In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"

In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"

In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"

In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"

In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"

In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"

In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"

In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"

In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"

In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"

In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"

In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"

In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"

In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"

BUG: 406294
FIXED-IN: 19.08.0

In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"