1. 17 Oct, 2019 1 commit
    • Harald Sitter's avatar
      fix password error condition handling of smb mount · 45b1327a
      Harald Sitter authored
      Summary:
      this was previously wrong in two ways:
      
      1. errors from the password check would previously be ignored but
         still end in early termination of the mount command despite that command
         not having finished (successfully)
      2. since the password check is always run we may not actually require
         auth data in which case it is perfectly reasonable for the user to
         cancel the auth request (the user experience sucks, but there's not
         much we can do within the special command I think)
      
      to solve both issues special now exists in error when there was an error
      forwarded out of checkpassword (e.g. kiod is broken) BUT NOT when that
      error is that the user canceled the auth query.
      
      no auth info being provided is already supported later on in the actual
      mount code.
      
      testing code for posterity
      ```
      #define KIO_ARGS QByteArray packedArgs; QDataStream stream( &packedArgs, QIODevice::WriteOnly ); stream
      
          KIO_ARGS << int(1)
                   << QString("\\\\HOST/PATH/") // remotepath
                   << QString("/LOCAL/MNT") // mountpoint
                      ;
          auto job = KIO::special(QUrl("smb://HOST/PATH/"), packedArgs);
      ```
      
      Test Plan:
      # broken kiod
      
      - run job
      - get error about broken kiod
      
      # cancel with working kiod
      
      - run job
      - get error about smbmount not being installed (bc it hasn't been a thing since the 2000's ;))
      
      Reviewers: dfaure
      
      Reviewed By: dfaure
      
      Subscribers: kde-frameworks-devel, kfm-devel
      
      Tags: #dolphin, #frameworks
      
      Differential Revision: https://phabricator.kde.org/D24487
      45b1327a
  2. 08 Oct, 2019 1 commit
    • Harald Sitter's avatar
      improve error reporting for when kpasswdserver is unreachable · 5a870554
      Harald Sitter authored
      Summary:
      previously we'd not forward the errors coming out of the password dialog
      helper and instead eventually end up on generic access denied errors.
      seeing as the access denied is likely because we couldn't query auth info
      that is fairly misleading.
      
      checkPassword is now returning an error code instead of a bool. when we
      actually consider checkPassword an error we'll now raise this error
      instead of the generic access denied errors. when the user canceled
      the query we'll continue to raise the more topical error from smb (e.g.
      "access denied")
      
      primarily these errors appear when kiod/kpasswdserver is defunct
      or not installed meaning query functionality will not work at all.
      
      Test Plan:
      # broken kiod
      
      - remove dbus service file
      - kill
      - dolphin smb://host
      - no auth query
      - error about broken dialog
      
      # cancel
      
      - repair kiod
      - dolphin smb://host
      - auth query
      - cancel
      - auth query
      - cancel
      - error about access denied (because refused to authenticate)
      
      Reviewers: #frameworks, dfaure
      
      Reviewed By: dfaure
      
      Subscribers: ngraham, kde-frameworks-devel, kfm-devel
      
      Tags: #dolphin, #frameworks
      
      Differential Revision: https://phabricator.kde.org/D24387
      5a870554
  3. 17 Jan, 2015 1 commit
  4. 28 Feb, 2014 1 commit
  5. 16 Feb, 2014 1 commit
  6. 11 Dec, 2013 1 commit
  7. 18 Mar, 2010 2 commits
    • Oswald Buddenhagen's avatar
      kde3support-- · f2de3d5f
      Oswald Buddenhagen authored
      this code is actually pretty useless (and consequently untested), as
      using it would require reviving the smbmounter konq-plugin (go to
      extragear/base/konq-plugins/smbmounter and run "svn merge -c -389803 .",
      then port to qt4 ...).
      
      CCBUG: 201617
      
      svn path=/trunk/KDE/kdebase/runtime/; revision=1104792
      f2de3d5f
    • Oswald Buddenhagen's avatar
      don't use a shell · 2b3ea962
      Oswald Buddenhagen authored
      the reason given ("have the path to smbmnt") makes no sense. it probably
      means that the author's shell sourced some startup script which would
      add /sbin into the PATH, but this a) won't work for most users and b)
      would have been a bug in smbmount anyway.
      
      svn path=/trunk/KDE/kdebase/runtime/; revision=1104779
      2b3ea962
  8. 28 Dec, 2009 1 commit
    • John Layt's avatar
      krazy fixes · 048e4a5a
      John Layt authored
      svn path=/trunk/KDE/kdebase/runtime/; revision=1067073
      048e4a5a
  9. 03 Aug, 2007 1 commit
  10. 16 Jun, 2007 1 commit
  11. 26 Mar, 2007 1 commit
    • Oswald Buddenhagen's avatar
      KProcess -> K3Process · 6c1ceb6d
      Oswald Buddenhagen authored
      KShellProcess -> K3ShellProcess
      KProcIO -> K3ProcIO
      KProcessController -> K3ProcessController
      
      not deprecating, as we don't have a replacement yet.
      not moving yet, as kdelibs still has heavy dependencies on it.
      
      agreed upon with dfaure.
      
      
      svn path=/trunk/KDE/kdebase/runtime/; revision=646732
      6c1ceb6d
  12. 01 Jul, 2006 1 commit
  13. 19 May, 2006 1 commit
  14. 11 May, 2006 1 commit
  15. 10 Apr, 2006 1 commit
  16. 20 Feb, 2006 1 commit
  17. 06 Feb, 2006 1 commit
  18. 05 Oct, 2005 1 commit
  19. 24 Sep, 2005 1 commit
  20. 28 Jul, 2005 1 commit
  21. 04 Jul, 2005 1 commit
  22. 24 Jun, 2004 1 commit
  23. 11 Apr, 2003 1 commit