Martin Tobias Holmedahl Sandsmark authored Oct 29, 2021 and Martin Tobias Holmedahl Sandsmark committed Nov 23, 2021

Similar to multimedia/ffmpegthumbs!11

This avoids having to update the list every time a new image format is
added to e. g. kimageformats (now it's missing heic etc.).

This way thumbnailer plugins don't need to be loaded using the KServiceTypeTrader
mechanism, but can use embedded json metadata.
KServiceTypeTrader is planned to go away in KF6.

This also simplifies the code once the KServiceTypeTrader code path is dropped, because
we can then load the metadata from the binary path and don't have to use
KServiceTypeTrader to get the desktop file for the given binary.

By using KPluginInfo to convert the metadata to json on the fly, we don't need to
do another query for the file on disk and then a reparsing of the desktop file.
This is ~2.5 times slower and even requires a few more lines to implement.

Counterpart of frameworks/kio!630

Task: https://phabricator.kde.org/T12179

With the standard header, styles etc as provided by kdoctools.

7d11a093 accidentally moved the
memory pointer increase out of the '+'-handling branch, which would
either result in bad number being read or the pointer getting behind
the end and resulting in garbage memory processing, potentially ending
in a crash.

Also changing to using dedicated own variable "sign" instead of reusing
function-global variable "j" with meaningless name.
global

Fixed-in: 21.08.3
BUG: 443983

Error reporting was changed in KCoreDirlister, to match the original behaviour
we need to explicitly disable auto error handling.

This fixes a crash while searching in Dolphin, kio_filenamesearch intrenally
uses a dirlister, and a nested event loop, if there is an error while listing
some dir it tries to report it using a job ui delegate, but the parent job
could well be dead by that time, which causes a crash:
"QWidget: Cannot create a QWidget without QApplication"

Note that this crash only happens if KDE_FORK_SLAVES is _not_ set.

BUG: 438187
FIXED-IN: 21.08.3
(cherry picked from commit 5dff395e)

this was previously wildly duplicated. createUDSEntry has been refitted
to support both calls from stat() and from listDir().

createUDSEntry now takes an incoming SFTPAttributesPtr (taking ownership
of the attribute) and fills the udsentry accordingly. for listDir
efficiency's sake we pass in the entry by reference as well as the
details such that we can avoid needless work where possible.
the function now returns a conclusive Result, callers may naturally
ignore it.

listDir no longer aborts on readlink errors. indeed any errors coming
out of udsentry creation shouldn't impact listing. just because a file
fails to list doesn't mean the entire listing should stop 🤷

listDir now ignores readlink problems. there's no reason why failing to
read links would abort the dir listing

it's poor form and gets in the way of readability

divide openConnection in the wrapper function openConnect and the
internal openConnectionWithoutCloseOnError. the former calls the latter
and automatically calls closeConnection if an error was returned. the
internal function no longer calls closeConnection at all

also cleaned up style oddities while stepping through the code (fewer
line breaking, fewer useless var assignment, no longer `else if` after
break/return)

it's way too large, way too complicated, way to repetitively concerned
with cleanup. fingerprinting is a fairly isolated bit, so split it into
a helper function. this also helps reduce the in-scope variables and in
turn makes it less likely that we forget to clean up something

also use scopeguards for cleanup in the new function. also to reduce
repetition and ensure cleanup

no sense having that both in the open and the get functions. move it to
a helper function.

now also uses std::array instead of raw char[] to look more modern

even that is very generous. it's 0.8.3 has been out for more than 3
years

the resuming logic is super duplicating and was also somewhat
divergent between the duplicates.

to resolve this there's now a new unified couple of helpers that
specifically deal with establishing context on a file transfer. this
actually maybe should eventually move to KIO proper. it seems to me that
every implementation needs to do more or less the same thing except for
the IO specifics

- shouldResume is called relatively early on and establishes the
context. the context is entirely dependent on the resume configuration
at hand. if KIO::Resume is set we resume in-place, otherwise we may have
an intermediate .part file. if neither is applicable then we straight up
need to overwrite. this effectively hides the details of the
intermediate url switch. the actual transfer logic in smb_dir gets a
context back with the destination configured to where it should write to
(not necessarily where the file will end up at in the end)
- concludeResumeHasError is call...

"flags & SSH_FILEXFER_ATTR_CREATETIME" check was missing in listDir

CCBUG: 375305

In libmtp 1.1.19, an empty string is returned instead of NULL for devices without a deviceName, which breaks accessing those devices with kio-mtp

In libmtp 1.1.19, an empty string is returned instead of NULL for devices without a deviceName, which breaks accessing those devices with kio-mtp

it should annotate this source, not the source within the source

previously this behaved wildly inconsistently with the other copy
functions and other workers. copying on the same protocol doesn't really
change anything, if anything it  is even more expected to not disturb
the mtime, certainly when we were provided with a modify time, which all
this is contingent on anyway

applying the mtime was duplicated across multiple functions when indeed
it is largely the same code with only the actual setting being slightly
variable. use a template function with callback instead to share the
sharable bits.

also, since smbc_utime is used in two functions move that to its own
helper built on top to remove even the callback duplication

they can change behavior quite a bit

...to be more consistent with the rest of the code

previously we had a global timeout in smb_browse but that was eventually
removed to not break SMBC discovery, which is also used for listing
directories. this left WSD without any timeout system when no WSD hosts
are on the network because the internal timeout tracking would only
start after the first response.

instead implement the actually specified timeout mechanics of WSD.

- /Probe may only be Matched within MATCH_TIMEOUT (m_probeMatchTimer =
global timeout tracker now)
- /Resolve may only be Matched within MATCH_TIMEOUT (encapsulated inside
new WSDResolver)
- PBSD may only be answered within HTTP_TIMEOUT (couldn't find a
specified timeout so I'm guessing one would ordinarily use a default
http timeout, since we only do a single cheap query I'm using a more
opinionate timeout though)

MATCH_TIMEOUT is derived form the DPWS spec rather than the underlying
ws-discovery because it has more lenient timing and is generally a bit
more assertive with requirements.

BUG: 436574

Ahmad Samir authored Sep 10, 2021 and Ben Cooksley committed Sep 21, 2021

To get those definitions, copy them from kio/src/core/kioglobal_p.h

GIT_SILENT

In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"

In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"

In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"