GitLab

The missing error() caused an assertion failure in
SlaveBasePrivate::verifyState("get()") - it is not allowed to
return from get() without calling error() or finished().

In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"

Not sure whether this will ever be used, though - do any
current systems apart from Solaris have SGML man pages?

Konqueror with the WebEnginePart sees the KIO error and displays a
generic error, ignoring the formatted HTML explanation.  KHTML
puts up a deceptive blank error box.  Only WebKit ignores the error
and displays the HTML as intended.  Call finished() so that the HTML
will be displayed whatever viewing part is in use.

Partial revert of commit d5f2beb2, as noted in
konqueror!83

In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"

The options are very undiscoverable in dolphin and having
an option for this seems quite overkill to me. If people really want to
have this kind of configurability they should be using an image
viewer instead of looking at the thumbnails.

It also causes issues from a dependency kind of view.
Task: https://phabricator.kde.org/T14695

In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"

The moc process already rebuilds the plugin when the JSON file changes, consequently the additional parameter is not needed.

Task: https://phabricator.kde.org/T14649

Error reporting was changed in KCoreDirlister, to match the original behaviour
we need to explicitly disable auto error handling.

This fixes a crash while searching in Dolphin, kio_filenamesearch intrenally
uses a dirlister, and a nested event loop, if there is an error while listing
some dir it tries to report it using a job ui delegate, but the parent job
could well be dead by that time, which causes a crash:
"QWidget: Cannot create a QWidget without QApplication"

Note that this crash only happens if KDE_FORK_SLAVES is _not_ set.

BUG: 438187

In practice, this means that settings:// URLS get opened with dolphin,
which is bad UX. Let's do this with system settings instead.

see 'auto QString(Builder) considered VERY HARMFUL' thread on kde-devel
https://markmail.org/message/mbrp5ypyhcfk7zjn

What happens is that the type of str ends up being QStringBuilder
instead of QString. The QStringBuilder is destroyed after the semicolon,
and all access to "str" produces undefined behavior.

Never use auto for QString concatenation!

BUG: 439877

In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"

GIT_SILENT

GIT_SILENT

Use the metadata devicePixelRatio to scale up dimensions of thumbnails generated.
Sets the devicePixelRatio on the output QPixmap according to the thumbnail generated.
Make the Text Thumbnail creator devicePixelRatio aware.
Follows xdg thumbnail specs 0.9 https://specifications.freedesktop.org/thumbnail-spec/thumbnail-spec-latest.html

BUG: 342053
FIXED-IN: 21.08

GIT_SILENT

GIT_SILENT

GIT_SILENT

Consistency with other cmakelists.txt files, KDE settings might influence
other things, so better be set early

GIT_SILENT

Needs KArchive >= 5.82, which matches min requirements

GIT_SILENT

GIT_SILENT

GIT_SILENT

GIT_SILENT

GIT_SILENT

GIT_SILENT

GIT_SILENT

GIT_SILENT

GIT_SILENT

GIT_SILENT

GIT_SILENT

GIT_SILENT