1. 01 Sep, 2021 1 commit
  2. 10 Jul, 2021 1 commit
  3. 15 Jun, 2021 2 commits
  4. 08 Jun, 2021 2 commits
  5. 07 Jun, 2021 1 commit
  6. 05 Jun, 2021 2 commits
  7. 29 May, 2021 1 commit
  8. 28 May, 2021 1 commit
  9. 12 May, 2021 1 commit
  10. 05 May, 2021 1 commit
  11. 03 May, 2021 1 commit
  12. 30 Apr, 2021 1 commit
  13. 24 Apr, 2021 1 commit
  14. 12 Apr, 2021 1 commit
  15. 11 Apr, 2021 1 commit
  16. 13 Mar, 2021 1 commit
  17. 26 Feb, 2021 1 commit
    • Stefan Brüns's avatar
      [Thumbnail] Skip potentially slow thumb generation for symlinks · b44af142
      Stefan Brüns authored
      The calling code in kio already checks if the directory itself is on a
      slow (e.g. network) filesystem, but following symlinks inside it subverts
      this check.
      
      Skipping thumbnails has the effect of prefering plain files instead of
      symlinks. This still gives a good approximation of the directory contents
      (and even a better one if the symlinks point to files in the same
      directory, as duplicates are avoided).
      b44af142
  18. 03 Dec, 2020 1 commit
  19. 20 Nov, 2020 1 commit
  20. 07 Nov, 2020 1 commit
  21. 29 Oct, 2020 2 commits
  22. 25 Oct, 2020 2 commits
  23. 24 Oct, 2020 1 commit
  24. 18 Oct, 2020 1 commit
    • Stefan Brüns's avatar
      Avoid pointless probing for nonexisting thumbnail images · ef76b22b
      Stefan Brüns authored
      QImage::load(<path>) tries to find a fallback image if the file does
      not exist, by appending extensions of all supported file formats, as
      QImageReader defaults to format autodetection.
      
      Check if the file exists, and only then try to load it.
      ef76b22b
  25. 22 Sep, 2020 1 commit
    • Stefan Brüns's avatar
      Remove Mimetype overlay icon blending · 3440a169
      Stefan Brüns authored
      Cached thumbnails should not depend on varying properties of the caller,
      like iconAlpha, iconSize and theme of the overlay icon.
      
      Also, the current mime type icons are hardly visible and unrecognizable
      with dolphins default opacity of ~25%.
      
      BUG: 425789
      3440a169
  26. 30 Aug, 2020 1 commit
    • Volker Krause's avatar
      Fix the build · 54066eb3
      Volker Krause authored
      Despite the name, fileUrl is already a QByteArray encoded URL here.
      54066eb3
  27. 29 Aug, 2020 9 commits
    • Stefan Brüns's avatar
      Add mandatory metadata to thumbnail · 1eeaf1a6
      Stefan Brüns authored
      According to the spec, at least Thumb::URI and Thumb::MTime are required.
      
      KIO::PreviewJob discards any thumbnails without these and recreates
      the thumbnails.
      1eeaf1a6
    • Stefan Brüns's avatar
      Do not check dir.hasNext() twice · bf486c01
      Stefan Brüns authored
      If the inner loop is not run, skipped will be 0 and the loop is left
      anyway.
      bf486c01
    • Stefan Brüns's avatar
      Remove last redundant loop condition · 184bc28a
      Stefan Brüns authored
      As `skipped` is always reset to 0, the condition is always true.
      
      Change the skipValidItems calculation to make it more obvious it
      calculates the remainder, and is always a positive value.
      
      Declare skipped inside the loop, as it is only used inside the loop.
      
      No functional changes.
      184bc28a
    • Stefan Brüns's avatar
      Simplify rounding of skip count · 5905a6ec
      Stefan Brüns authored
      The branches can be simplified to an arithmetic operation.
      5905a6ec
    • Stefan Brüns's avatar
      Simplify loop conditions · c900324b
      Stefan Brüns authored
      Replace the `yPos <= maxYPos)` check in the inner loop with an more
      explicit check whenever a thumnail is drawn.
      
      `(yPos <= maxYPos) && !validThumbnails)` is redundant, as yPos is only
      incremented whenever validThumbnails is incremented. Move the
      validThumbnails check into the loop.
      c900324b
    • Stefan Brüns's avatar
      Only create file URI when required · 78a8c7d3
      Stefan Brüns authored and David Faure's avatar David Faure committed
      The URI is only required when a thumbnail is created or looked up.
      78a8c7d3
    • Stefan Brüns's avatar
      Avoid massive overdrawing with sequenceIndex != 0 · 900db615
      Stefan Brüns authored and David Faure's avatar David Faure committed
      Commit 8ed64be9 ("Enlarge image in folder preview when there's only
      one image") made createSubThumbnail part of drawSubThumbnail. As a side
      effect, when skipValidItems is > 0, the thumbnail is not only fetched
      but also drawn in the top left position.
      
      Split fetching and drawing again.
      
      This is visible in the file dialogs (dolphin only uses sequenceIndex==0),
      when hovering a directory with the mouse.
      900db615
    • Stefan Brüns's avatar
      Try fallback to large thumbnail if small one is not available · f1c90489
      Stefan Brüns authored and David Faure's avatar David Faure committed
      Scaling down a large thumbnail is considerably faster than creating the
      thumbnail from scratch.
      f1c90489
    • Stefan Brüns's avatar
      Delay check for mimetype and plugin until required · 0b9a5372
      Stefan Brüns authored and David Faure's avatar David Faure committed
      If a thumbnail already exists, the mimetype of the original file and
      available plugins do not matter.
      
      Saves accessing the original file, and allows thumbnails for file types
      which are not natively supported by KIO.
      0b9a5372