1. 03 Dec, 2020 1 commit
  2. 20 Nov, 2020 1 commit
  3. 07 Nov, 2020 1 commit
  4. 29 Oct, 2020 2 commits
  5. 25 Oct, 2020 2 commits
  6. 24 Oct, 2020 1 commit
  7. 18 Oct, 2020 1 commit
    • Stefan Brüns's avatar
      Avoid pointless probing for nonexisting thumbnail images · ef76b22b
      Stefan Brüns authored
      QImage::load(<path>) tries to find a fallback image if the file does
      not exist, by appending extensions of all supported file formats, as
      QImageReader defaults to format autodetection.
      
      Check if the file exists, and only then try to load it.
      ef76b22b
  8. 22 Sep, 2020 1 commit
    • Stefan Brüns's avatar
      Remove Mimetype overlay icon blending · 3440a169
      Stefan Brüns authored
      Cached thumbnails should not depend on varying properties of the caller,
      like iconAlpha, iconSize and theme of the overlay icon.
      
      Also, the current mime type icons are hardly visible and unrecognizable
      with dolphins default opacity of ~25%.
      
      BUG: 425789
      3440a169
  9. 30 Aug, 2020 1 commit
    • Volker Krause's avatar
      Fix the build · 54066eb3
      Volker Krause authored
      Despite the name, fileUrl is already a QByteArray encoded URL here.
      54066eb3
  10. 29 Aug, 2020 9 commits
    • Stefan Brüns's avatar
      Add mandatory metadata to thumbnail · 1eeaf1a6
      Stefan Brüns authored
      According to the spec, at least Thumb::URI and Thumb::MTime are required.
      
      KIO::PreviewJob discards any thumbnails without these and recreates
      the thumbnails.
      1eeaf1a6
    • Stefan Brüns's avatar
      Do not check dir.hasNext() twice · bf486c01
      Stefan Brüns authored
      If the inner loop is not run, skipped will be 0 and the loop is left
      anyway.
      bf486c01
    • Stefan Brüns's avatar
      Remove last redundant loop condition · 184bc28a
      Stefan Brüns authored
      As `skipped` is always reset to 0, the condition is always true.
      
      Change the skipValidItems calculation to make it more obvious it
      calculates the remainder, and is always a positive value.
      
      Declare skipped inside the loop, as it is only used inside the loop.
      
      No functional changes.
      184bc28a
    • Stefan Brüns's avatar
      Simplify rounding of skip count · 5905a6ec
      Stefan Brüns authored
      The branches can be simplified to an arithmetic operation.
      5905a6ec
    • Stefan Brüns's avatar
      Simplify loop conditions · c900324b
      Stefan Brüns authored
      Replace the `yPos <= maxYPos)` check in the inner loop with an more
      explicit check whenever a thumnail is drawn.
      
      `(yPos <= maxYPos) && !validThumbnails)` is redundant, as yPos is only
      incremented whenever validThumbnails is incremented. Move the
      validThumbnails check into the loop.
      c900324b
    • Stefan Brüns's avatar
      Only create file URI when required · 78a8c7d3
      Stefan Brüns authored
      The URI is only required when a thumbnail is created or looked up.
      78a8c7d3
    • Stefan Brüns's avatar
      Avoid massive overdrawing with sequenceIndex != 0 · 900db615
      Stefan Brüns authored
      Commit 8ed64be9 ("Enlarge image in folder preview when there's only
      one image") made createSubThumbnail part of drawSubThumbnail. As a side
      effect, when skipValidItems is > 0, the thumbnail is not only fetched
      but also drawn in the top left position.
      
      Split fetching and drawing again.
      
      This is visible in the file dialogs (dolphin only uses sequenceIndex==0),
      when hovering a directory with the mouse.
      900db615
    • Stefan Brüns's avatar
      Try fallback to large thumbnail if small one is not available · f1c90489
      Stefan Brüns authored
      Scaling down a large thumbnail is considerably faster than creating the
      thumbnail from scratch.
      f1c90489
    • Stefan Brüns's avatar
      Delay check for mimetype and plugin until required · 0b9a5372
      Stefan Brüns authored
      If a thumbnail already exists, the mimetype of the original file and
      available plugins do not matter.
      
      Saves accessing the original file, and allows thumbnails for file types
      which are not natively supported by KIO.
      0b9a5372
  11. 28 Aug, 2020 2 commits
    • Stefan Brüns's avatar
      Remove bogus duplicate check · 3fda2087
      Stefan Brüns authored
      The second condition can never be fulfilled on the first iteration
      (QDirIterator does not return a path twice), but only after the
      QDirIterator has been reset in the outer loop.
      
      As validThumbnails is incremented when hadFirstThumbnail gets assigned,
      the outer loop will never be run after the initial assignement of
      hadFirstThumbnail, so the condition can never be true.
      3fda2087
    • Stefan Brüns's avatar
      Do not try to create a thumbnail for an empty file · 4d74b884
      Stefan Brüns authored
      Instead of doing a lookup for a thumbnail which is guaranteed to to not
      exist, and then trying to find a suitable plugin, which exists neither,
      just skip the file.
      4d74b884
  12. 25 Aug, 2020 1 commit
  13. 22 Aug, 2020 2 commits
  14. 21 Aug, 2020 1 commit
  15. 29 May, 2020 1 commit
  16. 02 Jan, 2020 1 commit
  17. 19 Nov, 2019 1 commit
  18. 01 Jul, 2019 1 commit
  19. 05 Mar, 2019 1 commit
  20. 10 Oct, 2018 1 commit
  21. 08 Oct, 2018 1 commit
  22. 18 Sep, 2018 1 commit
    • Kai Uwe Broulik's avatar
      [Thumbnailer] Use enabled plugins passed in as metadata · ed68ea15
      Kai Uwe Broulik authored
      The thumbnailer lives in a separate application, so it will read the enabled plugins from a different configuration than the
      calling application (e.g. dolphinrc).
      This leads to folder thumbnails following the default settings instead of user-configured settings, causing disabled plugins
      to be used and blacklisted thumbnails never being used even if enabled by the user.
      
      BUG: 388303
      
      Differential Revision: https://phabricator.kde.org/D15097
      ed68ea15
  23. 26 Aug, 2018 1 commit
  24. 15 May, 2018 1 commit
    • Peter Mühlenpfordt's avatar
      Scale up folder icon before creating preview overlays · bafc90d7
      Peter Mühlenpfordt authored
      Summary:
      If a custom folder icon is smaller than the requested preview size
      `KIO::PreviewJob` returns a pixmap of only that size. E.g. `dolphin`
      scales this up to its current thumbnail size which results in ugly
      overlay icons for very small folder icons. If the folder icon is
      scaled up before creating the overlay icons the overall preview
      looks much better.
      
      CCBUG: 315983
      
      Test Plan:
      # Set a small custom icon (e.g. 32 px) for a folder containing images
      # Start dolphin with `Preview` enabled in the parent folder
      # Zoom thumbnails to e.g. 128 pixels overlay
      # The overlayed preview icons should not be blurry
      
      | Before:    | After:     |
      | {F5837958} | {F5837960} |
      
      Reviewers: #frameworks, rkflx
      
      Reviewed By: rkflx
      
      Subscribers: ngraham, rkflx
      
      Differential Revision: https://phabricator.kde.org/D12734
      bafc90d7
  25. 18 Dec, 2017 1 commit
  26. 16 Nov, 2017 1 commit
  27. 21 Oct, 2017 2 commits