GitLab

There's a special *.ppsx and *.sldx file type

Insert a nullptr into the cache when a plugin fails to load, e.g.
because some symbols are unresolvable. Also log a warning stating the
error cause.

The cache is implicitly cleared by the kioslave idle logic.

Building kio-sftp fails on Ubuntu 18.04:
kio-extras/sftp/kio_sftp.cpp:1280:1: error: non-void function does not return a value in all control paths [-Werror,-Wreturn-type]
}
^
1 error generated.
make[2]: *** [sftp/CMakeFiles/kio_sftp.dir/kio_sftp.cpp.o] Error 1
make[1]: *** [sftp/CMakeFiles/kio_sftp.dir/all] Error 2
make[1]: *** Waiting for unfinished jobs....
make: *** [all] Error 2

SFTPInternal::openConnection() version for libssh < 0.8.3 is missing a
return at the end of the function. Add it.

- We no longer attempt to auto-anonymous as that can increase the failed
logon count for no good reason. As a silly side effect it'd also mean
that servers that actually support anonymous login would always be used
anonymously and the user then has no visible way to actually login short
of editing the URI to smb://username@host
- Domain field is gone now. Folded into username as per UPN foramt
- Anonymous field is also gone now. Also folded into username

This largely roots in the fact that windows logons are a range of
formats, so upstream rightly suggested that they all should go through
the same username field (which is also how this is done on windows).
This also streamlines the auth dialog a lot and removes a bit of excess
code.
https://docs.microsoft.com/en-us/windows/win32/secauthn/user-name-formats

Anonymous/guest login actually is also implemented thusly by either
using empty or invalid usernames (kinda depends on how the server,
specifically samba, is configured anyway).

To communicate these options to the user we use a new feature in KF5
that allows us to set a fairly visible hint on the username field to
describe in greater detail what the username may be.

I've tested this against my windows server 2019 setup and all the login
options described work as expected.

It's about to be deprecated.

None of the KPty functionality is required, so just use QProcess as
already done on Windows.

In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"

In case the cached thumbnail loaded successfully the isNull check is
unreachable due to the early `return true`.

The QSaveFile is only needed if there is thumbnail creator for the
format of the current file.

Minimum Qt version set in CMakeLists.txt is 5.11, so the checks are
redundant.

Audible AAX is a ISOBMFF file like MPEG4 audio.
AIFC is a newer variant of the AIFF codec, but uses the same ID3v2
metadata format.

The previous code setted values to temporary objects in stack.

'### 000' is a placeholder. The actual success code is '### 200' (used in
fish.pl).

fish.pl implementation sends "Positive preliminary reply" after the files
number and the C++ (local, receiving) side expects it.

The pages in a comic book are just a set of images, ordered by filename.
When there is a resource fork (as created by MacOS when using the
built-in ZIP support), the metadata files (which have the same suffix as
the corresponding image files) are sorted first.

For e.g a two page book the files `book_01.png`, `book_02.png` are sorted
after and hidden by `__MACOSX/._book_01.png`, `__MACOSX._book_02.png`.

QImage::load(<path>) tries to find a fallback image if the file does
not exist, by appending extensions of all supported file formats, as
QImageReader defaults to format autodetection.

Check if the file exists, and only then try to load it.

it was only ever a safety net and shouldn't practically be necessary.
with the dust around the new discovery system having settled we should
probably deal with potentially getting stuck on discovery instead of
aborting the discovery through the safety net and hiding the defect.

also, technically speaking discovery could take longer than N seconds
since both WSD and NMB are broadcast systems without local caching
daemon like avahi, so they can be affected by network latency much more
than DNSSD

File and share listing can take a very long time as they are IO bound on
the remote, so if one is listing a large directory on a HDD it may well
take minutes. Equally sending huge listings over the wire may take a
while if not enough throughput is available. So don't cap the execution
of these discoveries at all.

Server discovery retains the timeout, mostly because I don't want to
remove it in 20.08 though an argument could be made that we should trust
in the reliability of the discovery stacks to not get stuck on random
unforseen misbehavior of servers.

BUG: 427644
FIXED-IN: 20.08.3

In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"

In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"

Instead of parsing the type from "wrestool --list" output, supply the
type during the list and extraction invocation.

Simplify the regex, only capture the name and remove name from the
optional group.

As only GROUP_ICONs are listed, the first match is the correct one.

The application icon is stored in the first GROUP_ICON resource, see
https://docs.microsoft.com/en-us/windows/win32/menurc/about-icons#icon-display

Remove the iconNumber parameter, as the functions are always called with
the default value of 0.

In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"

In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"

In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"

In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"