Commit db7f8d0c authored by Diego Soenens's avatar Diego Soenens Committed by David Faure

Thumbnails should be a clean image representation, remove frame.

Thumbnails should be a clean image representation without "hard-coded" borders or design elements.

Many thumbnail generators currently return ThumbCreator::DrawFrame in their flags()
function which causes a 90's style 1px "3d" border to be added to the thumbnail image.
This causes problems when consumers of these thumbnails (like Dolphin) expect a
clean image representation of the file, without hard-coded design elements.
It also looks really bad when any resizing/scaling happens or when the thumbnail
is shown on a tooltip. Especially now that the UI has been modernized with Breeze.

REVIEW: 129921
parent 558a2dde
......@@ -310,5 +310,5 @@ int ComicCreator::startProcess(const QString& processPath, const QStringList& ar
ThumbCreator::Flags ComicCreator::flags() const
{
return DrawFrame;
return None;
}
......@@ -127,7 +127,7 @@ bool DjVuCreator::create(const QString &path, int width, int height, QImage &img
ThumbCreator::Flags DjVuCreator::flags() const
{
return static_cast<Flags>(DrawFrame);
return static_cast<Flags>(None);
}
......@@ -102,7 +102,7 @@ void HTMLCreator::slotFinished(bool ok)
ThumbCreator::Flags HTMLCreator::flags() const
{
return DrawFrame;
return None;
}
#include "htmlcreator.moc"
......
......@@ -104,5 +104,5 @@ bool KritaCreator::create(const QString &path, int width, int height, QImage &im
ThumbCreator::Flags KritaCreator::flags() const
{
return DrawFrame;
return None;
}
......@@ -163,6 +163,6 @@ bool TextCreator::create(const QString &path, int width, int height, QImage &img
ThumbCreator::Flags TextCreator::flags() const
{
return (Flags)(DrawFrame | BlendIcon);
return (Flags)BlendIcon;
}
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment