1. 11 Aug, 2020 1 commit
  2. 13 Jul, 2020 1 commit
  3. 05 Jul, 2020 1 commit
  4. 29 Jun, 2020 1 commit
  5. 29 Nov, 2019 1 commit
  6. 03 Oct, 2019 1 commit
    • David Barchiesi's avatar
      Allow stat()ing new-account link. · 8e2b3d3d
      David Barchiesi authored
      Summary:
      When stat()ing 'gdrive:/new-account', the slave was actually stat()ing the UDS entry for the account root path.
      This patch fixes the issue by not having GDriveUrl::isAccountRoot() return true for 'gdrive:/new-account' and also moves the New Account label logic into GDriveUrl.
      
      Reviewers: elvisangelaccio
      
      Reviewed By: elvisangelaccio
      
      Subscribers: #kio_gdrive
      
      Tags: #kio_gdrive
      
      Differential Revision: https://phabricator.kde.org/D24366
      8e2b3d3d
  7. 24 Sep, 2019 1 commit
    • David Barchiesi's avatar
      Add Shared Drives to GDriveUrl slave. · 41bb6b02
      David Barchiesi authored
      Summary:
      Adds listing of account Shared Drives through the url 'gdrive:/account@gmail.com/Shared Drives/'.
      
      Supported operations:
      - Create via 'Create New' -> 'Folder...'
      - Delete (if empty)
      - Rename
      
      Discussion in {T10630}
      
      Reviewers: elvisangelaccio
      
      Reviewed By: elvisangelaccio
      
      Subscribers: #kio_gdrive
      
      Tags: #kio_gdrive
      
      Differential Revision: https://phabricator.kde.org/D23804
      41bb6b02
  8. 15 Sep, 2019 1 commit
  9. 09 Sep, 2019 1 commit
  10. 26 Jul, 2019 1 commit
  11. 21 Jul, 2019 1 commit
    • David Barchiesi's avatar
      Avoid calling finished() after error()" · 5fe660ee
      David Barchiesi authored
      Summary:
      By not checking the return of runJob(), the slave might call finished() after already having called error() in handleError().
      See T7995 for futher information.
      
      Reviewers: elvisangelaccio, dvratil
      
      Reviewed By: elvisangelaccio
      
      Subscribers: dvratil, #kio_gdrive
      
      Tags: #kio_gdrive
      
      Differential Revision: https://phabricator.kde.org/D22462
      5fe660ee
  12. 03 Jul, 2019 1 commit
  13. 25 May, 2019 1 commit
  14. 19 May, 2019 1 commit
    • David Barchiesi's avatar
      Adapt to LibKGAPI setFields() changes. · 01ec4d87
      David Barchiesi authored
      Summary:
      In the next release, LibKGAPI has changed the way it sets fields in `FileFetchJob` and in general allows setting response fields for all `Job`s (see [[ https://phabricator.kde.org/D20886 | D20886 Add fields standard query parameter to Job and use it in FileFetchJob ]]).
      
      This patch adjusts KIO Gdrive to this change and limits the response in `AboutFetchJob`s.
      
      Reviewers: dvratil, elvisangelaccio
      
      Subscribers: #libkgapi, #kio_gdrive
      
      Tags: #kio_gdrive, #libkgapi
      
      Differential Revision: https://phabricator.kde.org/D20888
      01ec4d87
  15. 08 Apr, 2019 1 commit
  16. 23 Sep, 2018 1 commit
    • Fabian Vogt's avatar
      Send file contents in chunks · 1b710a46
      Fabian Vogt authored
      Summary:
      KIO can only send a maximum of 0xFFFFFF bytes of data.
      TransferJob has an additional limit of 14 MiB.
      
      BUG: 375765
      
      Test Plan:
      Downloaded a 132MiB file, no more "slave died unexpectedly".
      Size and md5sum match.
      
      Reviewers: elvisangelaccio, dfaure
      
      Subscribers: dfaure, ngraham
      
      Differential Revision: https://phabricator.kde.org/D15448
      1b710a46
  17. 29 Jun, 2018 1 commit
    • Elvis Angelaccio's avatar
      Use percent encoding when creating urls for UDS entries · 98eac300
      Elvis Angelaccio authored
      Summary:
      Otherwise it won't be possible to open gdrive files that contain special
      characters (such as `#`) in their path.
      
      This is not handled by libkgapi, which just copies whatever is in the
      JSON from Google, and Google does not seem to encode the filenames
      either. So we encode the filenames at the kio-gdrive level, where we
      actually play with QUrls.
      
      We do so by actually creating a QUrl (which takes care of
      percent-encoding in `setPath()`) and then we convert it to a string.
      
      While at it, use faster concatenation rather than arg parsing.
      
      BUG: 395590
      FIXED-IN: 1.2.4
      
      Test Plan:
      Try to open a file with `#` in the name.
      Check whether files with normal names still work.
      
      Reviewers: dvratil, dfaure
      
      Differential Revision: https://phabricator.kde.org/D13691
      98eac300
  18. 29 Mar, 2018 1 commit
    • Martijn Schmidt's avatar
      KIOGDrive::copy - resolve the destGDriveUrl's new parent into a destDirId... · f89c3f7f
      Martijn Schmidt authored
      KIOGDrive::copy - resolve the destGDriveUrl's new parent into a destDirId before passing it to FileCopyJob in src/kio_gdrive.cpp
      
      Summary:
      KIOGDrive::copy doesn't resolve the destGDriveUrl's new parent into a destDirId before passing it to FileCopyJob, which means it'll be sending an illegal request body to the Google Drive API - for example:
      
      ```{
         \"editable\":false,
         \"kind\":\"drive#file\",
         \"lastViewedByMeDate\":   \"2018-01-10T19:38:11   Z\",
         \"modifiedDate\":   \"2018-01-10T19:38:11   Z\",
         \"parents\":[
            {
               \"id\":\"testfoldertwo\"
            }
         ],
         \"title\":\"yetanothertestfile.txt\"
      }```
      
      The "id" field should contain a valid parent ID rather than an originalFilename, and this patch resolves the right parent ID in one of two ways:
      
      - If the target folder of the copy command is the root of the GDrive, resolve the rootFolderId from the destAccountId.
      - If the target folder of the copy command is any other directory on the GDrive, resolve the fileId of the destGDriveUrl's parentPath.
      
      The resulting parent ID is passed to FileCopyJob as the parent of the new cloned file, which then successfully processes the API call.
      
      BUG: 376735
      FIXED-IN: 1.2.2
      
      Test Plan:
      This bug is triggered whenever `KIOGDrive::copy` is called:
      
      1. Try to copy a file from a random folder on the GDrive to the root folder of the GDrive.
      
      2. Try to copy a file from a random folder on the GDrive to another random non-root folder on the GDrive.
      
      3. Try to copy a file from a random folder on the GDrive to the same random folder on the GDrive, which creates another fileId with an identical originalFilename within that same folder.
      
      In all three cases, the FileCopyJob should succeed rather than throwing an error because the destination doesn't exist.
      
      Copying a file from a non-GDrive source into a destination on the GDrive uses `KIOGDrive::put` + `KIOGDrive::putCreate`, and copying a file from a GDrive source into a non-GDrive destination uses `KIOGDrive::get`, which is why the bug isn't triggered in these scenarios.
      
      Reviewers: #kio_gdrive, elvisangelaccio, dvratil
      
      Reviewed By: #kio_gdrive, elvisangelaccio
      
      Subscribers: elvisangelaccio, #kio_gdrive, martijnschmidt
      
      Tags: #kio_gdrive
      
      Differential Revision: https://phabricator.kde.org/D9806
      f89c3f7f
  19. 27 Sep, 2017 1 commit
  20. 11 Mar, 2017 1 commit
  21. 18 Feb, 2017 2 commits
  22. 17 Feb, 2017 5 commits
  23. 16 Feb, 2017 2 commits
  24. 13 Feb, 2017 1 commit
  25. 30 Jan, 2017 1 commit
  26. 11 Jan, 2017 1 commit
  27. 07 Nov, 2016 1 commit
    • Elvis Angelaccio's avatar
      Ignore the deprecated 'hidden' label · 0c53b5ca
      Elvis Angelaccio authored
      The 'hidden' label is randomly set by some clients and users are not
      aware of this. This can result in files visible from the web UI but
      hidden by kio-gdrive.
      
      This label is also deprecated, so we can just ignore it and always show all
      files.
      
      BUG: 371954
      FIXED-IN: 1.0.4
      0c53b5ca
  28. 12 Oct, 2016 1 commit
  29. 04 Oct, 2016 6 commits