Commit 8f50baf2 authored by Stefano Crocco's avatar Stefano Crocco
Browse files

Update comments

parent be7a411f
......@@ -220,8 +220,8 @@ void KKonqGeneralOptions::load()
};
std::copy_if(allParts.constBegin(), allParts.constEnd(), std::back_inserter(partOfferList), filter);
//Remove duplicate entries
//TODO port away from query: are the following 3 lines really needed? Is it correct that the vector returned by partsForMimeType contains the same part several times?
//We need to remove duplicates caused by having parts with both plugin metadata and .desktop files being returned twice by KParts::PartLoader::partsForMimeType
//TODO: remove this when this doesn't happen anymore (KF6?)
std::sort(partOfferList.begin(), partOfferList.end(), [](const KPluginMetaData &md1, const KPluginMetaData &md2){return md1.pluginId() == md2.pluginId();});
auto unique = std::unique(partOfferList.begin(), partOfferList.end(), [](const KPluginMetaData &md1, const KPluginMetaData &md2){return md1.pluginId() == md2.pluginId();});
partOfferList.erase(unique, partOfferList.end());
......
......@@ -4394,9 +4394,6 @@ void KonqMainWindow::slotPopupMenu(const QPoint &global, const KFileItemList &it
!menuBar()->isVisible() ? m_paShowMenuBar : nullptr,
fullScreenMode() ? m_ptaFullScreen : nullptr
);
// qRegisterMetaType<KService::Ptr>("KService::Ptr");
// connect(konqyMenuClient, SIGNAL(openEmbedded(KService::Ptr)),
// this, SLOT(slotOpenEmbedded(KService::Ptr)), Qt::QueuedConnection);
connect(konqyMenuClient, &PopupMenuGUIClient::openEmbedded, this, &KonqMainWindow::slotOpenEmbedded, Qt::QueuedConnection);
// Those actions go into the PopupMenuGUIClient, since that's the one defining them.
......
Supports Markdown
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment