Commit 9119e90c authored by Stefano Crocco's avatar Stefano Crocco Committed by Pino Toscano
Browse files

Fix CMakeLists.txt to compile WebEnginePartHtmlEmbedder on Qt before Qt-5.12

When compiling Konqueror on versions of Qt before 5.12, the
WebEnginePartHtmlEmbedder class is needed to embed local contents in pages
generated by...

Summary:
...WebEnginePartKIOHandler (for example, for the man protocol). The
corresponding source file is added to the the list of source files only if the
Qt version is less than 5.12. However, an extra command in CMakeFiles.txt caused
the file not to be added and the compilation to fail.

Test Plan:
compile Konqueror with Qt older than 5.12.0: the compilation now
completes successfully.

Reviewers: dfaure

Reviewed By: dfaure

Differential Revision: https://phabricator.kde.org/D22736

(cherry picked from commit f9bc950d)
parent 32ad395d
......@@ -31,7 +31,7 @@ if(NOT Qt5WebEngineWidgets_VERSION VERSION_LESS "5.12.0")
add_definitions(-DUSE_QWEBENGINE_URL_SCHEME)
add_definitions(-DDOWNLOADITEM_KNOWS_PAGE)
else()
list(APPEND kwebenginepartlib_LIB_SRCS, webengineparthtmlembedder.cpp)
list(APPEND kwebenginepartlib_LIB_SRCS webengineparthtmlembedder.cpp)
endif()
qt5_wrap_ui(kwebenginepartlib_LIB_SRCS
......
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment