Commit a6a9e9e3 authored by Jonathan Marten's avatar Jonathan Marten
Browse files

Akregator feed plugin: Do not assert for a valid but relative URL

For example, "konqueror --part khtml foo".  This passes QUrl("foo"),
a valid but relative URL with no scheme, to KonqFeedIcon::feedFound().
This then asserts when calling KProtocolInfo::protocolClass() for the
blank scheme.

Note that the test case only works with KHTML, and will not reach this
point (an assert will have already happened within KIO) unless the fix
in frameworks/kio!264 is

parent 57093334
......@@ -100,7 +100,7 @@ bool KonqFeedIcon::feedFound()
// Ensure that it is safe to use the URL, before doing anything else with it
const QUrl partUrl(m_part->url());
if (!partUrl.isValid()) {
if (!partUrl.isValid() || partUrl.scheme().isEmpty()) {
return false;
// Since attempting to determine feed info for about:blank crashes khtml,
Supports Markdown
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment