Commit c214f6d9 authored by Nicolas Fella's avatar Nicolas Fella Committed by Stefano Crocco
Browse files

Make some implicit dependencies explicit

They are being pulled in by KParts, but we better not rely on that
parent 61aeca91
......@@ -18,7 +18,7 @@ set(akregatorkonqfeedicon_PART_SRCS konqfeedicon.cpp feeddetector.cpp pluginutil
add_library(akregatorkonqfeedicon MODULE ${akregatorkonqfeedicon_PART_SRCS} ${akregatorplugin_DEBUG_SRCS})
target_compile_definitions(akregatorkonqfeedicon PRIVATE TRANSLATION_DOMAIN="akregator_konqplugin")
target_link_libraries(akregatorkonqfeedicon KF5::Parts KF5::IconThemes)
target_link_libraries(akregatorkonqfeedicon KF5::I18n KF5::Parts KF5::IconThemes)
install(TARGETS akregatorkonqfeedicon DESTINATION ${KDE_INSTALL_PLUGINDIR} )
......
......@@ -11,7 +11,7 @@ add_library(autorefresh MODULE ${autorefresh_PART_SRCS})
target_link_libraries(autorefresh KF5::Parts KF5::IconThemes )
target_link_libraries(autorefresh KF5::I18n KF5::Parts KF5::IconThemes )
install(TARGETS autorefresh DESTINATION ${KDE_INSTALL_PLUGINDIR} )
......
......@@ -6,7 +6,7 @@ set(babelfishplugin_PART_SRCS plugin_babelfish.cpp )
add_library(babelfishplugin MODULE ${babelfishplugin_PART_SRCS})
target_link_libraries(babelfishplugin KF5::Parts)
target_link_libraries(babelfishplugin KF5::I18n KF5::Parts)
install(TARGETS babelfishplugin DESTINATION ${KDE_INSTALL_PLUGINDIR} )
......
......@@ -4,7 +4,7 @@ set(dirfilterplugin_PART_SRCS dirfilterplugin.cpp )
add_library(dirfilterplugin MODULE ${dirfilterplugin_PART_SRCS})
target_link_libraries(dirfilterplugin KF5::Parts)
target_link_libraries(dirfilterplugin KF5::I18n KF5::Parts)
install(TARGETS dirfilterplugin DESTINATION ${KDE_INSTALL_PLUGINDIR} )
......
......@@ -42,7 +42,7 @@ set(fsviewpart_PART_SRCS fsview_part.cpp ${libfsview_SRCS})
add_library(fsviewpart MODULE ${fsviewpart_PART_SRCS})
kcoreaddons_desktop_to_json(fsviewpart ${CMAKE_CURRENT_BINARY_DIR}/fsview_part.desktop)
target_link_libraries(fsviewpart KF5::Parts KF5::IconThemes)
target_link_libraries(fsviewpart KF5::I18n KF5::Parts KF5::IconThemes)
install(TARGETS fsviewpart DESTINATION ${KDE_INSTALL_PLUGINDIR}/kf5/parts)
......
......@@ -15,7 +15,7 @@ add_library(khtmlsettingsplugin MODULE ${khtmlsettingsplugin_PART_SRCS})
kcoreaddons_desktop_to_json(khtmlsettingsplugin ${CMAKE_CURRENT_BINARY_DIR}/khtmlsettingsplugin.desktop)
target_link_libraries(khtmlsettingsplugin KF5::Parts)
target_link_libraries(khtmlsettingsplugin KF5::I18n KF5::Parts)
install(TARGETS khtmlsettingsplugin DESTINATION ${KDE_INSTALL_PLUGINDIR} )
......
......@@ -6,7 +6,7 @@ ecm_qt_declare_logging_category(kimgallery_PART_SRCS HEADER imgallery_debug.h ID
add_library(kimgallery MODULE ${kimgallery_PART_SRCS})
target_link_libraries(kimgallery KF5::Parts)
target_link_libraries(kimgallery KF5::I18n KF5::WidgetsAddons KF5::KIOWidgets KF5::Parts)
install(TARGETS kimgallery DESTINATION ${KDE_INSTALL_PLUGINDIR} )
......
......@@ -19,7 +19,7 @@ ecm_qt_declare_logging_category(searchbarplugin_PART_SRCS HEADER searchbar_debug
add_library(searchbarplugin MODULE ${searchbarplugin_PART_SRCS})
target_link_libraries(searchbarplugin KF5::Parts Qt5::Script)
target_link_libraries(searchbarplugin KF5::I18n KF5::TextWidgets KF5::Parts Qt5::Script)
install(TARGETS searchbarplugin DESTINATION ${KDE_INSTALL_PLUGINDIR} )
......
......@@ -6,7 +6,7 @@ set(konq_shellcmdplugin_PART_SRCS kshellcmdexecutor.cpp kshellcmddialog.cpp kshe
add_library(konq_shellcmdplugin MODULE ${konq_shellcmdplugin_PART_SRCS})
target_link_libraries(konq_shellcmdplugin KF5::Parts KF5::Su)
target_link_libraries(konq_shellcmdplugin KF5::I18n KF5::Parts KF5::Su)
install(TARGETS konq_shellcmdplugin DESTINATION ${KDE_INSTALL_PLUGINDIR} )
......
......@@ -4,7 +4,7 @@ set(khtmlttsplugin_PART_SRCS khtmltts.cpp )
add_library(khtmlttsplugin MODULE ${khtmlttsplugin_PART_SRCS})
target_link_libraries(khtmlttsplugin KF5::Parts Qt5::TextToSpeech)
target_link_libraries(khtmlttsplugin KF5::I18n KF5::Parts Qt5::TextToSpeech)
install(TARGETS khtmlttsplugin DESTINATION ${KDE_INSTALL_PLUGINDIR} )
......
......@@ -4,7 +4,7 @@ set(uachangerplugin_PART_SRCS uachangerplugin.cpp )
add_library(uachangerplugin MODULE ${uachangerplugin_PART_SRCS})
target_link_libraries(uachangerplugin KF5::Parts )
target_link_libraries(uachangerplugin KF5::I18n KF5::Parts )
install(TARGETS uachangerplugin DESTINATION ${KDE_INSTALL_PLUGINDIR} )
......
......@@ -6,7 +6,7 @@ find_package(KF5 REQUIRED COMPONENTS CoreAddons Parts)
set(webarchiverplugin_PART_SRCS plugin_webarchiver.cpp)
add_library(webarchiverplugin MODULE ${webarchiverplugin_PART_SRCS})
target_include_directories(webarchiverplugin PRIVATE ${CMAKE_CURRENT_BINARY_DIR}/logging)
target_link_libraries(webarchiverplugin webarchiverdebug KF5::Parts Qt5::Core Qt5::Widgets)
target_link_libraries(webarchiverplugin webarchiverdebug KF5::I18n KF5::Parts Qt5::Core Qt5::Widgets)
########### install files ###############
......
......@@ -29,7 +29,7 @@ ki18n_wrap_ui(kcm_konqhtml_PART_SRCS
add_library(kcm_konqhtml MODULE ${kcm_konqhtml_PART_SRCS})
target_link_libraries(kcm_konqhtml KF5::Parts KF5::ItemViews)
target_link_libraries(kcm_konqhtml KF5::I18n KF5::ConfigWidgets KF5::TextWidgets KF5::Parts KF5::ItemViews)
install(TARGETS kcm_konqhtml DESTINATION ${KDE_INSTALL_PLUGINDIR})
......
......@@ -43,7 +43,7 @@ set(konq_sidebar_PART_SRCS
add_library(konq_sidebar MODULE ${konq_sidebar_PART_SRCS} ${sidebar_DEBUG_SRCS})
kcoreaddons_desktop_to_json(konq_sidebar ${CMAKE_CURRENT_BINARY_DIR}/konq_sidebartng.desktop)
target_link_libraries(konq_sidebar KF5::Parts KF5::Konq konqsidebarplugin KF5::KCMUtils KF5::IconThemes)
target_link_libraries(konq_sidebar KF5::I18n KF5::Parts KF5::Konq konqsidebarplugin KF5::KCMUtils KF5::IconThemes)
install(TARGETS konq_sidebar DESTINATION ${KDE_INSTALL_PLUGINDIR}/kf5/parts)
......
......@@ -6,7 +6,7 @@ set(konqsidebar_bookmarks_SRCS
add_library(konqsidebar_bookmarks MODULE ${konqsidebar_bookmarks_SRCS})
target_link_libraries(konqsidebar_bookmarks KF5::Parts KF5::Konq konqsidebarplugin )
target_link_libraries(konqsidebar_bookmarks KF5::I18n KF5::Parts KF5::Konq konqsidebarplugin )
install(TARGETS konqsidebar_bookmarks DESTINATION ${KDE_INSTALL_PLUGINDIR})
......
......@@ -6,7 +6,7 @@ set(konqsidebar_places_SRCS
add_library(konqsidebar_places MODULE ${konqsidebar_places_SRCS})
target_link_libraries(konqsidebar_places KF5::Parts konqsidebarplugin)
target_link_libraries(konqsidebar_places KF5::I18n KF5::Parts konqsidebarplugin)
install(TARGETS konqsidebar_places DESTINATION ${KDE_INSTALL_PLUGINDIR})
......
......@@ -6,7 +6,7 @@ set(konqsidebar_tree_SRCS
add_library(konqsidebar_tree MODULE ${konqsidebar_tree_SRCS})
target_link_libraries(konqsidebar_tree KF5::Parts KF5::Konq konqsidebarplugin )
target_link_libraries(konqsidebar_tree KF5::I18n KF5::Konq konqsidebarplugin )
install(TARGETS konqsidebar_tree DESTINATION ${KDE_INSTALL_PLUGINDIR})
......
......@@ -26,6 +26,7 @@ ecm_qt_declare_logging_category(konquerorprivate_SRCS HEADER konqdebug.h IDENTIF
add_library(konquerorprivate SHARED ${konquerorprivate_SRCS})
target_link_libraries(konquerorprivate
KF5::I18n
KF5::IconThemes
KF5::Konq
KF5::Parts
......@@ -109,6 +110,7 @@ target_link_libraries(kdeinit_konqueror
KF5::DBusAddons
KF5::Crash
KF5::WindowSystem
KF5::SonnetUi
)
if (X11_FOUND)
......
......@@ -63,11 +63,12 @@ target_link_libraries(kwebenginepartlib
KF5::Notifications
PRIVATE
KF5::Konq
KF5::I18n
Qt5::PrintSupport
KF5::SonnetCore
KF5::IconThemes #for KIconLoader used by WebEnginePartErrorSchemeHandler
KF5::WindowSystem # for KUserTimestamp
KF5::SonnetCore
KF5::SonnetUi
)
target_include_directories(kwebenginepartlib PUBLIC
......
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment