Commit c29af3eb authored by Peter Penz's avatar Peter Penz
Browse files

don't pass a custom viewport URL to the context menu anymore, as this cannot...

don't pass a custom viewport URL to the context menu anymore, as this cannot work together with the menu actions

svn path=/trunk/KDE/kdebase/apps/; revision=678175
parent 9c5c510e
......@@ -231,8 +231,15 @@ void ColumnWidget::contextMenuEvent(QContextMenuEvent* event)
const QPoint pos = m_view->viewport()->mapFromGlobal(event->globalPos());
m_view->m_controller->triggerContextMenuRequest(pos, m_url);
const QModelIndex index = indexAt(event->pos());
const KUrl& navigatorUrl = m_view->m_controller->url();
if (index.isValid() || (m_url == navigatorUrl)) {
// Only open a context menu above an item or if the mouse is above
// the active column.
const QPoint pos = m_view->viewport()->mapFromGlobal(event->globalPos());
void ColumnWidget::activate()
......@@ -34,10 +34,10 @@ DolphinController::~DolphinController()
void DolphinController::triggerContextMenuRequest(const QPoint& pos, const KUrl& url)
void DolphinController::triggerContextMenuRequest(const QPoint& pos)
emit activated();
emit requestContextMenu(pos, url);
emit requestContextMenu(pos);
void DolphinController::triggerActivation()
......@@ -60,7 +60,7 @@ public:
inline void setUrl(const KUrl& url);
inline const KUrl& url() const;
void triggerContextMenuRequest(const QPoint& pos, const KUrl& url);
void triggerContextMenuRequest(const QPoint& pos);
void triggerActivation();
......@@ -116,10 +116,8 @@ signals:
* context menu should be opened. It is recommended
* to get the corresponding model index from
* this position.
* @param url URL of the viewport, if there is no valid model
* index on the given position.
void requestContextMenu(const QPoint& pos, const KUrl& url);
void requestContextMenu(const QPoint& pos);
* Is emitted if the view has been activated by e. g. a mouse click.
......@@ -150,7 +150,7 @@ QStyleOptionViewItem DolphinDetailsView::viewOptions() const
void DolphinDetailsView::contextMenuEvent(QContextMenuEvent* event)
m_controller->triggerContextMenuRequest(event->pos(), m_controller->url());
void DolphinDetailsView::mousePressEvent(QMouseEvent* event)
......@@ -103,7 +103,7 @@ QStyleOptionViewItem DolphinIconsView::viewOptions() const
void DolphinIconsView::contextMenuEvent(QContextMenuEvent* event)
m_controller->triggerContextMenuRequest(event->pos(), m_controller->url());
void DolphinIconsView::mousePressEvent(QMouseEvent* event)
......@@ -89,8 +89,8 @@ DolphinView::DolphinView(QWidget* parent,
m_controller = new DolphinController(this);
connect(m_controller, SIGNAL(requestContextMenu(const QPoint&, const KUrl&)),
this, SLOT(openContextMenu(const QPoint&, const KUrl&)));
connect(m_controller, SIGNAL(requestContextMenu(const QPoint&)),
this, SLOT(openContextMenu(const QPoint&)));
connect(m_controller, SIGNAL(urlsDropped(const KUrl::List&, const QModelIndex&, QWidget*)),
this, SLOT(dropUrls(const KUrl::List&, const QModelIndex&, QWidget*)));
connect(m_controller, SIGNAL(sortingChanged(DolphinView::Sorting)),
......@@ -698,7 +698,7 @@ void DolphinView::changeSelection(const KFileItemList& selection)
| QItemSelectionModel::Current);
void DolphinView::openContextMenu(const QPoint& pos, const KUrl& url)
void DolphinView::openContextMenu(const QPoint& pos)
KFileItem* item = 0;
......@@ -707,7 +707,7 @@ void DolphinView::openContextMenu(const QPoint& pos, const KUrl& url)
item = fileItem(index);
emit requestContextMenu(item, url);
emit requestContextMenu(item, url());
void DolphinView::dropUrls(const KUrl::List& urls,
......@@ -413,12 +413,9 @@ private slots:
* Opens the context menu on position \a pos. The position
* is used to check whether the context menu is related to an
* item or to the viewport. If the context menu should be
* opened on the viewport, the URL \a url should be taken
* as viewport URL (the viewport URL can be different from
* DolphinView::url() for e. g. the column view).
* item or to the viewport.
void openContextMenu(const QPoint& pos, const KUrl& url);
void openContextMenu(const QPoint& pos);
* Drops the URLs \a urls to the index \a index. \a source
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment