1. 05 Apr, 2021 3 commits
  2. 03 Apr, 2021 2 commits
    • Jonathan Marten's avatar
      kfmclient: Fix recursive invocation and handle association correctly · 779c1f43
      Jonathan Marten authored and Stefano Crocco's avatar Stefano Crocco committed
      If 'kcmshell5 componentchooser' is used to set the default web
      browser to Konqueror, then as well as changing the text/html file
      association it sets [General]BrowserApplication=kfmclient_html.desktop
      in kdeglobals.  ClientApp::createNewWindow() looks to see whether this
      setting is present, but actually ignores its value and simply opens
      the original URL via an OpenUrlJob.  The file type association then
      calls kfmclient again and loops endlessly.
      
      Split up the complicated test to handle the two cases appropriately:
      either launching the external browser (setting starting with a '!')
      using a CommandLauncherJob, or starting the service (setting not
      starting with '!') using an ApplicationLauncherJob.  Check in both
      of these code paths that kfmclient would not be called recursively.
      If this happens, or if the setting is absent or there are problems
      launching the job, then fall through to opening the URL in Konqueror
      directly.  This means that it cannot loop and the URL is opened in
      the intended application.
      779c1f43
    • Anthony Fieroni's avatar
      Proper history navigation · e00322a6
      Anthony Fieroni authored and Stefano Crocco's avatar Stefano Crocco committed
      
      Signed-off-by: Anthony Fieroni's avatarAnthony Fieroni <bvbfan@abv.bg>
      e00322a6
  3. 01 Apr, 2021 1 commit
  4. 31 Mar, 2021 1 commit
  5. 28 Mar, 2021 1 commit
  6. 21 Mar, 2021 1 commit
  7. 17 Mar, 2021 1 commit
  8. 13 Mar, 2021 1 commit
  9. 08 Mar, 2021 1 commit
  10. 14 Feb, 2021 1 commit
  11. 03 Feb, 2021 1 commit
  12. 31 Jan, 2021 1 commit
  13. 29 Jan, 2021 1 commit
  14. 24 Jan, 2021 2 commits
  15. 21 Jan, 2021 1 commit
  16. 18 Jan, 2021 1 commit
  17. 14 Jan, 2021 1 commit
  18. 11 Jan, 2021 1 commit
  19. 10 Jan, 2021 1 commit
  20. 08 Jan, 2021 1 commit
  21. 06 Jan, 2021 1 commit
  22. 05 Jan, 2021 1 commit
  23. 04 Jan, 2021 1 commit
  24. 31 Dec, 2020 1 commit
    • Stefano Crocco's avatar
      Revert "Fix focus when opening page in a new tab" · 1f014821
      Stefano Crocco authored
      This reverts commit a69162a9.
      
      It seems that this causes issues with links to non-html files. For
      example:
      - open a web page
      - from that page, middle click on a link to another web page to open it
        in another tab
      - from the second page, middle click on a link to a PDF file
      
      What should happen is that the PDF file is displayed in a third tab
      while the first two tabs remain unchanged. Instead, with original commit
      the PDF file is displayed not only in the third tab but also in the
      first one.
      1f014821
  25. 28 Dec, 2020 1 commit
    • Stefano Crocco's avatar
      Fix focus when opening page in a new tab · a69162a9
      Stefano Crocco authored
      When opening a page in a new tab by middle-clicking a link, focus wasn't
      moved to the new page but remained in the location bar. This happens
      because the createNewWindow signal is emitted by
      NewWindowPage::acceptNavigationRequest using an empty URL rather than
      the true URL. To fix this, the real URL is passed to the createNewWindow signal.
      a69162a9
  26. 26 Dec, 2020 3 commits
  27. 18 Dec, 2020 1 commit
    • Jonathan Marten's avatar
      Show an explicit error for an unknown URL scheme · 53e5e406
      Jonathan Marten authored
      Because the error page shows an explanation, provided by
      KIO::rawErrorDetail(), which gives useful troubleshooting
      information for this specific problem.  Previously the error
      given would have been "Improperly Formatted URL" which is
      misleading.
      53e5e406
  28. 17 Dec, 2020 1 commit
    • Jonathan Marten's avatar
      Akregator feed plugin: Do not assert for a valid but relative URL · a6a9e9e3
      Jonathan Marten authored
      For example, "konqueror --part khtml foo".  This passes QUrl("foo"),
      a valid but relative URL with no scheme, to KonqFeedIcon::feedFound().
      This then asserts when calling KProtocolInfo::protocolClass() for the
      blank scheme.
      
      Note that the test case only works with KHTML, and will not reach this
      point (an assert will have already happened within KIO) unless the fix
      in frameworks/kio!264 is
      implemented.
      
      CCBUG:393496
      a6a9e9e3
  29. 13 Dec, 2020 1 commit
  30. 11 Dec, 2020 1 commit
  31. 10 Dec, 2020 1 commit
  32. 09 Dec, 2020 2 commits
  33. 05 Dec, 2020 1 commit