1. 06 Jan, 2019 10 commits
  2. 01 Jan, 2019 1 commit
  3. 24 Dec, 2018 2 commits
  4. 20 Dec, 2018 1 commit
  5. 26 Nov, 2018 1 commit
  6. 20 Nov, 2018 2 commits
  7. 18 Nov, 2018 2 commits
  8. 08 Nov, 2018 1 commit
  9. 07 Nov, 2018 1 commit
  10. 04 Nov, 2018 1 commit
    • Stefano Crocco's avatar
      Ask the user what to do in case of a SSL certificate error · 011fdc2e
      Stefano Crocco authored
      Summary:
      When a certificate error happens, the user is asked whether to ignore
      the error or not.
      
      Things become more complicated if the page is loaded by
      WebEnginePart::load. In this case, SSL errors will have already been
      detected by the KParts framework, so asking the user again would be
      meaningless. To avoid this, before calling WebEngineView::load,
      WebEnginePart::load stores the URL in an instance variable of
      WebEnginePage: WebEnginePage::certificateError checks whether this
      variable is the same as the URL which produced the error and, in this
      case, always returns true.
      
      Unfortunately, it's impossible to integrate all of this with the KDE
      certificates management system, as QWebEngine doesn't provide any information
      about them except an error code and description.
      
      Test Plan:
      find a page with an invalid SSL certificate, enter it in the address
      bar then check that one (and only one) dialog is shown and that answering to
      ignore the error makes the page load.
      
      Attempt to load the web page from a link and check that the behaviour is the
      same.
      
      Reviewers: dfaure
      
      Reviewed By: dfaure
      
      Differential Revision: https://phabricator.kde.org/D16355
      011fdc2e
  11. 01 Nov, 2018 1 commit
  12. 22 Oct, 2018 1 commit
    • Stefano Crocco's avatar
      Fix handling of cookies without a domain · fb461808
      Stefano Crocco authored
      Summary:
      QWebEngineCookieStore and KCookieServer handle cookies with empty domain
      differently:
      - QWebEngineCookieStore gives them a domain which doesn't start with a
      dot
      - KCookieServer leave them with no domain and stores the host information
      in the host field.
      
      Previously, this difference wasn't taken into account. Now, when adding
      a cookie from KCookieServer to QWebEngineCookieStore, the cookie's domain
      is set according to the host information and, when adding a cookie to
      KCookieServer from QWebEngineCookieStore, the domain is removed if not
      starting with a dot.
      
      Test Plan: run autotests
      
      Reviewers: dfaure
      
      Reviewed By: dfaure
      
      Differential Revision: https://phabricator.kde.org/D16139
      fb461808
  13. 19 Oct, 2018 1 commit
  14. 18 Oct, 2018 1 commit
    • Jonathan Marten's avatar
      File Size View: Fix KProtocolInfoFactory assert · 3df5a1be
      Jonathan Marten authored
      konqueror: ASSERT: "!protocol.isEmpty()" in file kio/src/core/kprotocolinfofactory.cpp, line 72
      
       #4  0x00007ffff621f480 in KProtocolInfoFactory::findProtocol (this=<optimized out>, protocol=...)
           at kio/src/core/kprotocolinfofactory.cpp:72
       #5  0x00007ffff621a15f in KProtocolInfo::protocolClass (_protocol=...)
           at kio/src/core/kprotocolinfo.cpp:331
       #6  0x00007ffff62112bd in KUrlAuthorized::authorizeUrlAction (action=..., baseURL=..., destURL=...)
           at kio/src/core/kurlauthorized.cpp:40
       #7  0x00007fffcd0ae72d in FSView::setPath (this=this@entry=0x5555569a79d0, p=...)
           at konqueror/plugins/fsview/fsview.cpp:146
       #8  0x00007fffcd096bae in FSViewPart::openUrl (this=0x555556a39e80, url=...)
           at konqueror/plugins/fsview/fsview_part.cpp:325
      3df5a1be
  15. 10 Oct, 2018 1 commit
  16. 05 Oct, 2018 1 commit
  17. 04 Oct, 2018 1 commit
    • Stefano Crocco's avatar
      Fix removing cookies from KCookieServer · b8fc3d62
      Stefano Crocco authored
      Summary:
      The call to KCookieServer::deleteCookies always failed because the
      cookie name was passed as a QByteArray and not as a QString. This is now
      corrected and tests are provided to check the correct behaviour.
      
      The error check for a DBus error in the call to
      KCookieServer::deleteCookies also was incorrect, since it called
      QDBusAbstractInterface::lastError(), which isn't useful for non-blocking
      calls. A correct check using QDBusPendingCall is now used.
      
      Test Plan: run the autotests
      
      Reviewers: dfaure
      
      Reviewed By: dfaure
      
      Differential Revision: https://phabricator.kde.org/D15753
      b8fc3d62
  18. 23 Sep, 2018 2 commits
    • Pino Toscano's avatar
      use QIcon::fromTheme() instead of QIcon() · b6ccfae3
      Pino Toscano authored
      ... when there is a simple icon name, not a full path
      b6ccfae3
    • Stefano Crocco's avatar
      Add basic tests for WebEnginePartCookieJar · fac5b780
      Stefano Crocco authored
      Summary:
      Currently, this only tests that cookies are correctly added to
      KCookieServer in response to the QWebEngineCookieStore::cookieAdded
      signal.
      
      There are some limitations:
      - ideally, to test the correct behaviour of WebEnginePartCookieJar::cookieAdded,
        one should call QWebEngineCookieStore::setCookie, so that
        QWebEngineCookieStore processes the cookie and emits the cookieAdded
        signal as it would in the real application. Unfortunately, in the
        tests, calling setCookie doesn't trigger the cookieAdded signal.
        Because of this, I manually emitted the signal. However, this bypasses
        any processing by the cookie store (such as calling
        QNetworkCookie::normalize, which I do manually);
      - I don't know how to start a separate instance of the Cookie Server
        service, so the tests use the default one. This has two drawbacks:
        it's impossible to start with a clean state and the tests pollute the
        user's configuration (this second issue could be avoided by adding
        clean up code to each test)
      
      Reviewers: dfaure
      
      Reviewed By: dfaure
      
      Differential Revision: https://phabricator.kde.org/D15381
      fac5b780
  19. 19 Sep, 2018 1 commit
  20. 18 Sep, 2018 4 commits
  21. 01 Sep, 2018 1 commit
  22. 27 Aug, 2018 1 commit
    • Stefano Crocco's avatar
      Remove KIcon from plugins · 081e9928
      Stefano Crocco authored
      Summary:
      Remove KIcon from plugins (it wasn't used in Konqueror itself). This is another step towards removing use of KDELibs4Support
      
      Plugins which currently aren't build haven't been changed
      
      Reviewers: dfaure
      
      Reviewed By: dfaure
      
      Differential Revision: https://phabricator.kde.org/D15077
      081e9928
  23. 25 Aug, 2018 1 commit
    • Stefano Crocco's avatar
      Remove call to hasSubUrl · ef847eb9
      Stefano Crocco authored
      Summary:
      When removing sub url handling from the webarchiver plugin, a call to
      hasSubUrl remained, preventing the code from compiling. This fixes the issue
      
      Test Plan: ensure that Konqueror compiles
      
      Reviewers: dfaure
      
      Reviewed By: dfaure
      
      Differential Revision: https://phabricator.kde.org/D15060
      ef847eb9
  24. 24 Aug, 2018 1 commit