1. 08 May, 2020 1 commit
  2. 27 Apr, 2020 1 commit
  3. 23 Apr, 2020 1 commit
    • Stefano Crocco's avatar
      Fix crash due to changes in KBookmarkMenu · d6e3f653
      Stefano Crocco authored
      Summary:
      Since version 5.69, KBookmarkMenu doesn't automatically create an action
      collection. This causes Konqueror to crash when going on a submenu in
      the Bookmarks menu. To avoid it, manually create the action collection.
      
      Also, avoid calling the version of KBookmarkMenu construction which
      takes a KActionCollection, as it's deprecated.
      
      Test Plan:
      Open the bookmarks menu and hover with the mouse on a submenu. Check
      that it crashes. Do the same after this change and check it doesn't crash
      anymore.
      
      Reviewers: dfaure, nicolasfella
      
      Reviewed By: dfaure, nicolasfella
      
      Subscribers: arojas, poboiko
      
      Differential Revision: https://phabricator.kde.org/D28789
      
      (cherry picked from commit b61086cf)
      d6e3f653
  4. 20 Apr, 2020 1 commit
  5. 16 Apr, 2020 1 commit
  6. 13 Apr, 2020 1 commit
    • Stefano Crocco's avatar
      Fix crash due to changes in KBookmarkMenu · ad4d6f4a
      Stefano Crocco authored
      Summary:
      Since version 5.69, KBookmarkMenu doesn't automatically create an action
      collection. This causes Konqueror to crash when going on a submenu in
      the Bookmarks menu. To avoid it, manually create the action collection.
      
      Also, avoid calling the version of KBookmarkMenu construction which
      takes a KActionCollection, as it's deprecated.
      
      Test Plan:
      Open the bookmarks menu and hover with the mouse on a submenu. Check
      that it crashes. Do the same after this change and check it doesn't crash
      anymore.
      
      Reviewers: dfaure, nicolasfella
      
      Reviewed By: nicolasfella
      
      Subscribers: poboiko
      
      Differential Revision: https://phabricator.kde.org/D28789
      
      (cherry picked from commit 078f357b)
      ad4d6f4a
  7. 06 Apr, 2020 2 commits
  8. 04 Apr, 2020 1 commit
  9. 17 Mar, 2020 1 commit
  10. 13 Mar, 2020 1 commit
  11. 11 Mar, 2020 1 commit
  12. 21 Feb, 2020 1 commit
  13. 16 Feb, 2020 1 commit
  14. 09 Feb, 2020 1 commit
  15. 04 Feb, 2020 1 commit
  16. 28 Jan, 2020 1 commit
  17. 19 Jan, 2020 1 commit
  18. 13 Jan, 2020 1 commit
  19. 09 Jan, 2020 1 commit
  20. 06 Jan, 2020 2 commits
  21. 05 Jan, 2020 1 commit
  22. 04 Jan, 2020 3 commits
    • Stefano Crocco's avatar
      Avoid automatically displaying local URLs in WebEnginePart · b165ee39
      Stefano Crocco authored
      Summary:
      When a file URL is passed to WebEnginePage::acceptNavigationRequest,
      don't allow QtWebEngine to decide what to do with it (open it in the
      QWebEnginePage or not) but let Konqueror make the choice according to
      the user's configuration.
      
      Whitout this change, clicking on the "Home" link in the introduction
      page (konq:konqueror) opens the page in WebEnginePart, while it should
      open it in DolphinPart (or whichever part the user has chosen to display
      directories).
      
      Test Plan:
      from the introduction page (konq:konqueror) click the "Home Folder"
      link and check that the home folder is opened in DolphinPart and not
      WebEnginePart. Create an HTML file with a link to a local image file, open the
      HTML file in Konqueror and click on the link to the image. check that the image
      is opened in the part chosen to handle images.
      
      Reviewers: dfaure
      
      Reviewed By: dfaure
      
      Differential Revision: https://phabricator.kde.org/D26417
      b165ee39
    • Albert Astals Cid's avatar
      about folder is gone · aba7679d
      Albert Astals Cid authored
      CCMAIL: stefano.crocco@alice.it, faure@kde.org
      aba7679d
    • Stefano Crocco's avatar
      Give focus to location bar on startup · c9fe1ffd
      Stefano Crocco authored
      Summary:
      Ensure that at startup the focus is given to the location bar when
      opening the default page.
      
      Test Plan:
      Launch Konqueror (with the default setting for the start URL ) and
      check that the location bar has focus.
      
      Reviewers: dfaure
      
      Reviewed By: dfaure
      
      Differential Revision: https://phabricator.kde.org/D26414
      c9fe1ffd
  23. 03 Jan, 2020 1 commit
    • Stefano Crocco's avatar
      Port the About page to QtWebEngine · 64f94b6b
      Stefano Crocco authored
      Summary:
      Replace the old About Page based on KHtml with one based on QtWebEngine.
      
      This has been obtained creating a new QWebEngineUrlSchemeHandler for the `konq``
      scheme which will display the contents of the about page. The old `about` scheme
      can't be used because it's used internally by QtWebEngine.
      
      There are two problems. The first is that if the user's konquerorrc file
      contains old default value for the StartURL entry, that value will be used
      instead of the new one, which will result in an error message. I don't know how
      to force the use of the new default instead of the old one.
      
      The second problem is that clicking on the "Home Folder" link in the launch page
      will open the link in the WebEngine part instead of Dolphin part.
      
      Test Plan:
      after removing the StartURL entry from the user's konquerorrc file,
      launch Konqueror and check that the intro page is displayed. Click on one of the
      links in the page (Introduction, Tips, Specifications) and check that the
      correct page is displayed.
      
      Reviewers: dfaure
      
      Reviewed By: dfaure
      
      Differential Revision: https://phabricator.kde.org/D26253
      64f94b6b
  24. 01 Jan, 2020 2 commits
  25. 27 Dec, 2019 1 commit
  26. 25 Dec, 2019 2 commits
  27. 18 Dec, 2019 1 commit
  28. 14 Dec, 2019 1 commit
    • Nicolas Fella's avatar
      [konqpixmapprovider] Don't inherit from KPixmapProvider · 5877982c
      Nicolas Fella authored
      Summary: It only defines the pixmapFor method, which we implement ourselves anyway. It is the last non-obsolete usage of KPixmapProvider, so removing it here will allow us to get rid of it entirely eventually.
      
      Test Plan: builds. Basic browsing works, no obvious icons missing
      
      Reviewers: #konqueror, dfaure
      
      Reviewed By: #konqueror, dfaure
      
      Maniphest Tasks: T12310
      
      Differential Revision: https://phabricator.kde.org/D25818
      5877982c
  29. 01 Dec, 2019 1 commit
    • Stefano Crocco's avatar
      Restore ability to close tab by clicking on close button · 919076fa
      Stefano Crocco authored
      Summary:
      After making KTabBar and KTabWidget part of Konqueror, clicking on the close
      button of a tab didn't make the tab close any longer. This fixes it
      
      Test Plan:
      Open several tabs in Konqueror, then click on their close button and
      check that they close. Check that when only one tab remains, the tab bar is
      hidden
      
      Reviewers: dfaure
      
      Reviewed By: dfaure
      
      Differential Revision: https://phabricator.kde.org/D25662
      919076fa
  30. 28 Nov, 2019 1 commit
  31. 25 Nov, 2019 1 commit
  32. 24 Nov, 2019 1 commit
    • Ahmad Samir's avatar
      More ktabwidget fixes · 0a0b1a77
      Ahmad Samir authored
      Summary:
      Remove closeRequest() declarations as it is replaced with tabCloseRequest().
      
      Use qCWarning() instead of kWarning().
      
      Reviewers: dfaure, stefanocrocco
      
      Reviewed By: dfaure
      
      Maniphest Tasks: T11559
      
      Differential Revision: https://phabricator.kde.org/D24789
      0a0b1a77
  33. 23 Nov, 2019 2 commits