Skip to content
GitLab
Projects Groups Topics Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
  • Konqueror Konqueror
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributor statistics
    • Graph
    • Compare revisions
  • Issues 2
    • Issues 2
    • List
    • Boards
    • Service Desk
    • Milestones
  • Bugzilla
    • Bugzilla
  • Merge requests 6
    • Merge requests 6
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Artifacts
    • Schedules
  • Deployments
    • Deployments
    • Releases
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • NetworkNetwork
  • KonquerorKonqueror
  • Merge requests
  • !83

Improve handling of ioslave failures

  • Review changes

  • Download
  • Patches
  • Plain diff
Merged Stefano Crocco requested to merge stefanocrocco/konqueror:fix-man-invalid-url-message into master Aug 20, 2021
  • Overview 11
  • Commits 2
  • Pipelines 0
  • Changes 2

Previously, when the job reported a failure, a generic error message provided by QtWebEngine was displayed. Now, WebEnginePartKIOHandler makes use of KIO::StoredTransferJob::errorString to display a more informative message.

Some ioslave, in particular the man ioslave (at least after commit d5f2beb2c13c8b3a202b4979027ad5430f007705) leave the error string empty and put the error message inside data(). Because of this, if errorString is empty and data is not empty, data is used.

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: fix-man-invalid-url-message