Commit fc9fc1c3 authored by Jonathan Marten's avatar Jonathan Marten
Browse files

KStatusNotifierItem new API need to be guarded with KNotifications version

Introduced in commit b3d86129.
parent f8b9e625
Pipeline #137412 passed with stage
in 1 minute and 54 seconds
......@@ -8,7 +8,7 @@
#include "application.h"
#include "config/preferences.h"
#include <kwindowsystem_version.h>
#include <knotifications_version.h>
namespace Konversation
{
......@@ -31,7 +31,7 @@ namespace Konversation
void TrayIcon::hideWindow()
{
#if KWINDOWSYSTEM_VERSION >= QT_VERSION_CHECK(5, 91, 0)
#if KNOTIFICATIONS_VERSION >= QT_VERSION_CHECK(5, 91, 0)
hideAssociatedWidget();
#else
QWidget *window = associatedWidget();
......
  • mentioned in commit 10551650

    Toggle commit list
  • @marten Thanks for fixing, cherry-picked to stable branch.

    Curious, how did you find out about this hick-up?

  • My development setup is probably very unusual, so it's not surprising that the problem didn't show up before. What I do is most development on my main desktop system (which is dangerous, I know) and also I don't always keep everything at the same version (also dangerous, I know). So what must have happened was that I had updated kwindowsystem to 5.91 to investigate another problem, but didn't need to update knotifications which stayed at whatever its previously built version was. So konversation looked at the wrong version and tried to use the new knotifications API.

    Unfortunately CI would not have picked up the problem as it builds everything from scratch every time.

    Glad to be of assistance...

Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment