GitLab

(cherry picked from commit 6bbe9ec4)

KPluginTrader is sort of deprecated (see https://phabricator.kde.org/T12173 for context). We can do everything here with KPluginLoader.

(cherry picked from commit ae5d8132)

In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"

A complete framebuffer update can be composed of multiple rect updates
notified by the GotFrameBufferUpdate callback. Instead of displaying
partially updated framebuffers, use FinishedFrameBufferUpdate to display
only complete framebuffers.

(cherry picked from commit 76f00755)

(cherry picked from commit ddafd193)

(cherry picked from commit 40ca087e)

(cherry picked from commit a216a4f2)

Use the reference URL for the documentation.

# Conflicts:
#       CMakeLists.txt

Summary:
In highdpi mode coordinates are specified in device independent pixels,
and Qt auto-scales everything by devicePixelRatio, i.e. the ratio between
the device independent and device pixel coordinate systems.

Thus for RDP we should pass the size in device pixels to xfreerdp.

For VNC we should avoid auto-scaling, which can be done by setting
devicePixelRatio of the paint device for the painted image, and
the size of the image should be converted to device independent
pixels where it's needed.

Reviewers: #kde_applications, davidedmundson, uwolfer, ahmadsamir, murrant, cfeck, ngraham

Reviewed By: murrant

Subscribers: yuyichao, ngraham, alexeymin, aacid

Differential Revision: https://phabricator.kde.org/D20790

This adds handling of cursor shape received from server.
This allows us to show same cursor locally.

If local cursor is requested/disabled, server is reconfigured with proper
encodings to enable/disable support for sending it.

If server does not support sending local cursor,
default Qt cursor is shown as a fallback.

Note: sometimes VNC server does not support changing from
sending local to showing remote cursor and this causes slight delay
due to reconnect.

(cherry picked from commit 36ec012f)

In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"

In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"

Summary:
When the client is quitted and have stopped trying to reconnect.

Previously, a failed connection will leave the main window in a "connected" state
and require manually pressing the "Disconnect" button before a new connection can be made.

Use of the `disconnected` signal copied from the RDP backend, which handles this correctly.

Test Plan: Tested behavior on 20.04 branch. Tested compilation also on master.

Reviewers: davidedmundson, uwolfer, ahmadsamir, murrant, cfeck

Reviewed By: uwolfer

Differential Revision: https://phabricator.kde.org/D29822

(cherry picked from commit d7166eb1)

Current implementation relies on setting current thread pointer inside
the thread-local storage of current thread itself. We don't need this
workaround as we only ever need to get a pointer to the thread and it
can be done without relying on TLS.

Summary:
Although NX still exists, and nomachine.com offers downloads for
Linux, the NX plugin for krdc was never updated since KDE 4.2.
Let's call 8 years with no development a "unused, remove" kind of feature.

Test Plan:
The top-level CMakeLists.txt had the check for NX commented out,
and the sub-CMakeLists.txt checked for a _FOUND that couldn't
possibly be set.

Reviewers: uwolfer

Subscribers: aacid

Differential Revision: https://phabricator.kde.org/D23453

(cherry picked from commit 926472b1)

Test Plan:
The Bookmarks menu is still added as expected and the actions still show
in the configure shortcuts dialog. I couldn't test actually creating a
bookmark as I have no access to remote servers.

Reviewers: cfeck, uwolfer, murrant

Reviewed By: cfeck

Differential Revision: https://phabricator.kde.org/D28920

(cherry picked from commit 6546b699)