Krfb merge requestshttps://invent.kde.org/network/krfb/-/merge_requests2024-03-12T00:28:31Zhttps://invent.kde.org/network/krfb/-/merge_requests/62DMA-BUF size may not match size from handleRemoteDesktopStarted()2024-03-12T00:28:31ZJordan PrydeDMA-BUF size may not match size from handleRemoteDesktopStarted()See !61 for discussion.
I recently upgraded my laptop to Fedora Rawhide and found that Krfb immediately crashed with a segfault upon opening, after accepting the request from xdg-desktop-portal.
Upon some troubleshooting I determined t...See !61 for discussion.
I recently upgraded my laptop to Fedora Rawhide and found that Krfb immediately crashed with a segfault upon opening, after accepting the request from xdg-desktop-portal.
Upon some troubleshooting I determined the root cause was that the `PWFrameBuffer::videoSize` did not match my screen resolution (or more importantly the DMA-BUF size). This led to an undersized buffer being passed to `DmaBufHandler::downloadFrame()` from kPipewire. The resulting behavior ranged from EGL errors, to segfaults, to a kwin compositor crash (which recovered all QT-based clients automatically).
I'm not sure why https://invent.kde.org/network/krfb/-/blob/master/framebuffers/pipewire/pw_framebuffer.cpp?ref_type=heads#L337 isn't returning a valid size. It may be worth determining that before accepting this patch.
```cpp
setVideoSize(qdbus_cast<QSize>(streams.first().map[QStringLiteral("size")].value<QDBusArgument>()));
```https://invent.kde.org/network/krfb/-/merge_requests/51Draft: Move Flatpak CI to GitLab2023-08-31T14:52:54ZJulius EnriquezDraft: Move Flatpak CI to GitLab- /.flatpak-manifest.json
- /.gitlab-ci.yml
Adds Flatpak manifest from [flatpak-kde-applications](https://invent.kde.org/packaging/flatpak-kde-applications) and Flatpak job definition for switching to GitLab CI.- /.flatpak-manifest.json
- /.gitlab-ci.yml
Adds Flatpak manifest from [flatpak-kde-applications](https://invent.kde.org/packaging/flatpak-kde-applications) and Flatpak job definition for switching to GitLab CI.https://invent.kde.org/network/krfb/-/merge_requests/49CI: Add flatpak2023-08-04T02:16:49ZJustin ZobelCI: Add flatpakhttps://invent.kde.org/network/krfb/-/merge_requests/47fix: Fix the problem of tearing the pipewire image2024-01-22T02:28:33Zliuzheng liuzhengfix: Fix the problem of tearing the pipewire imageThe problem of image tearing is solved by controlling the copying and refreshing of pipewire data through locks.
log: Fix the problem of tearing the pipewire imageThe problem of image tearing is solved by controlling the copying and refreshing of pipewire data through locks.
log: Fix the problem of tearing the pipewire imagehttps://invent.kde.org/network/krfb/-/merge_requests/46fix: Fix the problem of tearing the pipewire image2023-04-03T13:43:18Zliuzheng liuzhengfix: Fix the problem of tearing the pipewire imageThe problem of image tearing is solved by controlling the copying and refreshing of pipewire data through locks.
log: Fix the problem of tearing the pipewire imageThe problem of image tearing is solved by controlling the copying and refreshing of pipewire data through locks.
log: Fix the problem of tearing the pipewire imagehttps://invent.kde.org/network/krfb/-/merge_requests/41Port framebuffers away from deprecated QDesktopWidget2024-01-07T23:56:14ZNicolas FellaPort framebuffers away from deprecated QDesktopWidgetUse QPlatformNativeInterface to get the WId insteadUse QPlatformNativeInterface to get the WId insteadNicolas FellaNicolas Fellahttps://invent.kde.org/network/krfb/-/merge_requests/38Some Qt6 fixes2024-01-08T00:45:39ZNicolas FellaSome Qt6 fixesNicolas FellaNicolas Fellahttps://invent.kde.org/network/krfb/-/merge_requests/20Increase cmake deps , use cpp172021-09-04T14:24:29ZÖmer Fadıl UstaIncrease cmake deps , use cpp17QT to 5.15.0
KF to 5.82
Enable cpp17QT to 5.15.0
KF to 5.82
Enable cpp17Ömer Fadıl UstaÖmer Fadıl Ustahttps://invent.kde.org/network/krfb/-/merge_requests/8Make sure to save security settings each time they are modified2020-09-15T14:56:13ZAlexey MinMake sure to save security settings each time they are modifiedSettings that are modified using normal settings window, which is
invoked using menu "Configure Desktop Sharing..." are always saved
correctly.
However some settings that are present on Krfb main window
(normal password, unattended pass...Settings that are modified using normal settings window, which is
invoked using menu "Configure Desktop Sharing..." are always saved
correctly.
However some settings that are present on Krfb main window
(normal password, unattended password, checkbox "enable unattended
access") are not handled by KConfigDialog and there is a chance that
settings might not be saved correctly (for example if application
was suddenly terminated).
This hopefully fixes some bugs which are present since year 2011-2014
with several duplicates and 110 votes, like
https://bugs.kde.org/show_bug.cgi?id=340411, maybe some others.
```
CCBUG: 340411
CCBUG: 288481
possibly FIXED-IN: 20.08.2 (do not forget to update commit message)
CHANGELOG: Make sure to save passwords each time they are modified
```https://invent.kde.org/network/krfb/-/merge_requests/2Better looking UI layout for the main screen2020-08-07T14:29:03ZZakhar AfoninBetter looking UI layout for the main screenThe current UI layout of Krfb wastes too much space on the totally needed large icon on the left side. Also, the name of the application is duplicated: one in the title bar, another in the application itself. I propose a better looking U...The current UI layout of Krfb wastes too much space on the totally needed large icon on the left side. Also, the name of the application is duplicated: one in the title bar, another in the application itself. I propose a better looking UI layout that wastes less space yet still has everything needed.
![Screenshot_20200807_105557](/uploads/78bc739a7a6e01010ce06dd932c289bc/Screenshot_20200807_105557.png)
Compare to the current layout:
![Screenshot_20200807_105322](/uploads/5d95d5029e9af14d53c273e0eed9d49d/Screenshot_20200807_105322.png)
@teams/vdg