KTorrent merge requestshttps://invent.kde.org/network/ktorrent/-/merge_requests2024-03-27T23:26:40Zhttps://invent.kde.org/network/ktorrent/-/merge_requests/117Undo system tray bug workaround2024-03-27T23:26:40ZJack Hilljackhill3103@gmail.comUndo system tray bug workaroundIn KF5 KStatusNotifierIcon would show/hide the main QWindow whilst in KTorrent
we would show/hide the main QWidget. A bug in Qt6 meant that hiding/showing
the QWindow did not neccessarily hide the QWidget.
So if a user closed the window...In KF5 KStatusNotifierIcon would show/hide the main QWindow whilst in KTorrent
we would show/hide the main QWidget. A bug in Qt6 meant that hiding/showing
the QWindow did not neccessarily hide the QWidget.
So if a user closed the window to the tray, the QWidget was considered hidden
but the QWindow was not. Then when clicking on the tray icon, the QWindow
visiblity was being toggled but the QWidget visibility was always hidden.
To work around this we changed KTorrent to hide the QWindow instead of the
QWidget. Now KStatusNotifierIcon has been updated to hide the main QWidget
instead of the QWindow, so we must undo the changes made here.
The upstream bug should fixed in Qt 6.7 anyway.
Reverts e35b4881605f045ebe8bca2da357c2a3ae2f1e02
Reverts efe4aa0dcc23e57e68ecd809068f1a49d7705a07
BUG: 484598https://invent.kde.org/network/ktorrent/-/merge_requests/66Change tray icon to be in "Active" state instead of "Passive" state.2024-02-12T21:40:40ZMark MielkeChange tray icon to be in "Active" state instead of "Passive" state.KTorrent with "System Tray Icon" enabled in Xfce, does not show
the system tray icon, and worse, when the window is closed, there
is no way to reach the icon to request that the window be re-opened.
This makes the "System Tray Icon" func...KTorrent with "System Tray Icon" enabled in Xfce, does not show
the system tray icon, and worse, when the window is closed, there
is no way to reach the icon to request that the window be re-opened.
This makes the "System Tray Icon" functionality unusable in Xfce.
In Xfce, "Passive" tray icons are not shown. This is due to a strict
interpretion of the definitions in KStatusNotifierItem::ItemStatus:
- Passive: "Nothing is happening in the application, so showing this
icon is not required."
- Active: "The application is doing something, or it is important that
the icon is always reachable from the user."
KTorrent is active by nature. Even when not actively downloading,
KTorrent will normally be actively listening for connections.
Most importantly, the icon should always be reachable to the user.