Commit f07a85bf authored by Nate Graham's avatar Nate Graham
Browse files

Fix misplaced slider backgrounds

Binding x and y to padding values makes no sense, so let's use anchors
instead.

BUG: 424154
FIXED-IN: 20.08.0
parent 66f43d9a
...@@ -137,8 +137,8 @@ FocusScope { ...@@ -137,8 +137,8 @@ FocusScope {
// slider. This is done so the slider's own background can be full // slider. This is done so the slider's own background can be full
// height yet transparent, for easier clicking // height yet transparent, for easier clicking
Rectangle { Rectangle {
x: musicProgress.leftPadding anchors.left: musicProgress.left
y: musicProgress.topPadding + musicProgress.availableHeight / 2 - height / 2 anchors.verticalCenter: musicProgress.verticalCenter
implicitWidth: seekWheelHandler.width implicitWidth: seekWheelHandler.width
implicitHeight: 6 implicitHeight: 6
color: myPalette.dark color: myPalette.dark
...@@ -180,8 +180,6 @@ FocusScope { ...@@ -180,8 +180,6 @@ FocusScope {
// https://bugs.kde.org/show_bug.cgi?id=408703. The actual visual // https://bugs.kde.org/show_bug.cgi?id=408703. The actual visual
// background is generated above ^^ // background is generated above ^^
background: Rectangle { background: Rectangle {
x: musicProgress.leftPadding
y: musicProgress.topPadding + musicProgress.availableHeight / 2 - height / 2
anchors.fill: parent anchors.fill: parent
implicitWidth: seekWheelHandler.width implicitWidth: seekWheelHandler.width
implicitHeight: seekWheelHandler.height implicitHeight: seekWheelHandler.height
...@@ -261,8 +259,8 @@ FocusScope { ...@@ -261,8 +259,8 @@ FocusScope {
// slider. This is done so the slider's own background can be full // slider. This is done so the slider's own background can be full
// height yet transparent, for easier clicking // height yet transparent, for easier clicking
Rectangle { Rectangle {
x: volumeSlider.leftPadding anchors.left: volumeSlider.left
y: volumeSlider.topPadding + volumeSlider.availableHeight / 2 - height / 2 anchors.verticalCenter: volumeSlider.verticalCenter
implicitWidth: audioWheelHandler.width implicitWidth: audioWheelHandler.width
implicitHeight: 6 implicitHeight: 6
radius: 3 radius: 3
......
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment