GitLab

the sort button has a varying width: placing it leftmost to avoid having
the other buttons move

we do not use any extra feature from QStringList

the menu entries now have just the name

the button is now Sort: %label%

necessary to be able to sort albums by year

able to sort by different roles and in ascending and descending orders

still keep transition on pop but no longer on push

fixes opacity sometime being equal to 0 without a clear explanation

BUG: 426417
FIXED-IN: 20.08.2

(cherry picked from commit 97ae90fcbf14e071b0bc4168ff4d6cbbffd88384)

BUG: 424932

This fixes the text on the placeholder flooding out when playlist is hidden

This makes them look a bit nicer. The whole view is now horizontally
centered, rather than the individual labels being horizontally centered.

To do this, the code is changed to use a GridLayout rather than
individual RowLayouts inside a ColumnLayout.

Using a placeholder for the type of data in the string doesn't work
because of grammatical genders and other differences from English.

The UI code is implemented in a very generic way, which is good
overall, but it prevents us from easily defining a different string
for every that it could be displaying, which would be the best way to
solve the string puzzle.

Accordingly, this commit takes the lazy path by just setting the
placeholder text to a status string with no substitutions. The message
is more generic, but always translatable.

I don't know that QML enums existed back when this component was created
(they were introduced in Qt 5.10). Either way, they do now, so we should
use them.

This compinent suffered from various rookie mistakes:
- Making assumptions about its parent item
- Setting width and height properties of items in Layouts
- Hardcoded heights rather than using units

All are fixed. Visual changes are extremely minimal.

(cherry picked from commit 3345f405)