1. 07 Jul, 2020 2 commits
  2. 06 May, 2020 1 commit
  3. 29 Feb, 2020 1 commit
  4. 25 Feb, 2020 1 commit
  5. 17 Feb, 2020 1 commit
  6. 11 Feb, 2020 2 commits
  7. 22 Jan, 2020 1 commit
    • Matthieu Gallien's avatar
      allow database to contain and get tracks without metadata · 0c042a86
      Matthieu Gallien authored
      display only the filename
      
      I plan to add on top the work done by astippich that uses a sligthly
      different approach
      
      the tests are KO
      
      the tracks without metadata are imported again and again. Needs fixing.
      
      use url everywhere we refer to tracks or radios
      
      allow to handle tracks without databaseId like the case of a track
      without metadata
      
      BUG: 415180
      0c042a86
  8. 08 Jan, 2020 2 commits
    • Nate Graham's avatar
    • Nate Graham's avatar
      Playlist: adopt simpler and more compact track/disc numbering and playback indicator · 0ae5dd3e
      Nate Graham authored
      Elisa's playlist items currently use a bunch of very complicated code to produce a large amount of whitespace to the left of the track/album numbers that contains only the playback indicator, and aligns the right edge of the album art with the right edge of the numbers. Unfortunately this results in a lot of wasted space in the very narrow space of the playlist, and many song titles are elided.
      
      This MR changes the visual style to reduce the whitespace and replace the track/disc number indicator with the playback indicator for the currently playing song, saving a ton of space. Doing this allows the elimination of a great deal of complex and fragile layouting code.
      0ae5dd3e
  9. 04 Jan, 2020 1 commit
  10. 03 Jan, 2020 1 commit
  11. 28 Dec, 2019 1 commit
  12. 22 Dec, 2019 1 commit
  13. 10 Nov, 2019 1 commit
  14. 09 Sep, 2019 1 commit
  15. 09 Jul, 2019 2 commits
    • Alexander Stippich's avatar
      Unify simple and normal playlist entry · e28df06a
      Alexander Stippich authored
      Reviewers: mgallien, ngraham
      
      Reviewed By: ngraham
      
      Tags: #elisa
      
      Differential Revision: https://phabricator.kde.org/D22345
      e28df06a
    • Nate Graham's avatar
      Remove selection state change animations · 0dd279e3
      Nate Graham authored
      Summary:
      In general animations are nice, but animations for changed hover states are often
      very distracting. Animating color and opacity changes can produce a visual
      artifact whereby blue turns into gray. Furthermore, having the state be animated means
      that moving the mouse rapidly over list items makes the highlight not follow the
      mouse closely, which looks awkward.
      
      This patch resolves those issues by removing the animation effects.
      
      Test Plan:
      Before: {F6986295}
      
      After: {F6986296}
      
      Reviewers: mgallien, #elisa, #vdg, astippich
      
      Reviewed By: #elisa, astippich
      
      Subscribers: astippich
      
      Differential Revision: https://phabricator.kde.org/D22307
      0dd279e3
  16. 07 Jul, 2019 1 commit
    • Alexander Stippich's avatar
      Large cleanup, fixes and tweaks for playlists · 64709c70
      Alexander Stippich authored
      Summary:
      Large cleanup for all qml files regarding playlist.
      Increase the button size in PlayListEntry so that it is easier
      to click and set icon size.
      Makes SimplePlayListEntry and PlayListEntry more similar.
      Fixes display of multi-disc albums in the playlist view.
      Adds accessibility to SimplePlayListEntry.
      Remove warnings for SimplePlayListEntry due to missing data.
      
      Test Plan:
      playlist has buttons with full delegate height,
      multi-disc albums are showing correctly for the playlist,
      no more warnings for SimplePlayListEntry
      
      Reviewers: mgallien, ngraham
      
      Reviewed By: mgallien
      
      Tags: #elisa
      
      Differential Revision: https://phabricator.kde.org/D22204
      64709c70
  17. 19 Jun, 2019 1 commit
  18. 12 Jun, 2019 2 commits
  19. 06 Jun, 2019 2 commits
    • Nate Graham's avatar
      Make Playlist items span full width · fe7d7043
      Nate Graham authored
      Summary:
      Currently playlist items do not span the full width; there is a bunch of
      complicated logic to determine the margins and playlist's width. This
      makes the display look unbalanced and causes a subtle visual bug
      (see BUG: below).
      
      This patch resolves both issues by making playlist items visually stick to
      both edges of the playlist, just like the category selector list items do.
      
      This patch also does a bit of necessary code cleanup for the playlist states.
      I tested this out quite a bit but to make sure there were no regressions but
      it's possible that I missed something so more testing may be needed.
      
      BUG: 408210
      
      Test Plan:
      Before: {F6871989}
      
      After: {F6871988}
      
      Reviewers: mgallien, #elisa
      
      Reviewed By: mgallien, #elisa
      
      Subscribers: januz
      
      Differential Revision: https://phabricator.kde.org/D21582
      fe7d7043
    • Nate Graham's avatar
      Make Playlist items span full width · 50bbbfa3
      Nate Graham authored
      Summary:
      Currently playlist items do not span the full width; there is a bunch of
      complicated logic to determine the margins and playlist's width. This
      makes the display look unbalanced and causes a subtle visual bug
      (see BUG: below).
      
      This patch resolves both issues by making playlist items visually stick to
      both edges of the playlist, just like the category selector list items do.
      
      This patch also does a bit of necessary code cleanup for the playlist states.
      I tested this out quite a bit but to make sure there were no regressions but
      it's possible that I missed something so more testing may be needed.
      
      BUG: 408210
      
      Test Plan:
      Before: {F6871989}
      
      After: {F6871988}
      
      Reviewers: mgallien, #elisa
      
      Reviewed By: mgallien, #elisa
      
      Subscribers: januz
      
      Differential Revision: https://phabricator.kde.org/D21582
      50bbbfa3
  20. 04 Jun, 2019 1 commit
  21. 14 May, 2019 1 commit
  22. 13 Apr, 2019 1 commit
    • Nate Graham's avatar
      When not displaying rating, leave more room for song title in playlist · 358086c2
      Nate Graham authored
      Summary:
      Currently the Playlist's ratings widget reserves space for itself for unrated songs,
       which causes song titles to get elided even when there's plenty of space.
      
      This patch hides the ratings widget for unrated songs, allowing the song title label
      to have more space and not be elides as often.
      
      This could become a problem in the future if there is ever a desire to set ratings
      interactively by clicking on the ratings widget, but that's not implemented so for now
      there's no issue (and probably a hover-based UI could make sense for that anyway).
      
      BUG: 406480
      
      Test Plan:
      Now song titles for unrated songs have plenty of space, and rated songs display the same:
      
      {F6770576}
      
      Reviewers: mgallien, #elisa
      
      Reviewed By: mgallien, #elisa
      
      Differential Revision: https://phabricator.kde.org/D20511
      358086c2
  23. 16 Feb, 2019 1 commit
  24. 05 Feb, 2019 1 commit
  25. 01 Feb, 2019 1 commit
  26. 31 Dec, 2018 1 commit
  27. 30 Dec, 2018 1 commit
  28. 20 Dec, 2018 1 commit
  29. 14 Dec, 2018 1 commit
  30. 12 Dec, 2018 1 commit
  31. 17 Sep, 2018 1 commit
  32. 13 Sep, 2018 2 commits
  33. 10 Sep, 2018 1 commit