1. 13 Jun, 2020 1 commit
  2. 06 Jun, 2020 1 commit
  3. 31 May, 2020 1 commit
  4. 24 May, 2020 1 commit
  5. 23 May, 2020 1 commit
  6. 22 May, 2020 1 commit
  7. 19 May, 2020 1 commit
  8. 09 May, 2020 1 commit
  9. 08 May, 2020 1 commit
  10. 03 May, 2020 2 commits
    • David Faure's avatar
      GIT_SILENT add comment · 311e3085
      David Faure authored
      311e3085
    • David Faure's avatar
      KAuthorized: export method to reload restrictions · 2789bb2c
      David Faure authored
      Summary:
      This is useful for unittests. Example:
      
      ```
      KCONFIGCORE_EXPORT void reloadUrlActionRestrictions();
      
      void someTestMethod()
      {
          KConfigGroup cg(KSharedConfig::openConfig(), "KDE URL Restrictions");
          cg.writeEntry("rule_count", 1);
          cg.writeEntry("rule_1", QStringList{"open", {}, {}, {}, "file", "", "", "false"});
          cg.sync();
          reloadUrlActionRestrictions();
      
          // Some test for code that uses KUrlAuthorized
      
          cg.deleteEntry("rule_1");
          cg.deleteEntry("rule_count");
          cg.sync();
          reloadUrlActionRestrictions();
      }
      ```
      This is consistent with the fact that other functions used by
      KUrlAuthorized are defined here and exported internally.
      
      Test Plan: Used this in a KIO unittest I'm writing for the future OpenUrlJob
      
      Reviewers: aacid, apol, mdawson
      
      Reviewed By: aacid
      
      Subscribers: kde-frameworks-devel
      
      Tags: #frameworks
      
      Differential Revision: https://phabricator.kde.org/D29347
      2789bb2c
  11. 02 May, 2020 1 commit
  12. 22 Apr, 2020 1 commit
  13. 21 Apr, 2020 1 commit
    • Ahmad Samir's avatar
      Fix some compiler warnings · fb29718d
      Ahmad Samir authored
      Summary:
      - Fix order of member initialisation (compiling with -Wreorder)
      - Use Q_UNUSED where needed
      - QAtomicInteger::loadRelaxed() has been available since Qt 5.14
      
      Test Plan: make && ctest
      
      Reviewers: #frameworks, dfaure, apol
      
      Reviewed By: dfaure
      
      Subscribers: kde-frameworks-devel
      
      Tags: #frameworks
      
      Differential Revision: https://phabricator.kde.org/D27158
      fb29718d
  14. 20 Apr, 2020 1 commit
    • Friedrich W. H. Kossebau's avatar
      API dox: document Q_DECLARE_FLAGS-based flags · aa28a243
      Friedrich W. H. Kossebau authored
      Summary:
      KApiDox & ECMAddQch have been just teached about Q_DECLARE_FLAGS, so the
      underlying typedefs are no longer skipped by doxygen, but can be
      documented now, allowing links to be generated for these types e.g. when
      used as arguments.
      
      The "#" prefix to the enum name in the description text of all the
      Q_DECLARE_FLAGS docs seems needed to properly trigger doxygen autolinks.
      
      GIT_SILENT
      aa28a243
  15. 17 Apr, 2020 1 commit
    • Benjamin Port's avatar
      Add force save behavior to KEntryMap · be28e096
      Benjamin Port authored
      Summary:
      Fix the following bug, if an entry is set on HOME/.config/kdeglobals and on a specific config file like kcmfonts
      When you hit restore defaults button and apply, value will be not wrote on the specific file, but then the value is the one from kdeglobals
      This patch ensure we write the key to the specific configuration file on those case with an empty value. KConfig will take default value automatically
      
      Test Plan:
      Added a test to ensure flag is working
      Tested using some KCM to ensure all is working fine
      
      Reviewers: ervin, dfaure, meven, crossi, hchain
      
      Reviewed By: ervin, dfaure, meven
      
      Subscribers: kde-frameworks-devel
      
      Tags: #frameworks
      
      Differential Revision: https://phabricator.kde.org/D28128
      be28e096
  16. 13 Apr, 2020 1 commit
  17. 11 Apr, 2020 1 commit
  18. 04 Apr, 2020 1 commit
  19. 30 Mar, 2020 1 commit
  20. 23 Mar, 2020 1 commit
  21. 22 Mar, 2020 1 commit
  22. 19 Mar, 2020 1 commit
  23. 12 Mar, 2020 1 commit
  24. 08 Mar, 2020 1 commit
    • Méven Car's avatar
      KconfigXT: Add a value attribute to Enum field choices · ec207330
      Méven Car authored
      Summary:
      Allow to write choices such as :
      ```
      <choices>
          <choice name="enum_name" value="I can't containt (anything)"></choice>
          <choice name="normal_choice"></choice>
      </choices>
      ```
      
      Test Plan: ctest
      
      Reviewers: ervin, bport, crossi, #frameworks
      
      Reviewed By: ervin
      
      Subscribers: ngraham, davidre, kde-frameworks-devel
      
      Tags: #frameworks
      
      Differential Revision: https://phabricator.kde.org/D27463
      ec207330
  25. 07 Mar, 2020 2 commits
  26. 06 Mar, 2020 1 commit
  27. 03 Mar, 2020 1 commit
  28. 02 Mar, 2020 1 commit
    • Ahmad Samir's avatar
      [KConfigGui] Clear styleName font property for Regular font sytles · a2774ff5
      Ahmad Samir authored
      Summary:
      If the styleName property is set for a QFont, using setBold(true) would
      lead to Qt using an "emboldended"/synthetic font style instead of using
      the bold style provided by the font itself (usually as a standalone font
      file), the former looks ugly (IIUC, Freetype emboldens fonts as a last
      resort for fonts that don't provide a bold style at all).
      
      Accoring to upstream[1] the styleName property is useful for fonts with
      fancy style names, and also it shouldn't be set if it's not needed; and
      indeed using styleName with e.g. "Regular" doesn't make sense, as there
      is no "Regular Bold" style AFAICS.
      
      Checking for "Regular|Normal|Book|Roman" is based on examining the font
      styles provided by the font packages available on OpenSuse Tumbleweed ATM,
      (I didn't include some of the weird/non-common ones e.g. I've seen "Roma"
      and "Rounded"). Some statistics about the "Regular"-like font styles from
      my testing:
      Regular:  2486
      Normal:  66
      Book:  20
      Roman:  13
      
      For more details see:
      [1] https://bugreports.qt.io/browse/QTBUG-63792
      https://bugs.kde.org/show_bug.cgi?id=378523
      
      BUG: 378523
      
      FIXED-IN: 5.68
      
      Test Plan:
      All unit tests still pass.
      
      Changing the fonts via e.g. the fonts KCM doesn't append the font sytleName,
      to the relevant font config entry, if the "Regular" style or co. is used.
      
      A simple test, look at the current dir name in the Dolphin url bar with
      and without ",Regular" appended to the font= entry (assuming you're using
      Noto Sans or DejaVu Sans as the styleName varies from font to font).
      
      Reviewers: #frameworks, dfaure, davidedmundson, cfeck, ervin
      
      Reviewed By: dfaure
      
      Subscribers: kde-frameworks-devel
      
      Tags: #frameworks
      
      Differential Revision: https://phabricator.kde.org/D27735
      a2774ff5
  29. 28 Feb, 2020 1 commit
  30. 26 Feb, 2020 1 commit
  31. 25 Feb, 2020 1 commit
    • Henri Chain's avatar
      Fix code generation for entries with min/max · d218b93a
      Henri Chain authored
      Summary:
      - When GenerateProperties and Mutators are activated, the generated code
        did not handle min/max properly
      
      - In the case of a parameterized entry, generated code also did not
        handle min/max
      
      BUG: 418146
      
      Test Plan: - auto tests included
      
      Reviewers: meven, crossi, ervin, bport, tcanabrava
      
      Reviewed By: meven, ervin
      
      Subscribers: kde-frameworks-devel
      
      Tags: #frameworks
      
      Differential Revision: https://phabricator.kde.org/D27497
      d218b93a
  32. 24 Feb, 2020 1 commit
    • Cyril Rossi's avatar
      KConfigSkeletonItem : allow to set a KconfigGroup to read and write items in nested groups · c8bf5e96
      Cyril Rossi authored
      Summary:
      Currently KConfgiSkeleton cannot manage item entry in subgroup, like
      
      ```
      [General][Colors]
      MyItem=foo
      ```
      
      Example of use
      
      ```
      // Generated Class with KConfig compiler, inherits KConfigSkeleton
      
      KConfigGroup generalGroup( &config, "General" );
      KConfigGroup colorsGroup = config.group( "Colors" )
      myItem->setGroup(cg); // Now can take a KConfigGroup
      addItem(myItem, "MyItem");
      
      ```
      
      Evolution of kconfig compiler will follow to consider this.
      
      Reviewers: ervin, dfaure, #frameworks, mdawson
      
      Reviewed By: ervin, dfaure
      
      Subscribers: kde-frameworks-devel
      
      Tags: #frameworks
      
      Differential Revision: https://phabricator.kde.org/D27059
      c8bf5e96
  33. 19 Feb, 2020 1 commit
  34. 14 Feb, 2020 1 commit
  35. 12 Feb, 2020 3 commits
  36. 09 Feb, 2020 1 commit