1. 23 Jun, 2020 1 commit
  2. 20 Jun, 2020 1 commit
  3. 18 Jun, 2020 1 commit
  4. 17 Jun, 2020 1 commit
  5. 16 Jun, 2020 1 commit
  6. 11 Jun, 2020 1 commit
  7. 09 Jun, 2020 1 commit
  8. 03 Jun, 2020 1 commit
  9. 31 May, 2020 1 commit
  10. 27 May, 2020 1 commit
  11. 14 May, 2020 1 commit
  12. 08 May, 2020 1 commit
  13. 03 May, 2020 1 commit
  14. 02 May, 2020 1 commit
    • Alexander Lohnau's avatar
      Konsole Runner: optimize and simplify · 50c93e3c
      Alexander Lohnau authored
      Summary:
      The match method has been rewritten and the profiles are only loaded when the plugin
      is initialized or the config folder changes.
      
      Test Plan:
      Create different profiles and start the runner using the keyword "konsole", all profiles should show
      up, if one is selected, konsole launches with this profile.
      To filter the profiles you can type "konsole KEYWORD" and only the profiles that contain the keyword show up.
      Furthermore you can create/edit/delete new profiles after the runner is initailized and they still show up.
      
      Reviewers: davidedmundson, ngraham, #plasma, #konsole, tcanabrava, hindenburg, broulik, meven
      
      Reviewed By: ngraham, meven
      
      Subscribers: apol, plasma-devel
      
      Tags: #plasma
      
      Differential Revision: https://phabricator.kde.org/D27098
      50c93e3c
  15. 25 Apr, 2020 1 commit
  16. 24 Apr, 2020 1 commit
    • Nate Graham's avatar
      [applets/weather] Improve UX for selecting a weather station · ef213aaa
      Nate Graham authored
      Summary:
      This patch improves the UX of selecting a weather station by re-implementing it a column
      of checkboxes that are visible by default at the top of the window, so that selecting a
      weather station is follows the local top-to-bottom flow of the page.
      
      When no weather stations are selected (as it is by default), everything else in the
      window is disabled so it's completely obvious what you need to do to proceed.
      
      Test Plan: {F8256457}
      
      Reviewers: #vdg, #plasma, broulik, kossebau, spstarr
      
      Reviewed By: #plasma, spstarr
      
      Subscribers: ndavis, spstarr, plasma-devel
      
      Tags: #plasma
      
      Differential Revision: https://phabricator.kde.org/D29144
      ef213aaa
  17. 23 Apr, 2020 1 commit
  18. 22 Apr, 2020 1 commit
  19. 09 Apr, 2020 1 commit
  20. 06 Apr, 2020 1 commit
  21. 04 Apr, 2020 1 commit
  22. 31 Mar, 2020 2 commits
  23. 27 Mar, 2020 1 commit
  24. 26 Mar, 2020 1 commit
  25. 24 Mar, 2020 2 commits
  26. 23 Mar, 2020 7 commits
    • Nate Graham's avatar
      [applets/notes] Actually hide button row when it's not visible · 7eaad09e
      Nate Graham authored
      Summary:
      Currently the row's opacity is changed from 0% to 100% depending on focus state, but it
      does not actually become hidden when at 0% opacity. This means that it's possible to
      click the invisible buttons accidentally when focusing the applet. This has been an
      issue for a long time, but becomes dangerous with D28064, since you could delete a note
      just by clicking in the bottom-right corner to focus the applet!
      
      This patch makes the button row actually hidden when the applet is not focused, not just
      100% transparent.
      
      Test Plan:
      Clicking on the place where a button will appear on an unfocused applet now just focuses
      it and does not also click the button.
      
      Reviewers: #plasma, #vdg, davidedmundson
      
      Reviewed By: #plasma, davidedmundson
      
      Subscribers: broulik, plasma-devel
      
      Tags: #plasma
      
      Differential Revision: https://phabricator.kde.org/D28209
      7eaad09e
    • Harald Sitter's avatar
      add missing include to fix freebsd build · 5b4f1671
      Harald Sitter authored
      LC_ALL (and other categories) are defined in clocale
      5b4f1671
    • Harald Sitter's avatar
      do not link qtest on the runner · 9264a115
      Harald Sitter authored
      it's only needed for the test and was erronously added to the lib itself
      9264a115
    • Harald Sitter's avatar
      make convertrunner only build once · a26c6c5f
      Harald Sitter authored
      build the runner itself in a static lib we can use for testing and then
      link that into a module lib together with the factory entry point to
      compose the final lib for installation
      
      same as https://phabricator.kde.org/D28137
      a26c6c5f
    • Harald Sitter's avatar
      use correct locale for thousand separator + force qlocale default · c6be0e20
      Harald Sitter authored
      qlocale may end up picking the default too early (i.e. before init) leading
      to incorrect output format. also the original expectation was wrong anyway
      as neither C nor en_US would use point as thousand separator.
      
      with the explicit qlocale call numeric format should now be more reliably
      english
      c6be0e20
    • Alexander Lohnau's avatar
      Refactor converter runner · 08bb4ec7
      Alexander Lohnau authored
      Summary:
      The logic from the converter runner has been refactored and moved to seperate files.
      Additionally some foreach marcos have been refactored and the numberValue of the query gets only
      calculated once, instead of being calculated for each matching unit.
      
      Test Plan: The plugin should work as before and the fractional units in https://phabricator.kde.org/D22869 are still supported.
      
      Reviewers: broulik, ngraham, #plasma, sitter
      
      Reviewed By: broulik, #plasma, sitter
      
      Subscribers: sitter, plasma-devel
      
      Tags: #plasma
      
      Differential Revision: https://phabricator.kde.org/D27166
      08bb4ec7
    • Script Kiddy's avatar
      SVN_SILENT made messages (.desktop file) - always resolve ours · 8d5e1a0b
      Script Kiddy authored
      In case of conflict in i18n, keep the version of the branch "ours"
      To resolve a particular conflict, "git checkout --ours path/to/file.desktop"
      8d5e1a0b
  27. 20 Mar, 2020 1 commit
  28. 19 Mar, 2020 1 commit
    • Alexander Lohnau's avatar
      characters: Refactoring, improve validation in kcm, optimize · 8dd8fe55
      Alexander Lohnau authored
      Summary:
      The config keys are now in a separate file, instead of having them at two places.
      Runner
      The duplicate call to reloadConfiguration has been removed and aliases/codes get validated.
      Additionally the match method has been simplified and the character is now copied to the clipboard when selected.
      KCM
      Validation of the add/delete buttons, error message now in GUI and deprecated methods removed.
      
      Test Plan:
      Compile, test runner and test editing entries.
      Manually add alias(and no hex value) to ~/.config/krunnerrc and reload the kcm, error message should be shown.
      
      Before:
      {F8075415}
      {F8075416}
      
      After:
      {F8075419}
      {F8075420}
      {F8075422}
      
      Reviewers: davidedmundson, ngraham, sitter, broulik, #plasma
      
      Reviewed By: sitter
      
      Subscribers: davidre, dvratil, plasma-devel
      
      Tags: #plasma
      
      Differential Revision: https://phabricator.kde.org/D27096
      8dd8fe55
  29. 18 Mar, 2020 2 commits
  30. 16 Mar, 2020 1 commit
    • Nate Graham's avatar
      [applet/notes] Show a "remove" button on the button row · ef9ecb60
      Nate Graham authored
      Summary:
      I've personally observed various users struggle to remove a Sticky Note widget, and heard
      anedcotal user reports about this too. Some people look for a close button and don't
      find one, never thinking to press-and-hold or right-click. Some people do right-click
      but right-click in the content area rather than the frame (which look identical), and see
      the context menu for the text rather than the widget itself.
      
      This patch alleviates this user confusion by adding a {nav Remove} button on the button
      row on the bottom of the widget, next to the {nav Configure...} button. This makes it
      very easy to remove a Sticky Note. This is not destructive because there's an undo, so
      it's not a big deal if someone clicks the button by mistake.
      
      It could be argued that this makes the applet inconsistent with other widgets which do
      not display visible {nav Remove} buttons, which is true. However the nature of the Sticky
      Note applet is that it is likely to be used in a more transient or temporary manner than
      other widgets; it often has more in common with a temporary document than a permanent
      fixture of your desktop. For this reason, I believe it is appropriate to show a visible
      {nav Remove} button on the widget.
      
      The default size of the widget is increased a bit so that there's room for the new
      {nav remove} button as well as the text control buttons.
      
      Test Plan: {F8177920, size=full}
      
      Reviewers: #vdg, #plasma, ndavis
      
      Reviewed By: #vdg, ndavis
      
      Subscribers: ndavis, plasma-devel
      
      Tags: #plasma
      
      Differential Revision: https://phabricator.kde.org/D28064
      ef9ecb60
  31. 15 Mar, 2020 1 commit