1. 21 Jan, 2022 4 commits
  2. 20 Jan, 2022 2 commits
    • Arjen Hiemstra's avatar
      Update click method items in load() · 86838b3c
      Arjen Hiemstra authored and Nate Graham's avatar Nate Graham committed
      This makes sure we re-read the values from the backend. While these
      properties are marked as constant, they apparently change after
      LibinputTouchpad::getConfig is called, causing issues because the
      changed values aren't re-read.
      
      While I would love to fix the root cause (the properties changing while
      being marked constant) it would be a massively larger undertaking as in
      my opinion the entire code of this should be completely overhauled,
      right now it is fraught with races due to all the manual state
      management and lack of proper bindable properties.
      
      BUG: 447105
      86838b3c
    • Fushan Wen's avatar
      taskmanager: Fix incompatible arguments warning in ContextMenu.qml · 207a2aca
      Fushan Wen authored
      Fix the error: Passing incompatible arguments to C++ functions from
      JavaScript is dangerous and deprecated.
      207a2aca
  3. 19 Jan, 2022 3 commits
  4. 18 Jan, 2022 5 commits
    • Marco Martin's avatar
      don't make the icon too huge · 4e4df6af
      Marco Martin authored and Nate Graham's avatar Nate Graham committed
      4e4df6af
    • Marco Martin's avatar
      Bigger panel config icon when triggered from touch · 2a2e0597
      Marco Martin authored and Nate Graham's avatar Nate Graham committed
      When triggered on touch, make a bigger panel config icon
      which is more accessible via touch
      2a2e0597
    • Xuetian Weng's avatar
      Fix kded_keyboard crash if configured layout is empty. · a1e371f8
      Xuetian Weng authored and Fushan Wen's avatar Fushan Wen committed
      a1e371f8
    • Fushan Wen's avatar
      screenmappertest: Add tests to make sure activity ID works as expected · 749bb8e1
      Fushan Wen authored
      1. `tst_readScreenActivityMapping()`: Test reading screen mappings from a
         QStringList.
      2. `tst_saveScreenActivityMappingFromOldConfig()`: Test reading screen
         mappings from an old config before Plasma 5.25.
      3. `tst_readScreenActivityMapping()`: Test reading screen mappings from a
         QStringList.
      4. `tst_readAndSaveItemsOnActivitiesOnDisabledScreens()`: Test reading
         and saving disabled screen mappings.
      5. `tst_readAndSaveItemsOnActivitiesOnDisabledScreensFromOldConfig()`: Test
         reading and saving disabled screen mappings from an old config before
         Plasma 5.25.
      749bb8e1
    • Fushan Wen's avatar
      screenmapper: Remember activity ID in screen mapping · 7f09fb16
      Fushan Wen authored
      This commit adds an extra string to screenmapper to remember the
      activity ID corresponding to the screen ID. Now screenmapper can
      correctly handle different activites, and desktops of different
      activities can correctly show their items.
      
      The problem
      
      When the user sets "Files linked to the current activity" on one
      activity (A) and switches to any other activity (B), though the desktop
      on activity B is set to "Show Desktop folder",  there is nothing on
      the desktop until the user restarts plasmashell.
      
      The cause
      
      In screenmapper.cpp, `removeScreen()` only checkes for the screen ID,
      but two activities can share the same screen ID. Then if both the two
      activities are set to "Show desktop folder", then in `setUrl()`
      
      1. After the user changes the desktop folder option on one of the two activities,
         `removeScreen()` will remove all item records related to the screen
         ID and **the old URL (desktop:/)**.
      2. But `addScreen()` will only add back item records for the current activity
         because `addScreen()` will directly return if `m_availableScreens`
         already contains the screen ID (which is added from the current activity).
      3. Thus items on the desktop of the other activity incorrectly disappears.
      
      The fix
      
      1. When calling `addScreen()` or `removeScreen()` from FolderModel, also
         consider the activity corresponding to the FolderModel, which is the
         current activity when the FolderModel is initialized.
      2. Provide a migrator for the old configuration entries because an extra
         record is added.
      
      BUG: 447558
      7f09fb16
  5. 16 Jan, 2022 2 commits
  6. 15 Jan, 2022 5 commits
  7. 14 Jan, 2022 14 commits
  8. 13 Jan, 2022 4 commits
  9. 12 Jan, 2022 1 commit