Hi, I'm the author of the Velours Plasma theme, on kde-look et. al. since 2013. I have spent a lot of time working on it and particularly its icons and I would be upset if that all went to waste, and I feel the Breeze icons simply would not work with it at all, and that goes for a lot of other third-party themes, which would all basically be limited to "alternate panel background" from then on.
I had neglected to update my theme for some years and in the last two months I've found some time to work on it and especially on its icons, since in the meantime Plasma had started to use many many more. What I have found to be the most problematic as a third-party theme author is that the documentation has not been updated consistently, many files/elements are missing or have had their usage and semantics changed, so I end up having to dig down in qml files and sometimes even cpp files from Bluedevil and the likes to figure out where an icon comes from and how to provide it in my theme. The problem is not that I can't get plasmashell to pick up my icons, that is very reliable and logical; most of the time the problem is that there's simply no way to tell what file name and element id is actually being queried.
I think there could be better solutions than outright removing the possibility for themes to provide icons:
--debug-icons-source
which would cause the icon loader to print out the query and the actual resolved source of its results (and maybe the context from which it was requested?), and properly document that flag of course. This would make it easier for theme authors to figure out what they have to provide without even needing programming skills.If all else fails, couldn't the icons just be a user setting in the desktop theme kcm?
obno sim (fa343ce5) at 04 May 15:29
Text in the body of notifications is displayed in a TextArea without a background (I'm guessing to allow text selection).
This causes an issue in themes that expect text in textareas to be a different color than ordinary labels; the notification text can end up unreadable.
I'm using my own theme as an example to reproduce the issue:
https://gitlab.com/obnosim/velours/-/blob/plasma5/colors#L31
Plasma picks Colors:View:ForegroundNormal
(here, black) for textareas and Colors:Window:ForegroundNormal
(here, white) for other labels.
I'm very much a beginner with regards to QtQuick and Plasma development, so it's quite possible that this is not the right solution.
obno sim (c3bebbe2) at 01 May 21:38
Set notification text color explicitly since background is removed
obno sim (50d99213) at 19 Apr 20:31
obno sim (6154af0b) at 17 Apr 17:57
Improve description of update.svg#update-none
I noticed some tray icons were not documented after spending some time looking for them in qml/cpp files.
input.svg
(whole file undocumented)redshift.svg
(whole file undocumented)update.svg
(whole file undocumented)preferences.svg
(bluetooth
had since been forked into bluetooth-activated
for 'connected' state, perhaps a new addition that was not documented at the time)I also fixed some random ö
where a plain o
was expected.
(Link the issues related to this merge request here)
git clone https://invent.kde.org/documentation/develop-kde-org.git
cd develop-kde-org
git mr 287
hugo server
(If this merge request closes any issue in this repository, use Closes #<mr number>
here, for example: Closes #3
)
obno sim (18786b83) at 17 Apr 03:50
Add some undocumented icons (bluetooth enabled, input, night color)
obno sim (9f413407) at 28 Jul 17:58
@bcooksley It was indeed set to the private email address. @ngraham I have changed it now.
Yeah, I was about to undo it yesterday but I got distracted.
I have now removed that part.
obno sim (c78686c7) at 21 Jun 21:54
Update Panel.qml
Since Plasma 5.22, Plasma panels fail to use the correct edge prefix. This change makes it so the prefix is actually assigned to something at the end of the switch case.
Tested locally using a theme that has prefixes for all edges.
obno sim (5a195166) at 19 Jun 03:46
actual fix
obno sim (1964684b) at 19 Jun 03:25
Fix edge prefix detection