1. 12 Jul, 2020 1 commit
    • Thomas Baumgart's avatar
      Harmonize display of closed accounts in home view · 6e078d95
      Thomas Baumgart authored
      Different sections of the home view displayed closed accounts depending
      of the "Show all accounts" and "Do not show closed accounts"
      differently. The handling has been harmonized such that closed accounts
      will be displayed in all sections alike either if "Show all accounts" is
      active or "Don't show closed accounts" is inactive.
      
      Closed accounts will also be shown in strike-through so that they can
      easily be identified as closed.
      
      BUG: 424098
      FIXED-IN: 5.1.1
      6e078d95
  2. 29 May, 2020 1 commit
  3. 27 May, 2020 1 commit
    • Dawid Wróbel's avatar
      Continue refactoring for saner Icon names · f8b1b554
      Dawid Wróbel authored
      - remove "View" prefix from icon names
      - remove duplicate icons
      - add plural/singular icon names where applicable
      - rename icons where applicable (Transfer -> Transaction, etc.)
      f8b1b554
  4. 13 May, 2020 2 commits
    • Dawid Wróbel's avatar
      Use saner Icon names. · c80ea8bc
      Dawid Wróbel authored
      Icon enum members should be named after the context in which they are
      actually used in, not after the theme icon names arbitrarily chosen
      to represent them.
      c80ea8bc
    • Dawid Wróbel's avatar
      Use saner Icon names. · 7e96fd31
      Dawid Wróbel authored
      Icon enum members should be named after the context in which they are
      actually used in, not after the theme icon names arbitrarily chosen
      to represent them.
      7e96fd31
  5. 01 May, 2020 2 commits
  6. 24 Jan, 2020 2 commits
  7. 18 Jun, 2019 1 commit
  8. 20 Apr, 2019 1 commit
  9. 31 Mar, 2019 1 commit
    • Thomas Baumgart's avatar
      Forecast (history) has no effect on home view · 66157f2d
      Thomas Baumgart authored
      The home view section selector in the settings has an entry "Forecast
      (history)" which does not show any effect on screen when changed. Since
      it is currently not used, it is removed from the settings list. It will
      be kept in source code (marked as unused) since the order of the entries
      and their index must not change to maintain backward compatibility of
      the settings.
      
      BUG: 406074
      FIXED-IN: 5.0.4
      66157f2d
  10. 25 Mar, 2019 1 commit
  11. 26 Feb, 2019 1 commit
  12. 09 Feb, 2019 1 commit
  13. 05 Feb, 2019 1 commit
  14. 07 Oct, 2018 1 commit
  15. 08 Sep, 2018 1 commit
  16. 26 Aug, 2018 1 commit
    • Thomas Baumgart's avatar
      Speedup loading of home page · 14760ff8
      Thomas Baumgart authored
      Whenever an account entry was shown on the home page, the application
      iterated twice over all transactions to collect some statistics
      information.
      
      The relevant information is now collected once which improves
      performance drastically.
      14760ff8
  17. 09 Jul, 2018 1 commit
    • Łukasz Wojniłowicz's avatar
      Move reports drawing to reports view plugin · ac6976ab
      Łukasz Wojniłowicz authored
      This patch completes encapsulation of reporting features in KMyMoney. If a report is needed then it should be returned as:
      1) QWidget
      It will then be possible to show report outside of KReportsView and handle it completely inside KReportsView. This approach will allow us embedding any report anywhere with configuration controls built in a report.
      
      2) QString
      Some reports aren't graphical charts, so they need textual representation. Disadvantage of this approach is that chart cannot be handled inside KReportsView.
      
      Differential Revision: https://phabricator.kde.org/D13687
      ac6976ab
  18. 25 Jun, 2018 1 commit
    • Łukasz Wojniłowicz's avatar
      Prepare for XML storage separation · b7c44b7f
      Łukasz Wojniłowicz authored
      Goal of this patch is to facilitate separation of XML saving and reading methods to XML storage plugin by:
      1) adding new constructor for MyMoneyObjects
      
      The new constructor accepts id, so an MyMoney object will be created in XML storage plugin at the spot and not by a copy from another object. That's one constructor more for every MyMoneyObject, but there will be one constructor (the one with QDomElement) less after complete encapsulation of XML support in KMyMoney
      
      2) moving all remaining enums to mymoneyenums
      
      Some enums were changed to enum class, so type safety is enhanced a little bit.
      
      Differential Revision: https://phabricator.kde.org/D13581
      b7c44b7f
  19. 11 Jun, 2018 1 commit
  20. 10 Jun, 2018 1 commit
    • Łukasz Wojniłowicz's avatar
      Refactor file menu · bfa516d0
      Łukasz Wojniłowicz authored
      The purpose of this patch is to make file opening transparent. Changes:
      1) no wild attaching and detaching storage
      
      That was cause of a memory leak. Now a storage is created and attached only after successful opening of a file.
      
      2) new KMyMoneyApp::Private::fileAction
      
      It's central place for gathering all actions, app needs to undertake after a change in load state of a file.
      
      3) user can choose to save newly created file as sql
      
      Previously only xml was possible. Now user can even choose to not save it at all, which makes app independent from any storage plugin.
      
      4) app doesn't crash if no storage plugin is loaded
      
      5) no unnecessary update of actions which depend on load state of file
      
      Differential Revision: https://phabricator.kde.org/D13408
      bfa516d0
  21. 05 Jun, 2018 1 commit
  22. 03 Jun, 2018 1 commit
  23. 19 May, 2018 1 commit
    • Łukasz Wojniłowicz's avatar
      Refactor MyMoneyException class · 284a0331
      Łukasz Wojniłowicz authored
      MyMoneyException changes in following way:
      1) Untranslated exceptions, as normal user doesn't need to understand
      exceptions, only developers do,
      2) Tidied up catching phrase, so it's always catched by const reference,
      3) no d-pointer (there should be no cascade header inclusion) and
      reduced implementation to only what() method,
      4) we use code from standard library, which implements what() method, so
      we have less to compile,
      5) MyMoneyException constructor is inlined, but it should be short,
      because of the use of POD types only,
      6) two defines to throw an exception (explanation below).
      
      mymoneyexception.h contains header for std::runtime_error and two
      defines for customizing exception messages.
      First define, MYMONEYEXCEPTION constructs the message roughly in the
      following way:
      1) construct QString from __LINE__, which is int,
      2) construct QString from __FILE__, which is const char *,
      3) take exception message, only QStrings allowed,
      4) construct QString from the three strings above,
      5) construct const char * from QString, for which std::runtime_error has
      a constructor.
      
      As one can see, there is lot of effort to throw an exception, so there
      MYMONEYEXCEPTION_CSTRING has been introduced, to avoid all above
      mentioned memory allocations.
      
      Differential Revision: https://phabricator.kde.org/D12808
      284a0331
  24. 12 May, 2018 1 commit
  25. 29 Apr, 2018 1 commit
  26. 31 Mar, 2018 1 commit
  27. 29 Mar, 2018 1 commit
    • Łukasz Wojniłowicz's avatar
      Redesign signals system for views · b1dcf961
      Łukasz Wojniłowicz authored
      Current system has many types of signals for views, which isn't plugin friendly. New system has only three signals and three corresponding methods for interacting with views:
      1) selectByObject - for all signals that need MyMoneyObject only
      2) selectByVariant - for all non-standard signals, which cannot be easily converted to MyMoneyObject
      3) customActionRequested - for signaling some event, e.g. printing
      
      New system, besides object, requires to specify intent of the signal. This comes in handy at synchronizing accounts between investment and ledgers view.
      
      There is no more setDefaultFocus(), refresh() and updateActions(const MyMoneyObject&) because they were be replaced by above mentioned signals/slots and the interaction with views is thus more coherent.
      
      Differential Revision: https://phabricator.kde.org/D11720
      b1dcf961
  28. 24 Mar, 2018 1 commit
  29. 12 Mar, 2018 1 commit
    • Marc Hübner's avatar
      display reconciliation date on homepage · 68ac2fe9
      Marc Hübner authored and Thomas Baumgart's avatar Thomas Baumgart committed
      Summary: this patch adds the possibility to have the corrresponding reconciliation date displayed alongside each account on the home page. This is optional and can be enabled or disabled via a setting in the config dialog.
      
      Reviewers: #kmymoney, tbaumgart, wojnilowicz
      
      Reviewed By: #kmymoney, tbaumgart, wojnilowicz
      
      Subscribers: wojnilowicz, ostroffjh, tbaumgart
      
      Tags: #kmymoney
      
      Differential Revision: https://phabricator.kde.org/D10001
      68ac2fe9
  30. 18 Feb, 2018 1 commit
    • Thomas Baumgart's avatar
      Moved settings into their own library · e2448f62
      Thomas Baumgart authored
      Summary:
      Besides the move which really allows to have singleton throughout all
      shared objects and libraries of the application, I moved all additional
      settings function into the KMyMoneySettings object. This allows to
      remove the KMyMoneyGlobalSettings class completely.
      
      Compiling this in an existing build directory may cause trouble as some
      old generated files are left behind and might be used instead of new
      ones. You have been warned.
      
      Reviewers: wojnilowicz
      
      Differential Revision: https://phabricator.kde.org/D10161
      e2448f62
  31. 13 Feb, 2018 1 commit
    • Heiko Becker's avatar
      Fix build with QtWebEngine · 294433ab
      Heiko Becker authored
      Summary:
      Pull in <config-kmymoney.h>, which has the #define ENABLE_WEBENGINE,
      otherwise the build fails with "khomeview_p.h:45:10: fatal error:
      KWebView: No such file or directory".
      Additionally fix another build error and access m_currentPrinter via
      the d pointer.
      
      Test Plan: Builds with -DENABLE_WEBENGINE:BOOL=TRUE
      
      Reviewers: #kmymoney, wojnilowicz
      
      Differential Revision: https://phabricator.kde.org/D10479
      294433ab
  32. 15 Jan, 2018 1 commit
  33. 28 Dec, 2017 1 commit