KMyMoney issueshttps://invent.kde.org/office/kmymoney/-/issues2023-10-01T15:14:13Zhttps://invent.kde.org/office/kmymoney/-/issues/61New Ledger issues2023-10-01T15:14:13ZThomas BaumgartNew Ledger issuesThis is a collection of issues regarding the new ledger and used to track their dev/fix status.
**Open**:
* [ ] If an investment transaction is imported and refers to a security which already exists for that account but is closed, if y...This is a collection of issues regarding the new ledger and used to track their dev/fix status.
**Open**:
* [ ] If an investment transaction is imported and refers to a security which already exists for that account but is closed, if you edit the transaction, the security is not shown, and you cannot select it (or anything else) nor can you change the type of transaction, but there is no feedback at all as to what the problem is. Even the "delete" action is disabled. (This appears true for very old transactions, but they were probably originally imported, so I don't know if importing is really important or not.)
* [ ] Excessive scrolling (or focus switch) I'll try to attach a screen capture. For many simple actions, the ledger scrolls to someplace (I'd call totally random or at least not discernibly relevant to the transaction being acted on) and then scrolls back to the starting point. For example, just clicking on the Imported icon, or clicking the status column (changing from blank to C to R). Maybe fixed with https://invent.kde.org/office/kmymoney/-/commit/561ec8221ed83c0a291f0c0f34a2d6b4ef155914. Please double check ( @tbaumgart 2023-07-02)\
Still happens with 5.1.80- 967375e15 (@jostroff 2023-07-04)
**Unclear**:
* [ ] Right click -\> Move Transaction To doesn't work, I can select an (expense) account to move to but it does nothing ( @wrobelda)
@tbaumgart: I am unable to duplicate this. The categories (as in expense account) are not provided to be selected for me. Moving between accounts works as expected. Please provide more details.
**WIP**:
* [ ] When I match and accept two transactions, one maunally entered and the other imported, it always uses the imported date, no matter which order I select the transactions. See !177
ostroffjh: 2022-12-03 Sorry, this is still not right. (Version 5.1.80- b35fc5435). I have two transactions, one dated 11/25 with a category set (manunally entered,) the other 11/26 with no category (imported). Matching, I either get 11/25 with no category, or 11/26 with the category. It seems one of those two fields is being taken from the wrong transaction. I have screenshots available if needed. ostroffjh: 2023-07-20 I'm ready to accept this as done. The current state may not be perfectly optimal for my use case, but it's acceptable for me, and I don't know that there is anything that would be better for me without messing up the matching done on importing.
**Done**:
* [x] Transaction selection is lost when the post date of a transaction is changed.
* [x] In a credit card account, the online balance is displayed as a negative, although the balance column is all positive numbers. It's not necessarily wrong, but it's certainly a bit disconcerting.
* [x] When modifying a transaction of an imported transaction the imported status should be removed.
* [x] When a transaction is selected, hitting Enter has no effect. It's expected to start editing the transaction.
* [x] On imported or manually entered transactions, the category stays blank, even though the payee has a default category specified.
<details>
<summary>Click to expand</summary>
I was able to import a transaction and the assigned default was assigned. So I did not change anything for import.
</details>
* [x] Display of current and cleared balance is missing (used to be displayed below ledger).
* [x] Selecting a transaction at the bottom or top of the ledger which is only partially visible ends up selecting the following or prior one after scrolling the originally selected transaction so that it is completely visible.
* [x] At the bottom of the ledger "Last reconciliation: 4/25/9222(I18N_ARGUMENT_MISSING)." is displayed.
* [x] The Status dropdown is not highlighted in any way when it has the focus.
<details>
<summary>Click to expand</summary>
@tbaumgart
: I am currently unable to duplicate this using Breeze
</details>
* [x] "Show all accounts" does not work for Equities tab of Investments View
<details>
<summary>I cannot find any way to view (to reopen) a closed security in an investment account.</summary></details>
* [x] Problem with Securities Dropdown when creating transaction.
<details>
<summary>
In an Investment Account "Add Shares" transaction, the dropdown for the security defaults to a random security (I think it might be the last securite referenced in any edited transaction, I think, but not certain, (it should start blank,) the dropdown list is not sorted, and it includes closed accounts, which are shown crossed out when the dropdown is expanded, but not when it is collapsed, and "Enter" is not disabled for the closed security. (I did not actually try to save the transaction.) It is also not possible to type in the text field as used to be possible in the old ledger. (~~I don't know if this is still a WIP, or~~ a new bug.)
</summary></details>
* [x] Ledger and Investment Views are not synced.
<details>
<summary>When an account is open and being viewed in the Ledger, switching to the Investments view should also select that same account.</summary></details>
* [x] In the Ledger View, when there are no open tabs, the text says there are no accounts.
<details>
<summary>The text should be different when there ARE accounts - perhaps "No account has been selected" and not "...no account exist..." (which should be "no accounts exist" or "no account exists")</summary></details>
* [x] Another i18n issue
<details>
<summary>Console output shows multiple 'kf.i18n: "0 instead of 2 arguments to message {Value are presented ...} supplied before conversion."' and 'kf.i18n: "0 instead of 1 arguments to message {Values are presented...} supplied before conversion."' but I see no problem in the display. I made necessary changes. They have been checked to solve the problem.</summary></details>
* [x] Date widget no longer has "magic" to roll day past month boundary with +/- on number pad. (I don't know if this is even possible, but would be very useful.)
* [x] If multiple transactions (with the same status) are selected, clicking on the status column correctly changes the status of all those transactions, but then leave only the first of them selected. It makes sense for all the transactions to remain selected.
* [x] Reconciliation report (not really ledger) displays entry date, not transaction date for outstanding transactions.
* [x] When deleting unused payees, KMM still asks for what payee to replace them with in any transactions. If they are unused, there shouldn't be any transactions using them.
That seems to happen only, if at least one of the selected payees still references a transaction/scheduled transaction or loan account. Please clarify. This no longer occurs. I don't know if it was an unintended consequence of some other change. My process for this is to use the dropdown to select unused payees, select them all, and delete them. I don't know how any of them could still refer to a transaction. I'll move back to active it it happens again
* [x] I don't know when this started, but when I accept editing a transaction, that transaction does not retain the focus. The last transaction is highlighted, but I really can't tell where the focus is, as I haven't found the right keystrokes to select any transaction. I have to click on a transaction to continue working.
This no longer occurs.
* [x] Not ledger, Home Page account list does not use strike-through for names of closed accounts displayed (if show all accounts is active)
This is a problem of the QTextBrowser class (in Qt5 at least) which does not support strike-through.
* [x] There is a problem with the reconciliation notifications. The most recent reconciliation date is shown below the ledger, and it present with the value in the reconciliationHistory pair, but it is not showing up as the bar in the ledger. Earlier reconciliations do show up, just not the most recent or in some cases the two most recent.
* [x] If I double-click a transaction in the ledger, it opens the transaction, and the DAY portion of the date (MM/DD/YYYY) is highlighted. However, it does NOT have the focus, as typing a digit or the up/down arrow has no effect. (I don't actually know what does at this point, possibly nothing?) If I hit TAB, the focus shifts to the MONTH portion of the date. If I TAB to the next field, and SHIFT-TAB back to the date, the YEAR has the focus. Should not the DAY always get the focus when tabbing into the date field?
* [x] ostroffjh - I'm happy for date behavior consistency across the app, but I would strongly prefer that tabbing into a date field from either direction always chooses the day portion (or by user choice, if this is an option) as that seems the most common item to change. Wasn't this recently the subject of a bug filed?
* [x] Changing the status of a transaction does not stick when saving the changes. In the edit form (ledger lens?) the status always shows "not marked" even if the transaction is marked C or R. This is a recent change in behavior. \[As of 9 August this seems to work correctly. I'll wait a few days before moving this to completed. Moved to Done 13 August\]. It seems to only happen in Investment accounts.
* [x] Right clicking a transaction in an investment account, and select "GoTo" the brokerage account puts focus on the same transaction. However, if you do the same in the brokerage account and go to the investment account, the focus is on the newest transaction, not the selected one from the brokerage account.
* [x] In the old ledger, when displaying an investment account, the total investment value is shown at the bottom right. In the new ledger, the values at the bottom are the cash values, and thus always 0 for investment account. In addition, since that line shows the last reconciliation date at the left, it is potentially confusing that the Cleared and Balance amounts are for the account, and not related to the reconciliation at all.
* [x] If you edit an investment transaction which has a security which has been closed, the security shows blank, so you can't even edit other fields. It should be OK to edit a transaction for a closed security - perhaps just not allowing any change of the number of shares. It should be fine to change price or memo.
* [x] Keyboard shortcut conflict for Ctl-Shift-A. This is always used for Show All Accounts. However, it is also used for "Go To Account" (where "Account" is the name of a Category or other account.) It gets set if you right click a transaction in the ledger, but remains set even if you leave the ledger. Outside than Ledger, it doesn't make sense to have a keyboard shortcut to go to an account where which account depends on what transaction you last viewed. In the Ledger, can we think of an alternate shortcut, or do we really need a keyboard shortcut for that?
* [x] Toggling "Hide reconciled" in View has no effect until after restarting the app.
* [x] The menu item Transaction -\> New transaction is not working ( @smithey)
* [x] When editing a transaction, in Tags field, trying to type to complete (using 'S' letter here) will refocus to another transaction and effectively lock-out any other keyboard presses. Clicking "Cancel" on the transaction — which is still in edit mode — restores the ledger back to normal.
* [x] In 5.1, if you select multiple transactions, the sum of their values is shown at the lower right. Is it possible to bring back this functionality, possibly even including the number of selected transactions? ( @ostroffjh)
* [x] In Payees View, if I select a Payee with transaction, then change the dropdown to "Used" there is no Payee selected, but the transactions from the previously selected (supposedly unused) Payee are still displayed until I select a different payee, although it is not possible to select any of them. ( @ostroffjh)
* [x] Double click on a scheduled transaction should open it in edit mode (source: [KMyMoney Forum](https://forum.kde.org/posting.php?mode=reply&f=69&t=176851))
* [x] It should **not** be possible to reconcile in 1 click. If so (and filters are "on"), the transaction "disappears" in the hidden list, and it's very difficult to find it back. Click should toggle between "Cleared" and "Empty" for example (source: [KMyMoney Forum](https://forum.kde.org/posting.php?mode=reply&f=69&t=176851))
* [x] After adding new transaction for any asset/liability account all future transactions have a value of zero
* [x] In Payees View, I select "Unused" and two payees show several transactions. However, all these transactions are imported, and KMM created the payees from the OFX payee. The transactions are unbalanced - without an assigned category. ( @ostroffjh)
* [x] Home View, Assets and Liabilities seems to use single table. Is using a separate table for each section feasible? If so, it would eliminate using two lines for a row when only the liability or asset account needs it, not both. This is solely an aesthetic issue.
This is handled in #16 and #67
* [x] (Not sure if this is a bug or just a wishlist) In the ledger for Investment accounts, the Balance column shows the n umber of shares of the security involved in that transaction, but it always shows 2 decimal places, even if that security is set to use more. The actual balance is calculated correctly, as seen in the Investments View, but that only shows the current balance.
* [x] In Investment Accounts, the up and down arrows do not change the selection of transaction. Sometimes if I click on a transaction, one tap of up or down arrow will work, but after that, they are ignored. Works OK in cash and checking accounts. Not tested in other types. Fixed with https://invent.kde.org/office/kmymoney/-/commit/561ec8221ed83c0a291f0c0f34a2d6b4ef155914
* [x] I've had many cases where in the ledger for an Investment Account, the tab label changes from the name of the account to the name of one of the securities held in that account. It seems to be when editing a transaction for that security. This might only happen if there is a filter on the ledger, such as showing imported or not reconciled transactions. The main trigger seems to be importing (OFX direct) where the tab label becomes the security from the last imported transaction. (updated @jostroff 2023-07-04) Fixed with https://invent.kde.org/office/kmymoney/-/commit/a29dfd559721fd782684cee1160d4746c21ae2ff
* [x] Editing multiple transactions needs to be implemented.Thomas BaumgartThomas Baumgarthttps://invent.kde.org/office/kmymoney/-/issues/31Revisit object selection method, action handling and menu generation2021-05-02T11:19:44ZThomas BaumgartRevisit object selection method, action handling and menu generationThe enabled actions in a view are primarily based on the following criteria:
- global status (e.g. file open or closed, file modified)
- global specific object attributes (e.g. online mapping)
- the view itself
- the selected objects in...The enabled actions in a view are primarily based on the following criteria:
- global status (e.g. file open or closed, file modified)
- global specific object attributes (e.g. online mapping)
- the view itself
- the selected objects in the view
Currently, multiple methods exist to select an object (selectByObject, selectByVariant). At the same time, the dynamic interaction with the actions is implemented in various different inconsistent ways throughout the application. Another topic which is related in that context is the handling of (context) menus: most are available via the KXMLGuiClient object and the layout is provided using an .rc file while others are generated dynamically in code.
The idea is to consolidate the selection into a single, general mechanism which is used by all parts of the application. The action initialization and action control logic as well as the menu generation logic shall be unified throughout the views and plugins and the menus shall all be made available via the .rc files.
As analysis continues, more items will be added here to keep track of things.
- Analysis
- [x] Identify parts that need changes in respect to menu handling
- [x] Identify parts that need changes in respect to action handling
- Modifications
- [ ] Provide .rc menus for all menus
- [x] KBudgetView context menu
- [ ] KCurrencyEditDlg context menu
- [ ] KMyMoneyPriceDlg context menu
- [ ] KReportsView context menu
- [x] KForecastView context menu
- [x] KOnlineJobOutboxView context menu
- [ ] ~~Provide generic mechanism to create/destroy action objects~~ (abandoned for now)
- [x] Provide general selection mechanism
- [x] Provide general mechanism to update action availabilityThomas BaumgartThomas Baumgarthttps://invent.kde.org/office/kmymoney/-/issues/26Consider removing support for Finance::Quote2021-02-16T21:36:15ZDawid WrobelConsider removing support for Finance::Quote1. There are several open APIs available that provide quotes and has been doing it for many years now. This wasn't the case when Finance::Quote was popular, and obtaining quotes required scraping website's html. It's a personal opinion, ...1. There are several open APIs available that provide quotes and has been doing it for many years now. This wasn't the case when Finance::Quote was popular, and obtaining quotes required scraping website's html. It's a personal opinion, but I consider Finance::Quote redundant by now.
2. Newbie users get confused by its presence in the Security Wizard right next to `Online Source` drop-down list selector: ![Screen_Shot_2020-06-30_at_1.14.36_PM](/uploads/27a51c57f65729a69d6578a195177936/Screen_Shot_2020-06-30_at_1.14.36_PM.png)
3. It requires manual installation of a Perl distribution + cpan module on macOS platform ([1]) and on Windows, since we don't ship it with the binary package. I don't think any of the popular Linux distributions add it as a default dependency, either.
4. It was reported it doesn't work properly ([macOS](https://bugs.kde.org/show_bug.cgi?id=423709), [linux](https://bugs.kde.org/show_bug.cgi?id=390549) – this one is most likely due to a missing perl module)
5. Adds complexity to the codebase
6. Its development [has mostly stalled](http://finance-quote.sourceforge.net), the maintainers don't respond to patch sign-off requests. From my anecdotal evidence, I tried to add support for Warsaw Stock Exchange quotes a few years back and never got a response.
7. While it provides many backends, I have personally tried to use a few (mainly Fidelity) that didn't work at all, because they were written to scrape the prices from old versions of the websites, when the prices weren't published via APIs.
8. Our built-in quotes support provides support for price only. Finance::Quote can provide many more values than just price, yet we ignore them and parse price only anyway:
```
void WebPriceQuote::slotParseQuote(const QString& _quotedata)
{
(...)
QRegularExpression webIDRegExp(d->m_source.m_webID);
QRegularExpression dateRegExp(d->m_source.m_date);
QRegularExpression priceRegExp(d->m_source.m_price);
(...)
```
9. Interestingly, even our manual says that
> Future currency rate updates will not use Finance::Quote, and
will always use the native retrieval method
[1] while macOS ships with Perl, Apple warns against installing own cpan modules or otherwise modifying it. For that reason, sane developers will use a separate perl distribution provided e.g. by HomeBrew. Moreover, macOS 10.15 no longer ships any of the 3rd party frameworks (python, perl, ruby) it previously provided.