KMyMoney merge requestshttps://invent.kde.org/office/kmymoney/-/merge_requests2020-05-29T14:17:03Zhttps://invent.kde.org/office/kmymoney/-/merge_requests/8Partial icon improvements2020-05-29T14:17:03ZDawid WrobelPartial icon improvementsThese are partial improvements ready for merging with 5.0 branch. The outstanding work depends on VDG team's delivery of missing breeze icons (https://bugs.kde.org/show_bug.cgi?id=421382).
This change:
1. Simplifies icon mapping co...These are partial improvements ready for merging with 5.0 branch. The outstanding work depends on VDG team's delivery of missing breeze icons (https://bugs.kde.org/show_bug.cgi?id=421382).
This change:
1. Simplifies icon mapping code and prepares for upcoming breeze theme delivery:
- Breeze is the mandatory theme on macOS and Windows, so make it explicit
- setThemeName() is only supported on non macOS/Windows platforms
- Add a single iconMappings container for all Icons::Icon enums to theme mappings
- remove the KDE icons generalization – replace it with distinct Oxygen and Breeze mappings.
- simplify the convoluted setIconThemeNames() mapping logic
2. Continues the refactoring of icon names to reflect the context of usage.
3. Fixes some old filename typos.
4. Replaces the explicit QIcon::fromTheme() leftover calls with Icons::get() wrapper.Version 5.1.0Thomas BaumgartThomas Baumgarthttps://invent.kde.org/office/kmymoney/-/merge_requests/2WIP: Resolve "Improve icons consistency"2020-05-25T06:16:26ZDawid WrobelWIP: Resolve "Improve icons consistency"Closes #2Closes #2Version 5.1.0https://invent.kde.org/office/kmymoney/-/merge_requests/34Resolve "Improve icons consistency"2021-07-25T15:58:25ZDawid WrobelResolve "Improve icons consistency"Closes #2
This is a rather big change, but not so much code-wise. Apart from a fairly vanilla icon naming refactoring, a few bigger changes were introduced:
- icons are now delivered as a binary resource, embedded into icons library, w...Closes #2
This is a rather big change, but not so much code-wise. Apart from a fairly vanilla icon naming refactoring, a few bigger changes were introduced:
- icons are now delivered as a binary resource, embedded into icons library, which relieves us from the sourcery of locating the icons path in the folder structure.
- This is currently limited to Linux/BSD, since KIconTheme + craft providee a complete binary package for for Win/macOS builds anyway.
- It does, however, work on macOS/Win and, depending on our future packaging decisions, can also be enabled for these platforms.
- KIconTheme + craft also do not support dark icon theme at the moment, so I am leaning towards distributing the icons ourselves for these platforms as well
- it also creates a package that is significantly smaller in size, since we only provide icons we actually need and use
- the .qrc resource file is generated on the fly by cmake
- a script is provided that sync all of the required (used in code) icons from breeze repository on demand
- all the icon overlaying code was removed; all of the variants of the icons are now provided, except for ones denoting a "reconciled" state, which will be provided later on.
- I added an additional "Online" column to Accounts view, to denote accounts with Online mapping configured.
- Icons preference panel is now disabled on Win/macOS, since there was never a choice offered anyway.
- a system palette change event is captured to dynamically switch between light and dark icons – however it is only supported on macOS/Unix right now. Support for Windows will follow at a later time, while BSD/Linux is supported only if the icon theme is set by the system and not explicitly overridden by a user in Settings.
Few icons are still missing, but will be delivered by the VDG team soon. Some others could see some refreshing, which will hopefully also happen sometime in the future. The KMyMoney icon itself will see some further refining, too.
Sample HiDPI macOS screenshots:
![Screen_Shot_2020-10-06_at_1.15.25_AM](/uploads/aca173b36ffd1e0379f7707107761e4d/Screen_Shot_2020-10-06_at_1.15.25_AM.png)
![Screen_Shot_2020-10-06_at_1.13.45_AM](/uploads/8a0cefbdb9fee31c45884305b18b64af/Screen_Shot_2020-10-06_at_1.13.45_AM.png)Version 5.1.2Thomas BaumgartThomas Baumgarthttps://invent.kde.org/office/kmymoney/-/merge_requests/33Draft: Resolve "Improve icons consistency"2020-10-06T04:45:17ZDawid WrobelDraft: Resolve "Improve icons consistency"Closes #2Closes #2Version 5.1.2https://invent.kde.org/office/kmymoney/-/merge_requests/26Resolve "Modernize splash screen or remove it altogether"2020-09-04T17:36:28ZDawid WrobelResolve "Modernize splash screen or remove it altogether"@tbaumgart I removed the splash screen and optimized the startup code to show the UI as early as possible. Note that I also reverted [your fix](a9a99469f5a403f4ad72c4c0b8c5e012571bb4f9) for bug [407902](https://bugs.kde.org/show_bug.cgi?...@tbaumgart I removed the splash screen and optimized the startup code to show the UI as early as possible. Note that I also reverted [your fix](a9a99469f5a403f4ad72c4c0b8c5e012571bb4f9) for bug [407902](https://bugs.kde.org/show_bug.cgi?id=407902).
I tested with ENABLE_WEBENGINE=ON and it doesn't crash for me, but a) I am testing on macOS b) with a newer version (5.15) and the [upstream bug](https://bugreports.qt.io/browse/QTBUG-61213) was already fixed in 5.9.4.
I think it's safe to assume this is OK, given that most recent distros ship at least QT 5.12 LTS.
Closes #4Version 5.1.2https://invent.kde.org/office/kmymoney/-/merge_requests/25WIP: Resolve "Modernize splash screen or remove it altogether"2020-07-02T23:27:39ZDawid WrobelWIP: Resolve "Modernize splash screen or remove it altogether"Closes #4Closes #4Version 5.1.2