Skip to content

Resolve "QtWebkit v. QtWebEngine discussion"

Dawid Wrobel requested to merge work/37-qtwebkit-v-qtwebengine-discussion into master

Adapt Home View to the limited HTML/CSS subset

Qt Rich Text limitations:

  • color names are not recognized, use hex values
  • 'em' relative unit is not supported, use approx. px values
  • div styling is very limited, wrap reports in tables instead and drop the redundant "Your Financial Summary" header
  • repetition property on background image is not supported, so drop the "flourish" graphic altogether
  • images are not scaled to the td size, so the net-worth graph needs to be resized to accommodate the HiDPI displays
  • CSS comments cannot contain HTML tags: https://bugreports.qt.io/browse/QTBUG-98045

Also fix some pre-existing issues:

  • columns were at times not using the full 100% of width
  • reduced the size of call padding
  • make the Cash Flow Status columns span to show three equal columns

Additional improvements:

  • add a dynamically-generated "negativetext" class to KMyMoneyUtils::variableCSS() and use where appropriate
  • make the "Overdue Payments" background consistent with other sections
  • format the CSS
  • use Download icon in Assets/Liabilities summary. This aligns it with Accounts summary.
  • change pixmaps size to 8 x 8
  • move "Skip" and "Next" buttons to their own columns
  • Rename "Payments" to "Scheduled Payments" for clarity
  • shorten column names to avoid excessive table width
  • keep minimal column width where appropriate
  • avoid wrapping of dates and amounts
  • use class="right" instead align="right" where applicable

Adapt Welcome View to the limited HTML/CSS subset

  • remove styling altogether, simplify everything
  • remove old images, use symbolic icons instead
  • remove "Go to My Financial Summary", as well as corresponding "Show KMyMoney welcome page" from Home view, which shouldn't be a thing from UX perspective: if a book file is open, showing "Welcome" page can be confusing and really pointless, as there isn't anything there that is otherwise not accessible from the menus (mostly Help menu). Likewise, when no book file is open, "Go to My Financial Summary" has no effect and, again, will be confusing.
  • use the same background pattern as in Home View

Adapt Reports to the limited HTML/CSS subset

  • inline the CSS
  • center the tables
  • use relative font sizes where possible
  • avoid wrapping of amounts and headers

TODO:

  • fix disappearing QTextBrowser content after clicking on a link
  • fix external links not working
  • make all links on Welcome Page separate actions
  • fix reports
  • fix reconciliation report
  • restore zooming functionality (KMyMoneySettings::zoomFactor) (done thanks to @tbaumgart)
  • void KReportTab::print()
  • slotAdjustScrollPos (remembering Home position, see https://bugs.kde.org/show_bug.cgi?id=403955)
  • what to do with existing, custom CSS files some users may have set up? these are removed on each startup and are not meant for user customization.

Screen_Shot_2021-11-06_at_11.44.49_AM Screen_Shot_2021-11-06_at_11.13.37_AM Screen_Shot_2021-11-06_at_11.15.21_AM Screen_Shot_2021-11-06_at_11.15.40_AM Screen_Shot_2021-11-06_at_11.15.48_AM Screen_Shot_2021-11-08_at_5.24.00_PM

Closes #37 (closed)

Edited by Dawid Wrobel

Merge request reports