GitLab

This doesn't so much actively search for things to delete. Instead it's
a required permission from the user to remove source directories (which
is similar to the remove-after-install option).

Right now this will only be used when trying to clone a git module and
the destination source directory already exists somehow, which has
happened for a lot of 1.14 early adopters due to old kde-baseapps
checkouts having a kate or konsole directory that conflict with where
kdesrc-build wants to put the current kate/konsole directories.

This commit makes the "module type" as determined from the
{repository,svn-server} options be the preferred method of determining
which scm tool to use.

This is required to allow nuking the source directory for old checkouts
in an upcoming commit (which was itself made an issue with the 1.14
release, that reorganized the on-disk layout, causing older kde-baseapps
checkouts with konsole/kate subdirs to conflict with the git
konsole/kate).

This commit makes the license/copyright information much more detailed
as recommended by Pino Toscano, who packages kdesrc-build for Debian.

As reported by rakuco on IRC.

makepath fails if it already exists, but that's not an error, we can proceed.

Laurent Montel reported an error that indicates a syntax error in the
git error handler for the kde: support. Even after extracting out the
error handler and forcing it to run Perl works just fine here, so it's
not a semantic issue either.

So instead, just use a plain 'ol Perl 5.0-style hash to figure out the
error message, no need to make it complicated.

In addition I added the stderr > /dev/null redirection that I forgot to
have in place before.

This should prevent the new-to-1.14 setup script from becoming the next
Debian lintian warning.

asciidoc was a nice start, but modifying the generated XML is not too
bad (and must be done to comply with KDE documentation guidelines
anyways).

So, remove the asciidoc and instead generate man pages from DocBook XML.

I've taken the liberty of using the more specific content tags but the
overall content should be approximately the same.

I probably should have done this a long time ago, but now kdesrc-build
has a man page (mostly to get rid of the 1 Debian lintian hit I saw for
1.13)

I haven't tied it into CMake yet because I'm tired, but it requires
asciidoc and the short story is:

$ asciidoc -d manpage -b docbook kdesrc-build.1.txt
$ xsltproc --nonet /usr/share/asciidoc/docbook-xsl/manpage.xsl
kdesrc-build.1.xml

Of course finding that damn XSL from CMake will be the problem in the
future but I can figure that out tomorrow if no other kind soul does
that for me.

Raphael Kubo da Costa noticed that his set-env in module-sets were no
longer working in master.

Turns out a simplification of the setOption method to allow accepting
more than one option did not properly handle the set-env option if that
option had already been processed. (kdesrc-build has to convert set-env
read from the rc file into a hash instead of just storing the value to
allow for duplicate set-env entries).

This is fixed by ensuring that if that processing step has apparently
already been completed, we don't try doing it again.

GIT_SILENT

The Coverity plugin interface was removed awhile ago and I've seen no
anguished screams since. I can only assume Coverity no longer uses
kdesrc-build for KDE code scanning (I am uncertain whether Coverity
still checks our code base at all).

As recommended by Pino Toscano.

I was also half-tempted to just force-exec the setup script if it's
available and there's no config, but there are some scenarios where it
might make sense to just download kdesrc-build and kick off a very quick
build from there (especially with the +xml-module syntax on the command
line).

Ask requested by dfaure, belatedly add a --no-tests option to disable
enabling tests *at CMake* time for that run. Delayed since I was going
to implement it after refactoring out each step into independent phases
but I haven't quite made it that far yet.

BUG:265275
FIXED-IN:1.14

Really this was mostly an excuse to document the new "include" feature.

The option can actually still be passed since kdesrc-build accepts
command-line options matching known global option names, but since
we default to removing old log directories there's no reason to add 40
different ways to enable this.

kdesrc-build uses multiple processes for its operation (even without
async mode), the way Perl works means its END {} handlers get called
even for the children.

The real way you'd normally see this is by doing ^C at the terminal, the
signal handler would manually run the exit routines and then the END {}
block would run the same routines.