Skip to content
GitLab
Projects
Groups
Snippets
Help
Loading...
Help
Help
Support
Community forum
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in
Toggle navigation
digiKam
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Service Desk
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Operations
Operations
Metrics
Incidents
Environments
Packages & Registries
Packages & Registries
Package Registry
Analytics
Analytics
CI / CD
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
Peter Becker
digiKam
Commits
0690d4db
Commit
0690d4db
authored
May 17, 2020
by
Maik Qualmann
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
better performance to add items to the completer
BUGS: 421646 FIXED-IN: 7.0.0
parent
bd71890f
Changes
4
Hide whitespace changes
Inline
Side-by-side
Showing
4 changed files
with
13 additions
and
2 deletions
+13
-2
NEWS
NEWS
+2
-1
core/libs/tags/widgets/tageditdlg.cpp
core/libs/tags/widgets/tageditdlg.cpp
+4
-1
core/libs/widgets/text/modelcompleter.cpp
core/libs/widgets/text/modelcompleter.cpp
+6
-0
core/libs/widgets/text/modelcompleter.h
core/libs/widgets/text/modelcompleter.h
+1
-0
No files found.
NEWS
View file @
0690d4db
...
...
@@ -741,4 +741,5 @@ BUGFIXES:
705 ==> 421559 - HEIC: Failed to open the data source: Too many open files (errno = 24).
706 ==> 421464 - XPkeywords not being updated.
707 ==> 421521 - Wrong EXIF photograph properties shown when there is no EXIF data at all.
708 ==>
708 ==> 421646 - Impossible to add new tag.
709 ==>
core/libs/tags/widgets/tageditdlg.cpp
View file @
0690d4db
...
...
@@ -161,6 +161,7 @@ TagEditDlg::TagEditDlg(QWidget* const parent, TAlbum* const album, bool create)
if
(
d
->
create
)
{
QStringList
tagPaths
;
AlbumList
tList
=
AlbumManager
::
instance
()
->
allTAlbums
();
for
(
AlbumList
::
const_iterator
it
=
tList
.
constBegin
()
;
it
!=
tList
.
constEnd
()
;
++
it
)
...
...
@@ -169,9 +170,11 @@ TagEditDlg::TagEditDlg(QWidget* const parent, TAlbum* const album, bool create)
if
(
tag
&&
!
tag
->
isInternalTag
())
{
d
->
titleEdit
->
completerModel
()
->
addItem
(
tag
->
tagPath
()
);
tagPaths
<<
tag
->
tagPath
(
);
}
}
d
->
titleEdit
->
completerModel
()
->
addItems
(
tagPaths
);
}
else
{
...
...
core/libs/widgets/text/modelcompleter.cpp
View file @
0690d4db
...
...
@@ -151,6 +151,12 @@ void ModelCompleter::addItem(const QString& item)
d
->
stringModel
->
sort
(
0
);
}
void
ModelCompleter
::
addItems
(
const
QStringList
&
items
)
{
d
->
stringModel
->
setStringList
(
items
);
d
->
stringModel
->
sort
(
0
);
}
QStringList
ModelCompleter
::
items
()
const
{
return
d
->
stringModel
->
stringList
();
...
...
core/libs/widgets/text/modelcompleter.h
View file @
0690d4db
...
...
@@ -60,6 +60,7 @@ public:
QAbstractItemModel
*
itemModel
()
const
;
void
addItem
(
const
QString
&
item
);
void
addItems
(
const
QStringList
&
items
);
QStringList
items
()
const
;
Q_SIGNALS:
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
.
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment