const'ify variable + initialize variable in headers etc.

autotests/calendarbasetest.cpp

@@ -46,7 +46,7 @@ void CalendarBaseTest::fetchCollection()
     AKVERIFYEXEC(job);
 
     // Find our collection
-    Collection::List collections = job->collections();
+    const Collection::List collections = job->collections();
     QVERIFY(!collections.isEmpty());
     mCollection = collections.first();
 

src/calendarmodel.cpp

@@ -74,19 +74,20 @@ QVariant CalendarModel::entityData(const Akonadi::Item &item, int column, int ro
     }
 
     switch (role) {
-    case Qt::DecorationRole:
+    case Qt::DecorationRole: {
         if (column != Summary) {
             return QVariant();
         }
-        if (inc->type() == KCalendarCore::IncidenceBase::TypeTodo) {
+        const auto incType{inc->type()};
+        if (incType == KCalendarCore::IncidenceBase::TypeTodo) {
             return QIcon::fromTheme(QStringLiteral("view-pim-tasks"));
-        } else if (inc->type() == KCalendarCore::IncidenceBase::TypeJournal) {
+        } else if (incType == KCalendarCore::IncidenceBase::TypeJournal) {
             return QIcon::fromTheme(QStringLiteral("view-pim-journal"));
-        } else if (inc->type() == KCalendarCore::IncidenceBase::TypeEvent) {
+        } else if (incType == KCalendarCore::IncidenceBase::TypeEvent) {
             return QIcon::fromTheme(QStringLiteral("view-calendar"));
         }
         return QIcon::fromTheme(QStringLiteral("network-wired"));
-
+    }
     case Qt::DisplayRole:
         switch (column) {
         case Summary:

src/freebusydownloadjob_p.h

@@ -26,15 +26,15 @@ public:
 
     void start() override;
 
-    QUrl url() const;
-    QByteArray rawFreeBusyData() const;
+    Q_REQUIRED_RESULT QUrl url() const;
+    Q_REQUIRED_RESULT QByteArray rawFreeBusyData() const;
 
 private Q_SLOTS:
     void slotData(KIO::Job *, const QByteArray &data);
     void slotResult(KJob *job);
 
 private:
-    QUrl mUrl;
+    const QUrl mUrl;
     QByteArray mFreeBusyData;
     QWidget *const mParent;
 };

src/history.cpp

@@ -26,8 +26,6 @@ History::~History()
 History::Private::Private(History *qq)
     : mChanger(new IncidenceChanger(/*history=*/false, qq))
     , mOperationTypeInProgress(TypeNone)
-    , mUndoAllInProgress(false)
-    , mEnabled(true)
     , q(qq)
 {
     mChanger->setObjectName(QStringLiteral("changer")); // for auto-connects

src/history_p.h

@@ -89,14 +89,14 @@ public:
     Entry::Ptr mEntryInProgress;
 
     QString mLastErrorString;
-    bool mUndoAllInProgress;
+    bool mUndoAllInProgress = false;
 
     /**
      * When recordCreation/Deletion/Modification is called and an undo operation is already in progress
      * the entry is added here.
      */
     QVector<Entry::Ptr> mQueuedEntries;
-    bool mEnabled;
+    bool mEnabled = true;
     QPointer<QWidget> mCurrentParent;
 
 public Q_SLOTS:

src/standardcalendaractionmanager.cpp

@@ -26,8 +26,6 @@ public:
     Private(KActionCollection *actionCollection, QWidget *parentWidget, StandardCalendarActionManager *parent)
         : mActionCollection(actionCollection)
         , mParentWidget(parentWidget)
-        , mCollectionSelectionModel(nullptr)
-        , mItemSelectionModel(nullptr)
         , mParent(parent)
     {
         mGenericManager = new StandardActionManager(actionCollection, parentWidget);