Commit b4abd2d3 authored by Krzysztof Nowicki's avatar Krzysztof Nowicki
Browse files

Fix crash when opening e-mail with calendar invitation

Commit d82e7001

 introduced use of new loading state API, which has
unfortunately caused a regression. The reason for it is a constructor
circular dependency. The FetchJobCalendarPrivate class constructor is
trying to call a method of a base class, which hasn't been constructed
at this point, as the CalendarBase constructor has not executed yet
waiting for the FetchJobCalendarPrivate constructor to finish.

Untangle this mess by moving the method call to the FetchJobCalendar
constructor, at which point the base class is already initialized.

Signed-off-by: Krzysztof Nowicki's avatarKrzysztof Nowicki <krissn@op.pl>
parent 6f8be46c
Pipeline #215937 passed with stage
in 9 minutes and 16 seconds
......@@ -18,7 +18,6 @@ FetchJobCalendarPrivate::FetchJobCalendarPrivate(FetchJobCalendar *qq)
: CalendarBasePrivate(qq)
, q(qq)
{
q->setIsLoading(true);
auto job = new IncidenceFetchJob();
connect(job, &KJob::result, this, &FetchJobCalendarPrivate::slotSearchJobFinished);
connect(this, &CalendarBasePrivate::fetchFinished, this, &FetchJobCalendarPrivate::slotFetchJobFinished);
......@@ -63,6 +62,7 @@ void FetchJobCalendarPrivate::slotFetchJobFinished()
FetchJobCalendar::FetchJobCalendar(QObject *parent)
: CalendarBase(new FetchJobCalendarPrivate(this), parent)
{
setIsLoading(true);
}
FetchJobCalendar::~FetchJobCalendar() = default;
......
Supports Markdown
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment