Members of the KDE Community are recommended to subscribe to the kde-community mailing list at https://mail.kde.org/mailman/listinfo/kde-community to allow them to participate in important discussions and receive other important announcements

Commit 1ba883e2 authored by Laurent Montel's avatar Laurent Montel 😁

Reduce duplicate code

parent d073e12f
......@@ -20,6 +20,7 @@
*/
#include "blogfeedwidgettest.h"
#include "kdepimtest_layout.h"
#include "editor/generalinfoeditor/blogfeedwidget.h"
#include <QLabel>
......@@ -38,16 +39,7 @@ void BlogfeedWidgetTest::shouldHaveDefaultValue()
ContactEditor::BlogfeedWidget editor;
QVBoxLayout *topLayout = editor.findChild<QVBoxLayout *>(QStringLiteral("mainlayout"));
QVERIFY(topLayout);
int top = -1;
int bottom = -1;
int left = -1;
int right = -1;
topLayout->getContentsMargins(&left, &top, &right, &bottom);
QCOMPARE(top, 0);
QCOMPARE(left, 0);
QCOMPARE(bottom, 0);
QCOMPARE(right, 0);
KdepimTestLayout::checkContentsMargins(0, topLayout);
QLabel *blogFeedLabel = editor.findChild<QLabel *>(QStringLiteral("blogFeedLabel"));
QVERIFY(blogFeedLabel);
......
/*
Copyright (C) 2019 Montel Laurent <montel@kde.org>
This program is free software; you can redistribute it and/or
modify it under the terms of the GNU General Public
License as published by the Free Software Foundation; either
version 2 of the License, or (at your option) any later version.
This program is distributed in the hope that it will be useful,
but WITHOUT ANY WARRANTY; without even the implied warranty of
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
General Public License for more details.
You should have received a copy of the GNU General Public License
along with this program; see the file COPYING. If not, write to
the Free Software Foundation, Inc., 51 Franklin Street, Fifth Floor,
Boston, MA 02110-1301, USA.
*/
#ifndef KDEPIMTEST_LAYOUT_H
#define KDEPIMTEST_LAYOUT_H
#include <QTest>
#include <QLayout>
namespace KdepimTestLayout
{
void checkContentsMargins(int margin, QLayout *layout)
{
int top = -1;
int bottom = -1;
int left = -1;
int right = -1;
layout->getContentsMargins(&left, &top, &right, &bottom);
QCOMPARE(top, margin);
QCOMPARE(left, margin);
QCOMPARE(bottom, margin);
QCOMPARE(right, margin);
}
}
#endif
......@@ -20,6 +20,7 @@
*/
#include "nicknamewidgettest.h"
#include "kdepimtest_layout.h"
#include "editor/generalinfoeditor/nicknamewidget.h"
#include <QLabel>
......@@ -38,16 +39,7 @@ void NicknameWidgetTest::shouldHaveDefaultValue()
ContactEditor::NicknameWidget editor;
QVBoxLayout *topLayout = editor.findChild<QVBoxLayout *>(QStringLiteral("mainlayout"));
QVERIFY(topLayout);
int top = -1;
int bottom = -1;
int left = -1;
int right = -1;
topLayout->getContentsMargins(&left, &top, &right, &bottom);
QCOMPARE(top, 0);
QCOMPARE(left, 0);
QCOMPARE(bottom, 0);
QCOMPARE(right, 0);
KdepimTestLayout::checkContentsMargins(0, topLayout);
QLabel *nickNameLabel = editor.findChild<QLabel *>(QStringLiteral("nicknamelabel"));
QVERIFY(nickNameLabel);
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment