Members of the KDE Community are recommended to subscribe to the kde-community mailing list at https://mail.kde.org/mailman/listinfo/kde-community to allow them to participate in important discussions and receive other important announcements

Commit bf780097 authored by David Faure's avatar David Faure

EmailAddressSelectionWidget: use ETM signal to expand, rather than 1s timer.

Summary:
This leads to much better use interface, the signal being emitted much
faster than 1s (it's emitted when the collections have been listed,
before the items themselves are listed), it also works around a crash
in QSFPM that happens sometimes when the listing isn't done after 1s
(sounds like ETM or one of the proxies is in an inconsistent state,
something which I still have to debug)

Test Plan: emailaddressselectionwidgettest no longer crashes for me.

Reviewers: mlaurent, dvratil

Reviewed By: mlaurent

Subscribers: #kde_pim

Tags: #kde_pim

Differential Revision: https://phabricator.kde.org/D7613
parent 137c3362
......@@ -156,7 +156,11 @@ void EmailAddressSelectionWidget::Private::init()
mSearchLine->setFocus();
QTimer::singleShot(1000, mView, &QTreeView::expandAll);
if (Akonadi::EntityTreeModel *etm = qobject_cast<Akonadi::EntityTreeModel*>(mModel)) {
QObject::connect(etm, &Akonadi::EntityTreeModel::collectionTreeFetched, mView, &QTreeView::expandAll);
} else {
QTimer::singleShot(1000, mView, &QTreeView::expandAll);
}
}
EmailAddressSelectionWidget::EmailAddressSelectionWidget(QWidget *parent)
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment