Commit 2c10e118 authored by David Faure's avatar David Faure
Browse files

autotests: remove QEXPECT_FAIL, the mysql bug got fixed.

Summary:
It was resulting in XPASS for me and on CI, so this will actually fix CI.
I'm too lazy to add a mysql version check, not worth it in the long run.
Leaving comments in case anyone hits this with an old mysql.

Not sure what the impact of the fix has on the rest of kdepim though.
Maybe it allows removing workarounds?

Test Plan: ctest -R autoincrement

Reviewers: dvratil

Subscribers: kde-pim

Tags: #kde_pim

Differential Revision: https://phabricator.kde.org/D18557
parent d5ccee37
......@@ -34,11 +34,6 @@ using namespace Akonadi;
QTEST_AKONADIMAIN(AutoIncrementTest)
static bool isMySQLEnvironment()
{
return (qgetenv("TESTRUNNER_DB_ENVIRONMENT") == "mysql");
}
void AutoIncrementTest::initTestCase()
{
AkonadiTest::checkTestIsIsolated();
......@@ -97,10 +92,6 @@ void AutoIncrementTest::testItemAutoIncrement()
AKVERIFYEXEC(job);
Item newItem = job->item();
if (isMySQLEnvironment()) {
QEXPECT_FAIL("", "Server bug: http://bugs.mysql.com/bug.php?id=199", Continue);
}
QVERIFY(newItem.id() > lastId);
lastId = newItem.id();
}
......@@ -134,10 +125,6 @@ void AutoIncrementTest::testCollectionAutoIncrement()
AKVERIFYEXEC(job);
Collection newCollection = job->collection();
if (isMySQLEnvironment()) {
QEXPECT_FAIL("", "Server bug: http://bugs.mysql.com/bug.php?id=199", Continue);
}
QVERIFY(newCollection.id() > lastId);
lastId = newCollection.id();
}
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment