Commit 4ca8b846 authored by Daniel Vrátil's avatar Daniel Vrátil 🤖
Browse files

Remove the invalid GID part from PartTable before starting PartTable migration

More people than we expected have invalid 'GID' part in their PartTable,
which breaks migration to schema 25, because it expects all part types
to have a valid name.

To work around this fact, we DELETE all parts with name 'GID' from PartTable
before starting the actual migration. This will not fix the migration for
people with other invalid parts, but I haven't heard of any such. To make
this completely bullet-proof, we would need to iterate through all entries,
which would be massively slower than current INSERT INTO ... SELECT FROM approach.

Distributions, this is a good choice for backporting into 1.12.1 ;-)

BUG: 331867
FIXED-IN: 1.12.2
parent a5542751
......@@ -261,6 +261,15 @@ bool DbUpdater::complexUpdate_25()
}
}
{
// It appears that more users than expected have the invalid "GID" part in their
// PartTable, which breaks the migration below (see BKO#331867), so we apply this
// wanna-be fix to remove the invalid part before we start the actual migration.
QueryBuilder qb( QLatin1String( "PartTable" ), QueryBuilder::Delete );
qb.addValueCondition( QLatin1String( "PartTable.name" ), Query::Equals, QLatin1String( "GID" ) );
qb.exec();
}
akDebug() << "Creating a PartTable_new";
{
TableDescription description;
......
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment