Commit 9f6cb6b7 authored by Laurent Montel's avatar Laurent Montel 😁
Browse files

Add missing Q_REQUIRED_RESULT

parent 618ecb43
Pipeline #194344 passed with stage
in 10 minutes and 28 seconds
......@@ -17,7 +17,7 @@ public:
Q_REQUIRED_RESULT bool start(bool verbose);
private:
QDBusServiceWatcher mWatcher;
const QDBusServiceWatcher mWatcher;
bool mRegistered = false;
};
......@@ -139,7 +139,7 @@ protected:
/**
* Returns identifier of the Akonadi agent instance currently being configured.
*/
QString identifier() const;
Q_REQUIRED_RESULT QString identifier() const;
/**
* When KAboutData is provided the dialog will also contain KHelpMenu with
......
......@@ -26,7 +26,7 @@ public:
bool registerInstanceConfiguration(const QString &instance);
void unregisterInstanceConfiguration(const QString &instance);
bool isInstanceRegistered(const QString &instance) const;
Q_REQUIRED_RESULT bool isInstanceRegistered(const QString &instance) const;
QString findConfigPlugin(const QString &type) const;
......
......@@ -20,9 +20,6 @@ class AgentInstancePrivate : public QSharedData
{
public:
AgentInstancePrivate()
: mStatus(0)
, mProgress(0)
, mIsOnline(false)
{
}
......@@ -41,10 +38,10 @@ public:
AgentType mType;
QString mIdentifier;
QString mName;
int mStatus;
int mStatus = 0;
QString mStatusMessage;
int mProgress;
bool mIsOnline;
int mProgress = 0;
bool mIsOnline = false;
};
}
......
......@@ -32,7 +32,7 @@ public:
void addAttribute(Attribute *attr);
void removeAttribute(const QByteArray &type);
bool hasAttribute(const QByteArray &type) const;
Attribute::List attributes() const;
Q_REQUIRED_RESULT Attribute::List attributes() const;
void clearAttributes();
const Attribute *attribute(const QByteArray &type) const;
Attribute *attribute(const QByteArray &type);
......@@ -40,7 +40,7 @@ public:
void resetChangeLog();
QSet<QByteArray> deletedAttributes() const;
bool hasModifiedAttributes() const;
Q_REQUIRED_RESULT bool hasModifiedAttributes() const;
std::vector<Attribute *> modifiedAttributes() const;
private:
......
......@@ -185,7 +185,7 @@ public:
*
* @since 4.13
*/
bool isRecursive() const;
Q_REQUIRED_RESULT bool isRecursive() const;
/**
* Sets whether resources should be queried too.
......
......@@ -33,7 +33,7 @@ public:
SpecialCollectionsPrivate(KCoreConfigSkeleton *settings, SpecialCollections *qq);
~SpecialCollectionsPrivate();
QString defaultResourceId() const;
Q_REQUIRED_RESULT QString defaultResourceId() const;
void emitChanged(const QString &resourceId);
void collectionRemoved(const Collection &collection); // slot
void collectionFetchJobFinished(KJob *job); // slot
......@@ -61,7 +61,7 @@ public:
*/
void endBatchRegister();
AgentInstance defaultResource() const;
Q_REQUIRED_RESULT AgentInstance defaultResource() const;
SpecialCollections *const q;
KCoreConfigSkeleton *mSettings = nullptr;
......
......@@ -52,7 +52,7 @@ public:
*
* @see fetchAttribute()
*/
QSet<QByteArray> attributes() const;
Q_REQUIRED_RESULT QSet<QByteArray> attributes() const;
/**
* Sets whether to fetch tag remote ID.
......@@ -64,7 +64,7 @@ public:
/**
* Returns whether tag remote ID should be fetched.
*/
bool fetchRemoteId() const;
Q_REQUIRED_RESULT bool fetchRemoteId() const;
/**
* Sets whether to fetch all attributes.
......@@ -74,7 +74,7 @@ public:
/**
* Returns whether to fetch all attributes
*/
bool fetchAllAttributes() const;
Q_REQUIRED_RESULT bool fetchAllAttributes() const;
/**
* Sets whether the attribute of the given @p type should be fetched.
......@@ -110,7 +110,7 @@ public:
* @see tagFetchScope()
* @since 4.15
*/
bool fetchIdOnly() const;
Q_REQUIRED_RESULT bool fetchIdOnly() const;
private:
/// @cond PRIVATE
......
......@@ -36,9 +36,6 @@ bool operator==(const Item &left, const Item &right)
TagSync::TagSync(QObject *parent)
: Job(parent)
, mDeliveryDone(false)
, mTagMembersDeliveryDone(false)
, mLocalTagsFetched(false)
{
}
......
......@@ -40,9 +40,9 @@ private:
private:
Akonadi::Tag::List mRemoteTags;
Akonadi::Tag::List mLocalTags;
bool mDeliveryDone;
bool mTagMembersDeliveryDone;
bool mLocalTagsFetched;
bool mDeliveryDone = false;
bool mTagMembersDeliveryDone = false;
bool mLocalTagsFetched = false;
QHash<QString, Akonadi::Item::List> mRidMemberMap;
};
......
Supports Markdown
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment