Fix some clazy warning

autotests/libs/collectionjobtest.cpp

@@ -67,7 +67,8 @@ template<class T> static void compareLists(const QVector<T> &l1, const QVector<T
     }
 }
 
-template<typename T> static T *extractAttribute(QList<Attribute *> attrs)
+template<typename T>
+static T *extractAttribute(const QList<Attribute *> &attrs)
 {
     T dummy;
     for (Attribute *attr : attrs) {

autotests/libs/collectionmodifytest.cpp

@@ -29,7 +29,7 @@ private Q_SLOTS:
         Collection col;
         col.setName(QLatin1String("test_collection"));
         col.setContentMimeTypes({Collection::mimeType()});
-        col.setParentCollection(Collection(AkonadiTest::collectionIdFromPath(QLatin1String("res1"))));
+        col.setParentCollection(Collection(AkonadiTest::collectionIdFromPath(QStringLiteral("res1"))));
         col.setRights(Collection::AllRights);
 
         auto cj = new CollectionCreateJob(col, this);
@@ -39,7 +39,7 @@ private Q_SLOTS:
 
         auto attr = col.attribute<EntityDisplayAttribute>(Collection::AddIfMissing);
         attr->setDisplayName(QStringLiteral("Test Collection"));
-        col.setContentMimeTypes({Collection::mimeType(), QLatin1String("application/octet-stream")});
+        col.setContentMimeTypes({Collection::mimeType(), QStringLiteral("application/octet-stream")});
 
         auto mj = new CollectionModifyJob(col, this);
         AKVERIFYEXEC(mj);

autotests/libs/testrunner/setup.cpp

@@ -37,7 +37,7 @@ bool SetupTest::startAkonadiDaemon()
     mAkonadiDaemonProcess->setProgram(Akonadi::StandardDirs::findExecutable(QStringLiteral("akonadi_control")), {QStringLiteral("--instance"), instanceId()});
     mAkonadiDaemonProcess->start();
     const bool started = mAkonadiDaemonProcess->waitForStarted(5000);
-    qCInfo(AKONADITEST_LOG) << "Started akonadi daemon with pid:" << mAkonadiDaemonProcess->pid();
+    qCInfo(AKONADITEST_LOG) << "Started akonadi daemon with pid:" << mAkonadiDaemonProcess->processId();
     return started;
 }
 

src/core/changerecorderjournal.cpp

@@ -288,6 +288,7 @@ Protocol::ChangeNotificationPtr ChangeRecorderJournalReader::loadItemNotificatio
                 item.setFlags(bav);
                 stream >> cnt;
                 QVector<Protocol::FetchTagsResponse> tags;
+                tags.reserve(cnt);
                 for (int k = 0; k < cnt; ++k) {
                     Protocol::FetchTagsResponse tag;
                     stream >> i64;