GitLab

Another comment in the same file says
 // Do not assert on invalid collections, since a collection may be deleted
 // in the meantime and deleted collections are invalid.
Therefore it looks like this is expected.

By replacing it with QStringLiteral, or QLatin1String when passed
to proper overloads.

In Qt5 the default painter has text color set to black during animations, which
means that expanding the collection tree in KMail temporarily renders the items
in black until the expanding animation is over. To fix this we always fallback
to foreground color from global palette.

This reverts commit 5be2bdacaa807e01ed3da8a70e8f699c776c0ec8.

REVIEWS:  116169 116170 116171 116172 116173 116174 116175 116176 116177 116178 116179 116180 116181 116182 116183 116184 116185 116186 116187 116188 116189 116190 116191 116192 116193 116194 116195 116196 116197 116198 116199 116200 116201 116202 116203 116204 116205 116206 116207 116208 116209 116210 116211 116212 116213 116214 116215 116216 116217 116218 116219 116220 116221 116222 116223 116224 116225 116226 116227 116228 116229 116230 116231 116232 116233 116234 116235 116236 116237 116238 116239 116240 116241 116242 116243

(e.g. column 0, when the counts are in separate columns)

REVIEW: 110946

Reproducible somtimes after restarting akonadi.

The comment after the assert can stay...

This broke folder animations during loading.

index.model()->index(index.row(), 0, index.parent()) is really a
convoluted and slow version of index.sibling(index.row(), 0), which can
optimize if index.column() is already 0.

If it fails, then it wasn't a collection.

Where they are needed, make them compatible with the
new CMAKE_AUTOMOC feature.

include subfolder size
Now collapse folder show total size

CCBUG: 233414

without need

FIXED-IN: 4.8.1
BUG: 291010

just ignore invalid collections.  this is because collections could be
deleted in the meantime and deleted collections are invalid collections.

BUG: 271393
FIXED-IN: 4.7.4
MERGE: 4.7

This is where most of the KMail/Kontact CPU time during a mail check is
lost, caching accumulated stats per node would be a real solution, but
this change already saves 30-50%.

Makes things look nicer with larger folder icon sizes.