1. 25 Feb, 2020 1 commit
  2. 20 Feb, 2020 1 commit
    • Volker Krause's avatar
      Remove usage of KDBusConnectionPool · 92e16a83
      Volker Krause authored
      Summary:
      As per T12722 this is no longer needed, QDBusConnection now behaves
      correctly in a multi-threaded scenario.
      
      This doesn't remove all traces of KDBusAddons yet, the remaining bits
      need the users of Akonadi CMake macros to be ported first.
      
      Reviewers: dvratil
      
      Reviewed By: dvratil
      
      Subscribers: kde-pim
      
      Tags: #kde_pim
      
      Differential Revision: https://phabricator.kde.org/D27510
      92e16a83
  3. 02 Jan, 2020 2 commits
  4. 01 Jan, 2020 1 commit
  5. 09 Dec, 2019 1 commit
  6. 02 Dec, 2019 1 commit
  7. 30 Nov, 2019 1 commit
    • Laurent Montel's avatar
      [Akonadi] Port to QSortFilterProxyModel from deprecated KRecursiveFilterProxyModel · de890bed
      Laurent Montel authored
      Summary:
      KRecursiveFilterProxyModel is dead. Port to QSortFilterProxyModel.
      
      follow instructions in krecursivefilterproxymodel.h:
      "If you can depend on Qt >= 5.10, then just use QSortFilterProxyModel::setRecursiveFilteringEnabled(true), and you don't need to use KRecursiveFilterProxyModel."
      WARNING: merging this will break mailcommon build. working on a separate patch for mailcommon. perhaps others projects will also fail. don't know yet.
      
      Reviewers: dvratil, winterz
      
      Subscribers: kde-pim
      
      Tags: #kde_pim
      
      Differential Revision: https://phabricator.kde.org/D25621
      de890bed
  8. 22 Nov, 2019 2 commits
  9. 20 Nov, 2019 1 commit
    • David Faure's avatar
      Make itemmovetest more robust. · d7950588
      David Faure authored
      We could miss the notification if it arrived too fast.
      
      Test Plan: `ctest -R sqlite-itemmovetest` now passed 20 times in a row
      (failed on 3rd try previously). Note that mysql-itemmovetest could fail
      too, testing sqlite is just faster.
      
      CCMAIL: dvratil@kde.org
      d7950588
  10. 16 Nov, 2019 1 commit
  11. 15 Nov, 2019 1 commit
  12. 05 Oct, 2019 1 commit
    • Daniel Vrátil's avatar
      AkRanges: various cleanups · 1af267e7
      Daniel Vrátil authored
      * Move from Akonadi to AkRanges namespace
      * Introduce Views and Actions namespaces
      * Better names for template parameters
      1af267e7
  13. 03 Sep, 2019 1 commit
  14. 02 Sep, 2019 1 commit
  15. 30 Aug, 2019 1 commit
  16. 26 Aug, 2019 3 commits
  17. 18 Jul, 2019 1 commit
  18. 03 Jul, 2019 1 commit
  19. 19 Jun, 2019 2 commits
  20. 10 Jun, 2019 1 commit
    • Daniel Vrátil's avatar
      Raise limit for PimItem.remoteId to 1024 characters · c059d054
      Daniel Vrátil authored
      Summary:
      Some DAV servers produce exteremely long RIDs that do not fit into the
      current 255 character limit. This is only problem on MySQL, on other
      DBs we use TEXT, which has no length limit.
      
      On MySQL, just increasing the column length to 1024 is not enough,
      there's a limit on maximum length of VARBINARY/VARCHAR index, which is
      756 bytes (255 characters). To be able to have an index on a VARBINARY
      column with up to 1024 characters we need to enable innodb_large_prefix
      and change how the extra characters are stored on the disk (ROW_FORMAT).
      
      BUG: 394839
      
      Test Plan: Modified a unit-test to attempt creating an Item with 1024 characters long RID
      
      Reviewers: #kde_pim, vkrause
      
      Reviewed By: #kde_pim, vkrause
      
      Subscribers: kde-pim
      
      Tags: #kde_pim
      
      Differential Revision: https://phabricator.kde.org/D21714
      c059d054
  21. 13 May, 2019 2 commits
  22. 10 May, 2019 3 commits
  23. 09 May, 2019 2 commits
    • David Faure's avatar
      akonadi: port to ecm_add_test · f1c8dda3
      David Faure authored
      Summary:
      This fixes some inconsistencies like
       - ecm_mark_as_test not called on all tests
       - ecm_mark_as_test called with the wrong prefix in the name
      and it allows us to benefit from the automatic setting of
      QT_PLUGIN_PATH, as done in ecm_add_test.
      
      We could go further and use the LINK_LIBRARIES argument too, but
      that doesn't really matter.
      
      Test Plan: ctest
      
      Reviewers: dvratil
      
      Reviewed By: dvratil
      
      Subscribers: kde-pim
      
      Differential Revision: https://phabricator.kde.org/D21094
      f1c8dda3
    • David Faure's avatar
      Fix memory leak due to getTestMonitor() · 66b24c88
      David Faure authored
      Summary:
      asan build said the Monitor was leaked, and it was indeed.
      Fixed using std::unique_ptr.
      
      Test Plan:
      cmake -DCMAKE_C_COMPILER=clang -DCMAKE_CXX_COMPILER=clang++ -DECM_ENABLE_SANITIZERS="address" -DCMAKE_CXX_FLAGS='-stdlib=libc++' -DCMAKE_SHARED_LINKER_FLAGS='-stdlib=libc++' -DCMAKE_EXE_LINKER_FLAGS='-stdlib=libc++' .. && make && ctest
      (with an asan build of Qt)
      
      Reviewers: dvratil
      
      Reviewed By: dvratil
      
      Subscribers: kde-pim
      
      Differential Revision: https://phabricator.kde.org/D21093
      66b24c88
  24. 07 May, 2019 1 commit
  25. 29 Apr, 2019 1 commit
    • Volker Krause's avatar
      Also consider member typedefs for determining the base class · 16a65cae
      Volker Krause authored
      Summary:
      This should allow us to avoid having to include (or copy) this into
      KCalCore and KMime, as we no longer need to specialize the SuperClass
      template.
      
      PS: The unit test was written by Till 13 years ago, I have no idea who
      Gerd and Rudi are, or why they are sub-classes of me.
      
      Reviewers: dvratil
      
      Reviewed By: dvratil
      
      Subscribers: dvratil, kde-pim
      
      Tags: #kde_pim
      
      Differential Revision: https://phabricator.kde.org/D20845
      16a65cae
  26. 28 Apr, 2019 1 commit
  27. 27 Apr, 2019 1 commit
  28. 22 Apr, 2019 1 commit
  29. 21 Apr, 2019 1 commit
    • David Faure's avatar
      akonadi: fix some clazy warnings · 4463bb8a
      David Faure authored
      Summary:
      relation.h:30:1: warning: Move qHash(Akonadi::Relation) into Akonadi namespace for ADL lookup [-Wclazy-qhash-namespace]
      itemcreatehandlertest.cpp:874:30: warning: Don't call QVector::operator[]() on temporary [-Wclazy-detaching-temporary]
      tagmodeltest.cpp:266:5: warning: unused QList<QVariant> (removedTagList)
      
      Test Plan: builds, ctest passes
      
      Reviewers: dvratil, vkrause
      
      Reviewed By: vkrause
      
      Subscribers: kde-pim
      
      Tags: #kde_pim
      
      Differential Revision: https://phabricator.kde.org/D20714
      4463bb8a
  30. 15 Apr, 2019 2 commits