1. 14 Aug, 2020 1 commit
    • David Faure's avatar
      StandardActionManager: compress updates and emit useful signal · 9eda8853
      David Faure authored
      When deleting 5000 emails, KMail uses 100% CPU for a long time.
      This is because the messagelib code (due to threading etc.) removes
      rows one by one from the model. As a result
      - StandardActionManager was recalculating selection (slowly, see
      safeSelectedRows()) after every item
      - StandardMailActionManager was doing the same again
      - QSortFilterProxyModel updates its internal mapping at every step.
      I can't fix the last one, but I fixed the first two:
      
      1) compress changes with a 0s timer, so we only update the actions
      when going back to the event loop
      2) emit signal for StandardMailActionManager to use the computed
      lists, and more importantly so that it doesn't need its own timer.
      StandardActionManager is now the one which decides when StandardMailActionManager
      should update.
      9eda8853
  2. 07 Aug, 2020 1 commit
  3. 05 Aug, 2020 1 commit
  4. 02 Jul, 2020 1 commit
  5. 25 Jun, 2020 1 commit
  6. 10 Jun, 2020 3 commits
  7. 02 Jun, 2020 1 commit
  8. 09 May, 2020 1 commit
    • Igor Poboiko's avatar
      [StandardActionManager] Don't add PendingCutRole when copying · 03c6b6c0
      Igor Poboiko authored
      Summary: We shouldn't add `PendingCutRole` (which i.e. greys out items from the EntityTreeView) when we are only copying, not cutting
      
      Test Plan:
      Although I've found no PIM applications which use `Copy` action (KMail, KAdressBook and KOrganizer use `Copy To` with a submenu),
      I've used this action in KJots (to be able to paste links to various notes / books inside notes, instead of existing `copy_link_address` action), and it works.
      
      Reviewers: dvratil
      
      Reviewed By: dvratil
      
      Subscribers: kde-pim
      
      Tags: #kde_pim
      
      Differential Revision: https://phabricator.kde.org/D29484
      03c6b6c0
  9. 10 Apr, 2020 1 commit
  10. 30 Mar, 2020 2 commits
  11. 25 Mar, 2020 2 commits
  12. 20 Jan, 2020 1 commit
  13. 15 Nov, 2019 1 commit
  14. 16 Jan, 2019 1 commit
  15. 17 Dec, 2018 1 commit
  16. 14 Sep, 2018 1 commit
  17. 28 Jul, 2018 1 commit
    • Daniel Vrátil's avatar
      StandardActionManager: don't append empty popup to Copy To menu · 34b0eba4
      Daniel Vrátil authored
      If none of the sub folders is usable as a destination for Copy To
      or Move To operation, the popup will be empty. In such case avoid
      appending it to the action menu, because it looks broken (Qt shows
      and indicator that there is a submenu, but when you click on it,
      nothing appears)
      34b0eba4
  18. 05 Jul, 2018 1 commit
    • David Faure's avatar
      ActionStateManager: separate selected collections from favorites. · fd47fa73
      David Faure authored
      Summary:
      When filtering the folder tree (e.g. type "zzz"), a favorite can
      be selected, but without any selection in the folder tree.
      So the code should stop assuming that both selections are the same.
      
      That testcase is still broken when it comes to actually reading
      that favorite folder, but at least the popupmenu actions work now.
      
      Test Plan: As described above, in kmail.
      
      Reviewers: mlaurent, dvratil, vkrause
      
      Reviewed By: vkrause
      
      Subscribers: kde-pim
      
      Tags: #kde_pim
      
      Differential Revision: https://phabricator.kde.org/D13893
      fd47fa73
  19. 04 Jul, 2018 1 commit
  20. 14 May, 2018 1 commit
  21. 20 Apr, 2018 1 commit
  22. 18 Apr, 2018 1 commit
  23. 08 Jan, 2018 1 commit
  24. 01 Jan, 2018 1 commit
  25. 14 Nov, 2017 1 commit
  26. 20 Oct, 2017 1 commit
  27. 28 Apr, 2017 1 commit
  28. 18 Apr, 2017 1 commit
  29. 14 Apr, 2017 1 commit
  30. 13 Apr, 2017 1 commit
  31. 02 Feb, 2017 1 commit
  32. 20 Jan, 2017 1 commit
  33. 17 Jan, 2017 1 commit
  34. 16 Jan, 2017 1 commit
  35. 13 Jan, 2017 1 commit
  36. 12 Jan, 2017 1 commit