Members of the KDE Community are recommended to subscribe to the kde-community mailing list at to allow them to participate in important discussions and receive other important announcements

Commit 37f1871f authored by Daniel Vrátil's avatar Daniel Vrátil 🤖

CollectionSync: support Virtual flag change during sync

Collection's "virtual" flag cannot be changed through CollectionModifyJob,
the collection has to be re-created. Support this in the CollectionSync so
that Resources are able to clear or set the flag during collection retrieval.
parent c3a7f325
......@@ -27,11 +27,13 @@
#include "collectionfetchscope.h"
#include "collectionmovejob.h"
#include "cachepolicy.h"
#include <KLocalizedString>
#include <QHash>
#include <QList>
#include <functional>
using namespace Akonadi;
......@@ -259,9 +261,35 @@ public:
if (matchLocalAndRemoteCollection(localCollection, remoteCollection)) {
matched = true;
// Check if the local and remote collections differ and thus if
// we need to update it
if (collectionNeedsUpdate(localCollection, remoteCollection)) {
// "Virtual" flag cannot be updated: we need to recreate
// the collection from scratch.
if (localCollection.isVirtual() != remoteCollection.isVirtual()) {
// Mark the local collection and all its children for deletion and re-creation
QList<QPair<Collection/*local*/, Collection/*remote*/>> parents = {{localCollection,remoteCollection}};
while (!parents.empty()) {
auto parent = parents.takeFirst();
qCDebug(AKONADICORE_LOG) << "Local collection " << << " will be recreated";
for (auto it = localChildren.begin(), end = localChildren.end(); it != end;) {
if (it->parentCollection() == parent.first) {
Collection remoteParent;
auto remoteIt = std::find_if(remoteChildren.begin(), remoteChildren.end(),
this, parent.first, std::placeholders::_1));
if (remoteIt != remoteChildren.end()) {
remoteParent = *remoteIt;
remoteEnd = remoteChildren.erase(remoteIt);
parents.push_back({*it, remoteParent});
it = localChildren.erase(it);
localEnd = end = localChildren.end();
} else {
} else if (collectionNeedsUpdate(localCollection, remoteCollection)) {
// We need to store both local and remote collections, so that
// we can copy over attributes to be preserved
remoteCollectionsToUpdate.append(qMakePair(localCollection, remoteCollection));
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment