Skip to content
Commit 668e3f0d authored by Laurent Montel's avatar Laurent Montel
Browse files

Follow BinaryUnitDialect option

BUG: 454182
parent 28fa493f
Loading
Loading
Loading
Pipeline #179867 passed with stage
in 10 minutes and 37 seconds
Loading
  • Developer

    [22:32] <frinring> einar77: 668e3f0d added kiocore to the link interface, but forgot to adapt the cmake config file

    [22:33] <frinring> just pointing out, no time to do something about it

    This breaks downstream applications (example from eventviews):

    [   77s]   The link interface of target "KF5::AkonadiCore" contains:
    [   77s] 
    [   77s]     KF5::KIOCore
    [   77s] 
    [   77s]   but the target was not found.  Possible reasons include:
    [   77s] 
    [   77s]     * There is a typo in the target name.
    [   77s]     * A find_package call is missing for an IMPORTED target.
    [   77s]     * An ALIAS target is missing.
    [   77s] 
    [   77s] Call Stack (most recent call first):
    [   77s]   /usr/lib/cmake/KF5Akonadi/KF5AkonadiConfig.cmake:67 (include)
    [   77s]   CMakeLists.txt:45 (find_package)
    [   77s] 
    Edited by Luca Beltrame
  • Given the new usages are all in cpp files IISC, actually the fix would be to move the KIOCore lib to the private link interface. Doing now.

  • Friedrich W. H. Kossebau @kossebau

    mentioned in commit e40fb900

    ·

    mentioned in commit e40fb900

    Toggle commit list
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment