Verified Commit d0de8d79 authored by Daniel Vrátil's avatar Daniel Vrátil 🤖
Browse files

Clazy fixes in widgets lib

parent b5a23bfe
......@@ -60,15 +60,6 @@ static inline bool canContainItems(const Collection &collection)
return true;
}
ActionStateManager::ActionStateManager()
: mReceiver(nullptr)
{
}
ActionStateManager::~ActionStateManager()
{
}
void ActionStateManager::setReceiver(QObject *object)
{
mReceiver = object;
......
......@@ -39,12 +39,9 @@ public:
/*
* Creates a new action state manager.
*/
ActionStateManager();
explicit ActionStateManager() = default;
/**
* Destroys the action state manager.
*/
virtual ~ActionStateManager();
virtual ~ActionStateManager() = default;
/**
* Updates the states according to the selected collections and items.
......@@ -79,6 +76,8 @@ protected:
virtual void updateAlternatingAction(int action);
private:
Q_DISABLE_COPY_MOVE(ActionStateManager)
QObject *mReceiver = nullptr;
};
......
......@@ -174,7 +174,7 @@ public:
if (agentType.isValid()) {
AgentInstanceCreateJob *job = new AgentInstanceCreateJob(agentType, q);
q->connect(job, SIGNAL(result(KJob*)), SLOT(slotAgentInstanceCreationResult(KJob*)));
q->connect(job, &KJob::result, q, [this](KJob *job) { slotAgentInstanceCreationResult(job); });
job->configure(mParentWidget);
job->start();
}
......@@ -274,8 +274,8 @@ AgentActionManager::~AgentActionManager()
void AgentActionManager::setSelectionModel(QItemSelectionModel *selectionModel)
{
d->mSelectionModel = selectionModel;
connect(selectionModel, SIGNAL(selectionChanged(QItemSelection,QItemSelection)),
SLOT(updateActions()));
connect(selectionModel, &QItemSelectionModel::selectionChanged,
this, [this]() { d->updateActions(); });
}
void AgentActionManager::setMimeTypeFilter(const QStringList &mimeTypes)
......@@ -319,7 +319,8 @@ QAction *AgentActionManager::createAction(Type type)
void AgentActionManager::createAllActions()
{
for (int type = 0; type < LastType; ++type) {
createAction(static_cast<Type>(type));
auto action = createAction(static_cast<Type>(type));
Q_UNUSED(action);
}
}
......
......@@ -103,9 +103,7 @@ AgentConfigurationWidget::AgentConfigurationWidget(const AgentInstance &instance
if (auto dlg = qobject_cast<AgentConfigurationDialog*>(parent)) {
const_cast<AgentInstance&>(instance).configure(topLevelWidget()->parentWidget());
// If we are inside the AgentConfigurationDialog, hide the dialog
QTimer::singleShot(0, [dlg]() {
dlg->reject();
});
QTimer::singleShot(0, this, [dlg]() { dlg->reject(); });
} else {
const_cast<AgentInstance&>(instance).configure();
// Otherwise show a message that this is opened externally
......@@ -154,7 +152,7 @@ QSize AgentConfigurationWidget::restoreDialogSize() const
return {};
}
void AgentConfigurationWidget::saveDialogSize(const QSize &size)
void AgentConfigurationWidget::saveDialogSize(QSize size)
{
if (d->plugin) {
d->plugin->saveDialogSize(size);
......@@ -172,8 +170,8 @@ QDialogButtonBox::StandardButtons AgentConfigurationWidget::standardButtons() co
void AgentConfigurationWidget::childEvent(QChildEvent *event)
{
if (event->added()) {
if (auto widget = qobject_cast<QWidget*>(event->child())) {
layout()->addWidget(widget);
if (event->child()->isWidgetType()) {
layout()->addWidget(static_cast<QWidget*>(event->child()));
}
}
......
......@@ -43,7 +43,7 @@ public:
void load();
void save();
QSize restoreDialogSize() const;
void saveDialogSize(const QSize &size);
void saveDialogSize(QSize size);
QDialogButtonBox::StandardButtons standardButtons() const;
Q_SIGNALS:
......
......@@ -67,6 +67,7 @@ static const int s_delegatePaddingSize = 7;
class AgentInstanceWidgetDelegate : public QAbstractItemDelegate
{
Q_OBJECT
public:
explicit AgentInstanceWidgetDelegate(QObject *parent = nullptr);
......@@ -164,12 +165,11 @@ AgentInstanceWidget::AgentInstanceWidget(QWidget *parent)
d->mView->selectionModel()->setCurrentIndex(d->mView->model()->index(0, 0), QItemSelectionModel::Select);
d->mView->scrollTo(d->mView->model()->index(0, 0));
connect(d->mView->selectionModel(), SIGNAL(currentChanged(QModelIndex,QModelIndex)),
this, SLOT(currentAgentInstanceChanged(QModelIndex,QModelIndex)));
connect(d->mView->selectionModel(), &QItemSelectionModel::currentChanged,
this, [this](const auto &tl, const auto &br) { d->currentAgentInstanceChanged(tl, br); });
connect(d->mView, &QListView::doubleClicked,
this, [this](const QModelIndex &currentIndex) { d->currentAgentInstanceDoubleClicked(currentIndex); });
connect(d->mView, SIGNAL(clicked(QModelIndex)),
this, SLOT(currentAgentInstanceClicked(QModelIndex)));
connect(d->mView, &QListView::clicked, this, [this](const auto &mi) { d->currentAgentInstanceClicked(mi); });
}
AgentInstanceWidget::~AgentInstanceWidget()
......@@ -302,4 +302,4 @@ QSize AgentInstanceWidgetDelegate::sizeHint(const QStyleOptionViewItem &option,
}
#include "moc_agentinstancewidget.cpp"
#include "agentinstancewidget.moc"
......@@ -133,9 +133,6 @@ private:
//@cond PRIVATE
class Private;
Private *const d;
Q_PRIVATE_SLOT(d, void currentAgentInstanceChanged(const QModelIndex &, const QModelIndex &))
Q_PRIVATE_SLOT(d, void currentAgentInstanceClicked(const QModelIndex &currentIndex))
//@endcond
};
......
......@@ -38,6 +38,7 @@ namespace Internal
*/
class AgentTypeWidgetDelegate : public QAbstractItemDelegate
{
Q_OBJECT
public:
explicit AgentTypeWidgetDelegate(QObject *parent = nullptr);
......@@ -45,7 +46,7 @@ public:
QSize sizeHint(const QStyleOptionViewItem &option, const QModelIndex &index) const override;
private:
void drawFocus(QPainter *, const QStyleOptionViewItem &, const QRect &) const;
void drawFocus(QPainter *, const QStyleOptionViewItem &, QRect) const;
};
}
......@@ -258,7 +259,7 @@ QSize AgentTypeWidgetDelegate::sizeHint(const QStyleOptionViewItem &option, cons
return QSize(width, height);
}
void AgentTypeWidgetDelegate::drawFocus(QPainter *painter, const QStyleOptionViewItem &option, const QRect &rect) const
void AgentTypeWidgetDelegate::drawFocus(QPainter *painter, const QStyleOptionViewItem &option, QRect rect) const
{
if (option.state & QStyle::State_HasFocus) {
QStyleOptionFocusRect o;
......@@ -275,4 +276,4 @@ void AgentTypeWidgetDelegate::drawFocus(QPainter *painter, const QStyleOptionVie
}
#include "moc_agenttypewidget.cpp"
#include "agenttypewidget.moc"
......@@ -81,16 +81,11 @@ public:
mParent->model()->sort(mParent->modelColumn());
mSelectionHandler = new AsyncSelectionHandler(mRightsFilterModel, mParent);
mParent->connect(mSelectionHandler, SIGNAL(collectionAvailable(QModelIndex)),
mParent, SLOT(activated(QModelIndex)));
mParent->connect(mParent, SIGNAL(activated(int)),
mParent, SLOT(activated(int)));
mParent->connect(mSelectionHandler, &AsyncSelectionHandler::collectionAvailable,
mParent, [this](const auto &mi) { activated(mi); });
}
~Private()
{
}
~Private() = default;
void activated(int index);
void activated(const QModelIndex &index);
......
......@@ -116,11 +116,10 @@ public:
mParent->connect(filterCollectionLineEdit, &QLineEdit::textChanged,
mParent, [this](const QString &str) { slotFilterFixedString(str); });
mParent->connect(mView->selectionModel(), SIGNAL(selectionChanged(QItemSelection,QItemSelection)),
mParent, SLOT(slotSelectionChanged()));
mParent->connect(mView, SIGNAL(doubleClicked(QModelIndex)),
mParent, SLOT(slotDoubleClicked()));
mParent->connect(mView->selectionModel(), &QItemSelectionModel::selectionChanged,
mParent, [this]() { slotSelectionChanged(); });
mParent->connect(mView, qOverload<const QModelIndex &>(&QAbstractItemView::doubleClicked),
mParent, [this]() { slotDoubleClicked(); });
mSelectionHandler = new AsyncSelectionHandler(mFilterCollection, mParent);
mParent->connect(mSelectionHandler, &AsyncSelectionHandler::collectionAvailable,
......@@ -233,7 +232,7 @@ void CollectionDialog::Private::changeCollectionDialogOptions(CollectionDialogOp
mNewSubfolderButton->setIcon(QIcon::fromTheme(QStringLiteral("folder-new")));
mNewSubfolderButton->setToolTip(i18n("Create a new subfolder under the currently selected folder"));
mNewSubfolderButton->setEnabled(false);
connect(mNewSubfolderButton, SIGNAL(clicked(bool)), mParent, SLOT(slotAddChildCollection()));
connect(mNewSubfolderButton, &QPushButton::clicked, mParent, [this]() { slotAddChildCollection(); });
}
mKeepTreeExpanded = (options & KeepTreeExpanded);
if (mKeepTreeExpanded) {
......
......@@ -210,10 +210,6 @@ private:
//@cond PRIVATE
class Private;
Private *const d;
Q_PRIVATE_SLOT(d, void slotSelectionChanged())
Q_PRIVATE_SLOT(d, void slotAddChildCollection())
Q_PRIVATE_SLOT(d, void slotDoubleClicked())
//@endcond
};
......
......@@ -135,7 +135,7 @@ void CollectionPropertiesDialog::Private::init()
mainLayout->addWidget(buttonBox);
if (mPageNames.isEmpty()) { // default loading
for (CollectionPropertiesPageFactory *factory : *s_pages) {
for (CollectionPropertiesPageFactory *factory : qAsConst(*s_pages)) {
CollectionPropertiesPage *page = factory->createWidget(mTabWidget);
if (page->canHandle(mCollection)) {
mTabWidget->addTab(page, page->pageTitle());
......@@ -147,7 +147,7 @@ void CollectionPropertiesDialog::Private::init()
} else { // custom loading
QHash<QString, CollectionPropertiesPage *> pages;
for (CollectionPropertiesPageFactory *factory : *s_pages) {
for (CollectionPropertiesPageFactory *factory : qAsConst(*s_pages)) {
CollectionPropertiesPage *page = factory->createWidget(mTabWidget);
const QString pageName = page->objectName();
......
......@@ -180,6 +180,12 @@ public:
* @param parent The parent widget.
*/
virtual CollectionPropertiesPage *createWidget(QWidget *parent = nullptr) const = 0;
protected:
explicit CollectionPropertiesPageFactory() = default;
private:
Q_DISABLE_COPY_MOVE(CollectionPropertiesPageFactory)
};
/**
......
......@@ -94,7 +94,6 @@ public:
*/
void updatePalette();
public Q_SLOTS:
/**
* Sets whether the unread count is drawn next to the folder name.
*
......
......@@ -80,7 +80,7 @@ void CollectionView::Private::init()
dragExpandTimer.setSingleShot(true);
mParent->connect(&dragExpandTimer, &QTimer::timeout, mParent, [this]() { dragExpand(); });
mParent->connect(mParent, SIGNAL(clicked(QModelIndex)), mParent, SLOT(itemClicked(QModelIndex)));
mParent->connect(mParent, &QAbstractItemView::clicked, mParent, [this](const QModelIndex &mi) { itemClicked(mi); });
ControlGui::widgetNeedsAkonadi(mParent);
}
......@@ -157,8 +157,8 @@ void CollectionView::setModel(QAbstractItemModel *model)
QTreeView::setModel(model);
header()->setStretchLastSection(true);
connect(selectionModel(), SIGNAL(currentChanged(QModelIndex,QModelIndex)),
this, SLOT(itemCurrentChanged(QModelIndex)));
connect(selectionModel(), &QItemSelectionModel::currentChanged,
this, [this](const QModelIndex &mi) { d->itemCurrentChanged(mi); });
}
void CollectionView::dragMoveEvent(QDragMoveEvent *event)
......
......@@ -52,9 +52,7 @@ static inline QString textToHTML(const QString &text)
class HtmlDifferencesReporter : public AbstractDifferencesReporter
{
public:
HtmlDifferencesReporter()
{
}
HtmlDifferencesReporter() = default;
QString toHtml() const
{
......
......@@ -42,6 +42,7 @@ namespace Internal
class ControlProgressIndicator : public QFrame
{
Q_OBJECT
public:
ControlProgressIndicator(QWidget *parent = nullptr)
: QFrame(parent)
......@@ -65,11 +66,7 @@ public:
class StaticControlGui : public ControlGui
{
public:
StaticControlGui()
: ControlGui()
{
}
Q_OBJECT
};
}
......@@ -268,9 +265,9 @@ void ControlGui::widgetNeedsAkonadi(QWidget *widget)
s_instance->d->mPendingOverlays.append(widget);
// delay the overlay creation since we rely on widget being reparented
// correctly already
QTimer::singleShot(0, s_instance, SLOT(createErrorOverlays()));
QTimer::singleShot(0, s_instance, []() { s_instance->d->createErrorOverlays(); });
}
}
#include "moc_controlgui.cpp"
#include "controlgui.moc"
......@@ -134,8 +134,6 @@ private:
//@cond PRIVATE
class Private;
Private *const d;
Q_PRIVATE_SLOT(d, void createErrorOverlays())
//@endcond
};
......
......@@ -71,8 +71,8 @@ void EntityListView::Private::init()
mParent->setDragDropMode(DragDrop);
mParent->setDragEnabled(true);
#endif
mParent->connect(mParent, SIGNAL(clicked(QModelIndex)), mParent, SLOT(itemClicked(QModelIndex)));
mParent->connect(mParent, SIGNAL(doubleClicked(QModelIndex)), mParent, SLOT(itemDoubleClicked(QModelIndex)));
mParent->connect(mParent, &QAbstractItemView::clicked, mParent, [this](const auto &index) { itemClicked(index); });
mParent->connect(mParent, &QAbstractItemView::doubleClicked, mParent, [this](const auto &index) { itemDoubleClicked(index); });
DelegateAnimator *animator = new DelegateAnimator(mParent);
ProgressSpinnerDelegate *customDelegate = new ProgressSpinnerDelegate(animator, mParent);
......@@ -157,14 +157,13 @@ EntityListView::~EntityListView()
void EntityListView::setModel(QAbstractItemModel *model)
{
if (selectionModel()) {
disconnect(selectionModel(), SIGNAL(currentChanged(QModelIndex,QModelIndex)),
this, SLOT(itemCurrentChanged(QModelIndex)));
disconnect(selectionModel(), &QItemSelectionModel::currentChanged, this, nullptr);
}
QListView::setModel(model);
connect(selectionModel(), SIGNAL(currentChanged(QModelIndex,QModelIndex)),
SLOT(itemCurrentChanged(QModelIndex)));
connect(selectionModel(), &QItemSelectionModel::currentChanged,
this, [this](const QModelIndex &index) { d->itemCurrentChanged(index); });
}
#ifndef QT_NO_DRAGANDDROP
......
......@@ -201,10 +201,6 @@ private:
//@cond PRIVATE
class Private;
Private *const d;
Q_PRIVATE_SLOT(d, void itemClicked(const QModelIndex &))
Q_PRIVATE_SLOT(d, void itemDoubleClicked(const QModelIndex &))
Q_PRIVATE_SLOT(d, void itemCurrentChanged(const QModelIndex &))
//@endcond
};
......
......@@ -96,8 +96,8 @@ void EntityTreeView::Private::init()
mParent->setDragEnabled(true);
#endif
mParent->connect(mParent, SIGNAL(clicked(QModelIndex)), mParent, SLOT(itemClicked(QModelIndex)));
mParent->connect(mParent, SIGNAL(doubleClicked(QModelIndex)), mParent, SLOT(itemDoubleClicked(QModelIndex)));
mParent->connect(mParent, &QAbstractItemView::clicked, mParent, [this](const auto &index) { itemClicked(index); });
mParent->connect(mParent, &QAbstractItemView::doubleClicked, mParent, [this](const auto &index) { itemDoubleClicked(index); });
ControlGui::widgetNeedsAkonadi(mParent);
}
......@@ -205,21 +205,17 @@ EntityTreeView::~EntityTreeView()
void EntityTreeView::setModel(QAbstractItemModel *model)
{
if (selectionModel()) {
disconnect(selectionModel(), SIGNAL(currentChanged(QModelIndex,QModelIndex)),
this, SLOT(itemCurrentChanged(QModelIndex)));
disconnect(selectionModel(), SIGNAL(selectionChanged(QItemSelection,QItemSelection)),
this, SLOT(slotSelectionChanged(QItemSelection,QItemSelection)));
disconnect(selectionModel(), &QItemSelectionModel::currentChanged, this, nullptr);
disconnect(selectionModel(), &QItemSelectionModel::selectionChanged, this, nullptr);
}
QTreeView::setModel(model);
header()->setStretchLastSection(true);
connect(selectionModel(), SIGNAL(currentChanged(QModelIndex,QModelIndex)),
SLOT(itemCurrentChanged(QModelIndex)));
connect(selectionModel(), SIGNAL(selectionChanged(QItemSelection,QItemSelection)),
SLOT(slotSelectionChanged(QItemSelection,QItemSelection)));
connect(selectionModel(), &QItemSelectionModel::currentChanged,
this, [this](const auto &index) { d->itemCurrentChanged(index); });
connect(selectionModel(), &QItemSelectionModel::selectionChanged,
this, [this](const auto &oldSel, const auto &newSel) { d->slotSelectionChanged(oldSel, newSel); });
}
void EntityTreeView::timerEvent(QTimerEvent *event)
......
......@@ -232,11 +232,6 @@ private:
//@cond PRIVATE
class Private;
Private *const d;
Q_PRIVATE_SLOT(d, void itemClicked(const QModelIndex &))
Q_PRIVATE_SLOT(d, void itemDoubleClicked(const QModelIndex &))
Q_PRIVATE_SLOT(d, void itemCurrentChanged(const QModelIndex &))
Q_PRIVATE_SLOT(d, void slotSelectionChanged(const QItemSelection &, const QItemSelection &))
//@endcond
};
......
......@@ -62,9 +62,9 @@ void ItemView::Private::init()
mParent->header()->setSectionsClickable(true);
mParent->header()->setStretchLastSection(true);
mParent->connect(mParent, SIGNAL(activated(QModelIndex)), mParent, SLOT(itemActivated(QModelIndex)));
mParent->connect(mParent, SIGNAL(clicked(QModelIndex)), mParent, SLOT(itemClicked(QModelIndex)));
mParent->connect(mParent, QOverload<const QModelIndex &>::of(&QAbstractItemView::doubleClicked), mParent, [this](const QModelIndex &index) { itemDoubleClicked(index); });
mParent->connect(mParent, &QAbstractItemView::activated, mParent, [this](const auto &index) { itemActivated(index); });
mParent->connect(mParent, &QAbstractItemView::clicked, mParent, [this](const auto &index) { itemClicked(index); });
mParent->connect(mParent, &QAbstractItemView::doubleClicked, [this](const auto &index) { itemDoubleClicked(index); });
ControlGui::widgetNeedsAkonadi(mParent);
}
......@@ -144,10 +144,14 @@ ItemView::~ItemView()
void ItemView::setModel(QAbstractItemModel *model)
{
if (selectionModel()) {
disconnect(selectionModel(), &QItemSelectionModel::currentChanged, this, nullptr);
}
QTreeView::setModel(model);
connect(selectionModel(), SIGNAL(currentChanged(QModelIndex,QModelIndex)),
this, SLOT(itemCurrentChanged(QModelIndex)));
connect(selectionModel(), &QItemSelectionModel::currentChanged,
this, [this](const auto &index) { d->itemCurrentChanged(index); });
}
void ItemView::contextMenuEvent(QContextMenuEvent *event)
......
......@@ -141,11 +141,6 @@ private:
//@cond PRIVATE
class Private;
Private *const d;
Q_PRIVATE_SLOT(d, void itemActivated(const QModelIndex &))
Q_PRIVATE_SLOT(d, void itemCurrentChanged(const QModelIndex &))
Q_PRIVATE_SLOT(d, void itemClicked(const QModelIndex &))
Q_PRIVATE_SLOT(d, void itemDoubleClicked(const QModelIndex &))
//@endcond
};
......
......@@ -60,7 +60,8 @@ void DelegateAnimator::pop(const QModelIndex &index)
void DelegateAnimator::timerEvent(QTimerEvent *event)
{
if (!(event->timerId() == m_timerId && m_view)) {
return QObject::timerEvent(event);
QObject::timerEvent(event);
return;
}
QRegion region;
......
......@@ -316,8 +316,8 @@ public:
menu = new QMenu();
menu->setProperty("actionType", static_cast<int>(type));
q->connect(menu, SIGNAL(aboutToShow()), SLOT(aboutToShowMenu()));
q->connect(menu, SIGNAL(triggered(QAction*)), standardActionData[type].slot);
q->connect(menu, &QMenu::aboutToShow, q, [this]() { aboutToShowMenu(); });
q->connect(menu, SIGNAL(triggered(QAction*)), standardActionData[type].slot); // clazy:exclude=old-style-connect
actionMenu->setMenu(menu);
}
}
......@@ -661,7 +661,7 @@ public:
}
CollectionCreateJob *job = new CollectionCreateJob(collection);
q->connect(job, SIGNAL(result(KJob*)), q, SLOT(collectionCreationResult(KJob*)));
q->connect(job, &KJob::result, q, [this](KJob *job) { collectionCreationResult(job); });
}
void slotCopyCollections()
......@@ -1157,7 +1157,7 @@ public:
if (agentType.isValid()) {
AgentInstanceCreateJob *job = new AgentInstanceCreateJob(agentType, q);
q->connect(job, SIGNAL(result(KJob*)), SLOT(resourceCreationResult(KJob*)));
q->connect(job, &KJob::result, q, [this](KJob *job) { resourceCreationResult(job); });
job->configure(parentWidget);
job->start();
}
......@@ -1606,7 +1606,7 @@ StandardActionManager::StandardActionManager(KActionCollection *actionCollection
d->actionCollection = actionCollection;
d->mActionStateManager.setReceiver(this);
#ifndef QT_NO_CLIPBOARD
connect(QApplication::clipboard(), SIGNAL(changed(QClipboard::Mode)), SLOT(clipboardChanged(QClipboard::Mode)));
connect(QApplication::clipboard(), &QClipboard::changed, this, [this](auto mode) { d->clipboardChanged(mode); });
#endif
}
......@@ -1618,8 +1618,7 @@ StandardActionManager::~StandardActionManager()
void StandardActionManager::setCollectionSelectionModel(QItemSelectionModel *selectionModel)
{
d->collectionSelectionModel = selectionModel;
connect(selectionModel, SIGNAL(selectionChanged(QItemSelection,QItemSelection)),
SLOT(collectionSelectionChanged()));
connect(selectionModel, &QItemSelectionModel::selectionChanged, this, [this]() { d->collectionSelectionChanged(); });
d->checkModelsConsistency();
}
......@@ -1627,8 +1626,7 @@ void StandardActionManager::setCollectionSelectionModel(QItemSelectionModel *sel
void StandardActionManager::setItemSelectionModel(QItemSelectionModel *selectionModel)
{
d->itemSelectionModel = selectionModel;
connect(selectionModel, SIGNAL(selectionChanged(QItemSelection,QItemSelection)),
SLOT(updateActions()));
connect(selectionModel, &QItemSelectionModel::selectionChanged, this, [this]() { d->updateActions(); });
}
void StandardActionManager::setFavoriteCollectionsModel(FavoriteCollectionsModel *favoritesModel)
......@@ -1640,8 +1638,7 @@ void StandardActionManager::setFavoriteCollectionsModel(FavoriteCollectionsModel
void StandardActionManager::setFavoriteSelectionModel(QItemSelectionModel *selectionModel)
{
d->favoriteSelectionModel = selectionModel;
connect(selectionModel, SIGNAL(selectionChanged(QItemSelection,QItemSelection)),
SLOT(favoriteSelectionChanged()));
connect(selectionModel, &QItemSelectionModel::selectionChanged, this, [this]() { d->favoriteSelectionChanged(); });
d->checkModelsConsistency();
}
......@@ -1697,15 +1694,15 @@ QAction *StandardActionManager::createAction(Type type)
switch (standardActionData[type].actionType) {
case NormalAction:
case ActionWithAlternative:
connect(action, SIGNAL(triggered()), standardActionData[type].slot);
connect(action, SIGNAL(triggered()), standardActionData[type].slot); // clazy:exclude=old-style-connect
break;
case MenuAction: {