Commit b65b4e40 authored by Laurent Montel's avatar Laurent Montel 😁
Browse files

Use auto vs auto * where it's possible

parent d8722e3f
Pipeline #49631 failed with stage
in 12 minutes and 34 seconds
......@@ -24,7 +24,7 @@ KCMAkregatorAdvancedConfig::KCMAkregatorAdvancedConfig(QWidget *parent, const QV
: KCModule(parent, args)
, m_widget(new SettingsAdvanced(this))
{
auto *layout = new QVBoxLayout(this);
auto layout = new QVBoxLayout(this);
layout->addWidget(m_widget);
KAboutData *about = new KAboutData(QStringLiteral("kcmakradvancedconfig"),
i18n("Advanced Feed Reader Settings"),
......
......@@ -25,7 +25,7 @@ KCMAkregatorAppearanceConfig::KCMAkregatorAppearanceConfig(QWidget *parent, cons
{
m_ui.setupUi(m_widget);
auto *layout = new QVBoxLayout(this);
auto layout = new QVBoxLayout(this);
layout->addWidget(m_widget);
connect(m_ui.kcfg_UseCustomColors, &QAbstractButton::toggled, m_ui.kcfg_ColorUnreadArticles, &QWidget::setEnabled);
......
......@@ -24,7 +24,7 @@ KCMAkregatorArchiveConfig::KCMAkregatorArchiveConfig(QWidget *parent, const QVar
{
Ui::SettingsArchive m_ui;
m_ui.setupUi(m_widget);
auto *layout = new QVBoxLayout(this);
auto layout = new QVBoxLayout(this);
layout->addWidget(m_widget);
connect(m_ui.rb_LimitArticleNumber, &QAbstractButton::toggled, m_ui.kcfg_MaxArticleNumber, &QWidget::setEnabled);
......
......@@ -27,7 +27,7 @@ KCMAkregatorBrowserConfig::KCMAkregatorBrowserConfig(QWidget *parent, const QVar
Ui::SettingsBrowser ui;
ui.setupUi(m_widget);
auto *layout = new QVBoxLayout(this);
auto layout = new QVBoxLayout(this);
layout->addWidget(m_widget);
connect(ui.kcfg_ExternalBrowserUseCustomCommand, &QAbstractButton::toggled, ui.kcfg_ExternalBrowserCustomCommand, &QWidget::setEnabled);
......
......@@ -27,7 +27,7 @@ KCMAkregatorGeneralConfig::KCMAkregatorGeneralConfig(QWidget *parent, const QVar
Ui::SettingsGeneral ui;
ui.setupUi(m_widget);
auto *layout = new QVBoxLayout(this);
auto layout = new QVBoxLayout(this);
layout->addWidget(m_widget);
ui.kcfg_AutoFetchInterval->setSuffix(ki18np(" minute", " minutes"));
......
......@@ -20,7 +20,7 @@ K_PLUGIN_FACTORY(KCMAkregatorPluginsConfigFactory, registerPlugin<KCMAkregatorPl
KCMAkregatorPluginsConfig::KCMAkregatorPluginsConfig(QWidget *parent, const QVariantList &args)
: KCModule(parent, args)
{
auto *lay = new QHBoxLayout(this);
auto lay = new QHBoxLayout(this);
lay->setContentsMargins({});
KAboutData *about = new KAboutData(QStringLiteral("kcmakrpluginsconfig"),
......
......@@ -21,7 +21,7 @@ K_PLUGIN_FACTORY(KCMAkregatorUserFeedBackConfigFactory, registerPlugin<KCMAkrega
KCMAkregatorUserFeedBackConfig::KCMAkregatorUserFeedBackConfig(QWidget *parent, const QVariantList &args)
: KCModule(parent, args)
{
auto *lay = new QHBoxLayout(this);
auto lay = new QHBoxLayout(this);
lay->setContentsMargins({});
KAboutData *about = new KAboutData(QStringLiteral("kcmaddressbookuserfeedbackconfig"),
......
......@@ -91,7 +91,7 @@ void AkregatorPlugin::addFeed()
void AkregatorPlugin::readProperties(const KConfigGroup &config)
{
if (part()) {
auto *myPart = static_cast<Akregator::Part *>(part());
auto myPart = static_cast<Akregator::Part *>(part());
myPart->readProperties(config);
}
}
......@@ -99,7 +99,7 @@ void AkregatorPlugin::readProperties(const KConfigGroup &config)
void AkregatorPlugin::saveProperties(KConfigGroup &config)
{
if (part()) {
auto *myPart = static_cast<Akregator::Part *>(part());
auto myPart = static_cast<Akregator::Part *>(part());
myPart->saveProperties(config);
}
}
......
......@@ -246,7 +246,7 @@ void ActionManagerImpl::initMainWidget(MainWidget *mainWidget)
// toolbar / View
const auto viewMode = static_cast<MainWidget::ViewMode>(Settings::viewMode());
auto *group = new QActionGroup(this);
auto group = new QActionGroup(this);
action = coll->addAction(QStringLiteral("normal_view"));
action->setCheckable(true);
action->setChecked(viewMode == MainWidget::NormalView);
......
......@@ -50,7 +50,7 @@ AddFeedDialog::AddFeedDialog(QWidget *parent, const QString &name)
{
setObjectName(name);
setWindowTitle(i18nc("@title:window", "Add Feed"));
auto *mainLayout = new QVBoxLayout(this);
auto mainLayout = new QVBoxLayout(this);
widget = new AddFeedWidget(this);
QDialogButtonBox *buttonBox = new QDialogButtonBox(QDialogButtonBox::Ok | QDialogButtonBox::Cancel, this);
......
......@@ -159,7 +159,7 @@ Part::Part(QWidget *parentWidget, QObject *parent, const QVariantList &)
QDir().mkpath(path);
m_standardFeedList = path + QStringLiteral("/feeds.opml");
auto *dummyFactory = new Backend::StorageFactoryDummyImpl();
auto dummyFactory = new Backend::StorageFactoryDummyImpl();
if (!Backend::StorageFactoryRegistry::self()->registerFactory(dummyFactory, dummyFactory->key())) {
// There was already a dummy factory registered.
delete dummyFactory;
......@@ -273,7 +273,7 @@ void Part::slotOnShutdown()
void Part::initializeTrayIcon()
{
auto *trayIcon = new TrayIcon(m_mainWidget->window());
auto trayIcon = new TrayIcon(m_mainWidget->window());
TrayIcon::setInstance(trayIcon);
m_actionManager->setTrayIcon(trayIcon);
......
......@@ -129,13 +129,13 @@ void ArticleListView::setArticleModel(ArticleModel *model)
m_proxy->setSourceModel(model);
m_proxy->setSortRole(ArticleModel::SortRole);
m_proxy->setFilters(m_matchers);
auto *const proxy2 = new FilterDeletedProxyModel(model);
auto const proxy2 = new FilterDeletedProxyModel(model);
proxy2->setSortRole(ArticleModel::SortRole);
proxy2->setSourceModel(m_proxy);
connect(model, &QAbstractItemModel::rowsInserted, m_proxy.data(), &QSortFilterProxyModel::invalidate);
auto *const columnsProxy = new FilterColumnsProxyModel(model);
auto const columnsProxy = new FilterColumnsProxyModel(model);
columnsProxy->setSortRole(ArticleModel::SortRole);
columnsProxy->setSourceModel(proxy2);
columnsProxy->setColumnEnabled(ArticleModel::ItemTitleColumn);
......@@ -400,7 +400,7 @@ void ArticleListView::mousePressEvent(QMouseEvent *ev)
void ArticleListView::contextMenuEvent(QContextMenuEvent *event)
{
QWidget *w = ActionManager::getInstance()->container(QStringLiteral("article_popup"));
auto *popup = qobject_cast<QMenu *>(w);
auto popup = qobject_cast<QMenu *>(w);
if (popup) {
popup->exec(event->globalPos());
}
......
......@@ -57,7 +57,7 @@ ArticleViewerWebEngineWidgetNg::ArticleViewerWebEngineWidgetNg(KActionCollection
void ArticleViewerWebEngineWidgetNg::initializeLayout(KActionCollection *ac)
{
auto *layout = new QVBoxLayout(this);
auto layout = new QVBoxLayout(this);
layout->setContentsMargins({});
mTextToSpeechWidget = new KPIMTextEdit::TextToSpeechWidget(this);
......@@ -161,7 +161,7 @@ void ArticleViewerWebEngineWidgetNg::slotOpenInBrowser()
{
const QUrl currentUrl(mArticleViewerNg->url());
if (currentUrl.isLocalFile()) {
auto *job = new WebEngineViewer::WebEngineExportHtmlPageJob;
auto job = new WebEngineViewer::WebEngineExportHtmlPageJob;
job->setEngineView(mArticleViewerNg);
connect(job, &WebEngineViewer::WebEngineExportHtmlPageJob::failed, this, &ArticleViewerWebEngineWidgetNg::slotExportHtmlPageFailed);
connect(job, &WebEngineViewer::WebEngineExportHtmlPageJob::success, this, &ArticleViewerWebEngineWidgetNg::slotExportHtmlPageSuccess);
......
......@@ -46,7 +46,7 @@ ArticleViewerWidget::ArticleViewerWidget(const QString &grantleeDirectory, KActi
, m_articleViewerWidgetNg(new Akregator::ArticleViewerWebEngineWidgetNg(ac, this))
, m_grantleeDirectory(grantleeDirectory)
{
auto *layout = new QGridLayout(this);
auto layout = new QGridLayout(this);
layout->setContentsMargins({});
layout->addWidget(m_articleViewerWidgetNg);
m_articleHtmlWriter = new Akregator::ArticleHtmlWebEngineWriter(m_articleViewerWidgetNg->articleViewerNg(), this);
......
......@@ -50,7 +50,7 @@ void CreateFolderCommand::Private::doCreate()
return;
}
auto *parentFolder = qobject_cast<Folder *>(m_selectedSubscription);
auto parentFolder = qobject_cast<Folder *>(m_selectedSubscription);
if (!parentFolder) {
parentFolder = m_selectedSubscription ? m_selectedSubscription->parent() : nullptr;
}
......@@ -60,7 +60,7 @@ void CreateFolderCommand::Private::doCreate()
TreeNode *const after = (m_selectedSubscription && m_selectedSubscription->isGroup()) ? m_selectedSubscription : nullptr;
auto *const newFolder = new Folder(name);
auto const newFolder = new Folder(name);
parentFolder->insertChild(newFolder, after);
m_subscriptionListView->ensureNodeVisible(newFolder);
q->done();
......
......@@ -90,7 +90,7 @@ public:
private:
static DeleteSubscriptionJob *reallyCreateJob(TreeNode *node)
{
auto *job = new DeleteSubscriptionJob;
auto job = new DeleteSubscriptionJob;
job->setSubscriptionId(node->id());
return job;
}
......
......@@ -48,7 +48,7 @@ ExpireItemsCommand::Private::Private(ExpireItemsCommand *qq)
void ExpireItemsCommand::Private::addDeleteJobForFeed(Feed *feed)
{
Q_ASSERT(feed);
auto *job = new ArticleDeleteJob(q);
auto job = new ArticleDeleteJob(q);
connect(job, &ArticleDeleteJob::finished, q, [this](KJob *job) {
jobFinished(job);
});
......
......@@ -15,9 +15,9 @@ using namespace Akregator;
CrashWidget::CrashWidget(QWidget *parent)
: QWidget(parent)
{
auto *vbox = new QVBoxLayout(this);
auto vbox = new QVBoxLayout(this);
auto *labelLayout = new QHBoxLayout;
auto labelLayout = new QHBoxLayout;
QLabel *label = new QLabel(i18n("Akregator did not close correctly. Would you like to restore the previous session?"), this);
label->setObjectName(QStringLiteral("restoresessionlabel"));
label->setSizePolicy(QSizePolicy::Fixed, QSizePolicy::Fixed);
......@@ -30,7 +30,7 @@ CrashWidget::CrashWidget(QWidget *parent)
labelLayout->addWidget(label);
labelLayout->addStretch(0);
auto *buttonLayout = new QHBoxLayout;
auto buttonLayout = new QHBoxLayout;
vbox->addLayout(buttonLayout);
buttonLayout->addStretch(0);
......
......@@ -359,7 +359,7 @@ void Akregator::Feed::loadFavicon(const QString &url, bool downloadFavicon)
if (u.isLocalFile()) {
setFaviconLocalPath(u.toLocalFile());
} else {
auto *job = new Akregator::DownloadFeedIconJob(this);
auto job = new Akregator::DownloadFeedIconJob(this);
job->setFeedIconUrl(u);
job->setDownloadFavicon(downloadFavicon);
connect(job, &DownloadFeedIconJob::result, this, [this](const QString &fileName) {
......@@ -585,7 +585,7 @@ QDomElement Akregator::Feed::toOPML(QDomElement parent, QDomDocument document) c
KJob *Akregator::Feed::createMarkAsReadJob()
{
auto *job = new ArticleModifyJob;
auto job = new ArticleModifyJob;
const auto arts = articles();
for (const Article &i : arts) {
const ArticleId aid = {xmlUrl(), i.guid()};
......
......@@ -587,7 +587,7 @@ void FeedListManagementImpl::removeFeed(const QString &url, const QString &catId
if (lastcatid == i->parent()->id()) {
if (i->xmlUrl().compare(url) == 0) {
qCDebug(AKREGATOR_LOG) << "id:" << i->id();
auto *job = new DeleteSubscriptionJob;
auto job = new DeleteSubscriptionJob;
job->setSubscriptionId(i->id());
job->start();
}
......
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment